From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v5 09/11] ARM: imx: add imx7d clk tree support Date: Tue, 21 Apr 2015 15:47:02 -0500 Message-ID: References: <1429628007-8892-1-git-send-email-Frank.Li@freescale.com> <1429628007-8892-10-git-send-email-Frank.Li@freescale.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: Sender: linux-gpio-owner@vger.kernel.org To: Zhi Li Cc: "Frank.Li@freescale.com" , Shawn Guo , Linus Walleij , Rob Herring , "linux-arm-kernel@lists.infradead.org" , "linux-gpio@vger.kernel.org" , "devicetree@vger.kernel.org" , Anson Huang , Adrian Alonso List-Id: devicetree@vger.kernel.org On Tue, Apr 21, 2015 at 3:39 PM, Zhi Li wrote: > On Tue, Apr 21, 2015 at 3:30 PM, Rob Herring wrote: >> On Tue, Apr 21, 2015 at 9:53 AM, wrote: >>> From: Frank Li >>> >>> Add i.MX7D clk tree support. >>> >>> Enable all clock to bring up imx7. >>> Clock framework need be modified a little since imx7d >>> change clock design. otherwise system will halt and block the >>> other part upstream. >>> >>> All clock refine need wait for Dong Aisheng's patch >>> clk: support clocks which requires parent clock on during operation >>> Or other solution ready. >>> >>> Signed-off-by: Anson Huang >>> Signed-off-by: Adrian Alonso >>> Signed-off-by: Frank Li >>> --- >>> arch/arm/mach-imx/clk-imx7d.c | 887 ++++++++++++++++++++++++++++++++++++++++++ >>> arch/arm/mach-imx/clk-pllv3.c | 16 +- >>> arch/arm/mach-imx/clk.h | 9 + >>> 3 files changed, 911 insertions(+), 1 deletion(-) >>> create mode 100644 arch/arm/mach-imx/clk-imx7d.c >> >> Why is i.MX clock code not moved to drivers/clk? > > Guo Shawn: > what's plan clock code move to driver/clk? > > Rob: > It is not related i.mx7 bring up. > There are many upstream work depend on this. > we can work on code movement after that. > Are you okay? If it was going in my tree, no. But it is not, so it is not my call. However, I would not let you continue to add stuff if you have not done the clean-up that has been done for almost every other modern platform. Rob