devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Andrzej Hajda <a.hajda@samsung.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>, Pawel Moll <pawel.moll@arm.com>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	"open list:DRM DRIVERS" <dri-devel@lists.freedesktop.org>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Kumar Gala <galak@codeaurora.org>,
	Thierry Reding <treding@nvidia.com>,
	Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH 2/3] dt-bindings: add Silicon Image SiI8620 bridge bindings
Date: Wed, 9 Dec 2015 15:54:19 -0600	[thread overview]
Message-ID: <CAL_JsqLuzztHao753f44cE4MDc_6HAhsKpqrmoyhCqf13AYjpA@mail.gmail.com> (raw)
In-Reply-To: <5667FB4F.4000006@samsung.com>

On Wed, Dec 9, 2015 at 3:58 AM, Andrzej Hajda <a.hajda@samsung.com> wrote:
> Hi Rob,
>
> Thanks for review.
>
>
> On 12/09/2015 04:47 AM, Rob Herring wrote:
>> On Tue, Dec 08, 2015 at 02:49:05PM +0100, Andrzej Hajda wrote:
>>> SiI8620 transmitter converts eTMDS/HDMI signal to MHL 3.0. It is controlled
>>> via I2C bus.
>>>
>>> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
>>> ---
>>>  .../bindings/video/bridge/sil-sii8620.txt          | 34 ++++++++++++++++++++++
>>>  1 file changed, 34 insertions(+)
>>>  create mode 100644 Documentation/devicetree/bindings/video/bridge/sil-sii8620.txt
>>>
>>> diff --git a/Documentation/devicetree/bindings/video/bridge/sil-sii8620.txt b/Documentation/devicetree/bindings/video/bridge/sil-sii8620.txt

[...]

>>> +            port {
>>> +                    mhl_to_hdmi: endpoint {
>>> +                            remote-endpoint = <&hdmi_to_mhl>;
>>> +                    };
>>> +            };
>> I'd like to see this have a port to a connector node, too. Possibly
>> that can come later.
>
> MHL standard is connector agnostic, usually MHL wires are routed
> via multi-function microUSB connector, which can serve also for
> USB/charging/UART....
> There is additional logic to determine which cable is currently
> connected, usually
> implemented by extcon driver.
> I am not sure if/how it should be represented in DT. What do you think
> about it?

Probably all the more reason to have a connector defined, but for
muxed connectors I'm not sure how we should handle them and having
both drm connectors and extcon connectors is a problem. Like I said,
it can come later.

Rob
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2015-12-09 21:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-08 13:49 [PATCH 0/3] drm/bridge: add Silicon Image SiI8620 driver Andrzej Hajda
2015-12-08 13:49 ` [PATCH 1/3] video: add header file for Mobile High-Definition Link (MHL) interface Andrzej Hajda
2015-12-08 13:49 ` [PATCH 2/3] dt-bindings: add Silicon Image SiI8620 bridge bindings Andrzej Hajda
2015-12-09  3:47   ` Rob Herring
2015-12-09  9:58     ` Andrzej Hajda
2015-12-09 21:54       ` Rob Herring [this message]
2015-12-08 13:49 ` [PATCH 3/3] drm/bridge: add Silicon Image SiI8620 driver Andrzej Hajda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAL_JsqLuzztHao753f44cE4MDc_6HAhsKpqrmoyhCqf13AYjpA@mail.gmail.com \
    --to=robh@kernel.org \
    --cc=a.hajda@samsung.com \
    --cc=b.zolnierkie@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=kyungmin.park@samsung.com \
    --cc=m.szyprowski@samsung.com \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=treding@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).