From: Rob Herring <robh@kernel.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Markus Pargmann <mpa@pengutronix.de>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
Alexandre Courbot <acourbot@nvidia.com>,
Johan Hovold <johan@kernel.org>,
Michael Welling <mwelling@ieee.org>,
Bamvor Jian Zhang <bamvor.zhangjian@linaro.org>,
Grant Likely <grant.likely@linaro.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH 3/4] gpio: dt-bindings: Declare gpio-hog optional for GPIO subnodes
Date: Tue, 8 Mar 2016 22:27:10 -0600 [thread overview]
Message-ID: <CAL_JsqLxQkyc6BbFLbZgU2OS93B2k74FJhF-YbcZ1UX+KUMvNw@mail.gmail.com> (raw)
In-Reply-To: <CACRpkdaE64pjnr=hn0nMJb-KHx5GhvOSrdhNWJucY+UJVcV18w@mail.gmail.com>
On Tue, Mar 8, 2016 at 9:53 PM, Linus Walleij <linus.walleij@linaro.org> wrote:
> On Wed, Feb 24, 2016 at 6:25 AM, Rob Herring <robh@kernel.org> wrote:
>> On Tue, Feb 23, 2016 at 08:54:48AM +0100, Markus Pargmann wrote:
>
>>> +Optional properties:
>>> +- line-name: The GPIO name. If not present the node name is used.
>>
>> I'd like to deprecate line-name in favor of the standard property
>> for user visible names "label".
>
> This causes some unfortunate confusion wrt internal linux naming.
Yes.
> GPIO lines have two "names"
>
> - The "name" is what the line (pin) is named
> on the chip, or the name of the rail going out on the board, from the chip,
> so it is a producer name.
Who/what uses this?
> - Then the GPIO consumers set a second name, called "label"
> (confusingly) so we can see in e.g. debugfs and now also the userspace
> ABI who is using it.
>
> I named these "name" and "consumer" in the userspace ABI, I think
> I should take a round and rename it from "label" to "consumer"
> also inside the kernel to avoid confusion with this, because "label"
> in DT is going to be converted to "name" in the GPIOlib and
> then it also has something named "label" and that is another thing,
> argh!
There is still confusion because DT label should be the consumer side,
not the SoC pin name.
Then of course you could have 3 levels of names needed if you have SoC
pin, board connector pin, and mezzanine consumer.
Rob
next prev parent reply other threads:[~2016-03-09 4:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-23 7:54 [PATCH 1/4] tools: gpio: Small updates for output format Markus Pargmann
2016-02-23 7:54 ` [PATCH 2/4] tools: gpio: Add necessary include paths Markus Pargmann
2016-02-23 13:26 ` Linus Walleij
2016-02-24 6:39 ` Markus Pargmann
2016-02-23 7:54 ` [PATCH 3/4] gpio: dt-bindings: Declare gpio-hog optional for GPIO subnodes Markus Pargmann
2016-02-23 13:37 ` Linus Walleij
2016-02-23 23:25 ` Rob Herring
2016-02-24 7:01 ` Markus Pargmann
2016-03-02 15:41 ` Rob Herring
2016-03-09 4:07 ` Linus Walleij
2016-03-09 3:53 ` Linus Walleij
2016-03-09 4:27 ` Rob Herring [this message]
2016-03-09 5:56 ` Linus Walleij
2016-02-23 7:54 ` [PATCH 4/4] gpio: Add parsing of DT GPIO line-names Markus Pargmann
2016-02-23 13:36 ` Linus Walleij
2016-02-24 7:03 ` Markus Pargmann
2016-03-15 8:41 ` Linus Walleij
2016-02-23 13:21 ` [PATCH 1/4] tools: gpio: Small updates for output format Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_JsqLxQkyc6BbFLbZgU2OS93B2k74FJhF-YbcZ1UX+KUMvNw@mail.gmail.com \
--to=robh@kernel.org \
--cc=acourbot@nvidia.com \
--cc=bamvor.zhangjian@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=johan@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=mpa@pengutronix.de \
--cc=mwelling@ieee.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).