From: Rob Herring <robh@kernel.org>
To: Lars Persson <lars.persson@axis.com>
Cc: Lars Persson <larper@axis.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
Ulf Hansson <ulf.hansson@linaro.org>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>
Subject: Re: [PATCH v4 1/3] mmc: dt: usdhi6rol0: add optional pinctrl binding
Date: Tue, 26 Apr 2016 08:19:52 -0500 [thread overview]
Message-ID: <CAL_JsqLxVDoOma+CfvoxSyDK5gybFWX3cSWBH2BWiyaAC85+gw@mail.gmail.com> (raw)
In-Reply-To: <571F5DB4.7090303@axis.com>
On Tue, Apr 26, 2016 at 7:23 AM, Lars Persson <lars.persson@axis.com> wrote:
>
>
> On 04/22/2016 10:27 PM, Rob Herring wrote:
>>
>> On Thu, Apr 21, 2016 at 03:55:42PM +0200, Lars Persson wrote:
>>>
>>> Add a pinctrl binding to specify different pin settings for high speed
>>> modes and UHS modes.
>>>
>>> Signed-off-by: Lars Persson <larper@axis.com>
>>> ---
>>> Documentation/devicetree/bindings/mmc/usdhi6rol0.txt | 6 ++++++
>>> 1 file changed, 6 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/mmc/usdhi6rol0.txt
>>> b/Documentation/devicetree/bindings/mmc/usdhi6rol0.txt
>>> index 8babdaa..6d1b797 100644
>>> --- a/Documentation/devicetree/bindings/mmc/usdhi6rol0.txt
>>> +++ b/Documentation/devicetree/bindings/mmc/usdhi6rol0.txt
>>> @@ -12,6 +12,12 @@ Optional properties:
>>>
>>> - vmmc-supply: a phandle of a regulator, supplying Vcc to the
>>> card
>>> - vqmmc-supply: a phandle of a regulator, supplying VccQ to the
>>> card
>>> +- pinctrl-names: Can contain a "default" entry and a "state_uhs"
>>
>>
>> Don't use underscores. Just "uhs" should be sufficient, right?
>
>
> I do not object to this, but for consistency it seems better with state_uhs
> that existing bindings use.
Okay. Consistency is better.
Rob
next prev parent reply other threads:[~2016-04-26 13:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-21 13:55 [PATCH v4 0/3] mmc: usdhi6rol0: UHS support Lars Persson
[not found] ` <cover.1461246772.git.larper-VrBV9hrLPhE@public.gmane.org>
2016-04-21 13:55 ` [PATCH v4 1/3] mmc: dt: usdhi6rol0: add optional pinctrl binding Lars Persson
2016-04-22 20:27 ` Rob Herring
2016-04-26 12:23 ` Lars Persson
2016-04-26 13:19 ` Rob Herring [this message]
2016-04-21 13:55 ` [PATCH v4 2/3] mmc: usdhi6rol0: add support for UHS modes Lars Persson
2016-04-22 12:53 ` Ulf Hansson
2016-04-21 13:55 ` [PATCH v4 3/3] mmc: usdhi6rol0: add pinctrl to set pin drive strength Lars Persson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_JsqLxVDoOma+CfvoxSyDK5gybFWX3cSWBH2BWiyaAC85+gw@mail.gmail.com \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=g.liakhovetski@gmx.de \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=larper@axis.com \
--cc=lars.persson@axis.com \
--cc=linux-mmc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).