From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v4 1/3] mmc: dt: usdhi6rol0: add optional pinctrl binding Date: Tue, 26 Apr 2016 08:19:52 -0500 Message-ID: References: <20160422202733.GA11270@rob-hp-laptop> <571F5DB4.7090303@axis.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <571F5DB4.7090303@axis.com> Sender: linux-mmc-owner@vger.kernel.org To: Lars Persson Cc: Lars Persson , "linux-mmc@vger.kernel.org" , "devicetree@vger.kernel.org" , Guennadi Liakhovetski , Ulf Hansson , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala List-Id: devicetree@vger.kernel.org On Tue, Apr 26, 2016 at 7:23 AM, Lars Persson wrote: > > > On 04/22/2016 10:27 PM, Rob Herring wrote: >> >> On Thu, Apr 21, 2016 at 03:55:42PM +0200, Lars Persson wrote: >>> >>> Add a pinctrl binding to specify different pin settings for high speed >>> modes and UHS modes. >>> >>> Signed-off-by: Lars Persson >>> --- >>> Documentation/devicetree/bindings/mmc/usdhi6rol0.txt | 6 ++++++ >>> 1 file changed, 6 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/mmc/usdhi6rol0.txt >>> b/Documentation/devicetree/bindings/mmc/usdhi6rol0.txt >>> index 8babdaa..6d1b797 100644 >>> --- a/Documentation/devicetree/bindings/mmc/usdhi6rol0.txt >>> +++ b/Documentation/devicetree/bindings/mmc/usdhi6rol0.txt >>> @@ -12,6 +12,12 @@ Optional properties: >>> >>> - vmmc-supply: a phandle of a regulator, supplying Vcc to the >>> card >>> - vqmmc-supply: a phandle of a regulator, supplying VccQ to the >>> card >>> +- pinctrl-names: Can contain a "default" entry and a "state_uhs" >> >> >> Don't use underscores. Just "uhs" should be sufficient, right? > > > I do not object to this, but for consistency it seems better with state_uhs > that existing bindings use. Okay. Consistency is better. Rob