From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH 2/2] char: xilinx_hwicap: Fix warnings in the driver Date: Thu, 10 Aug 2017 13:16:31 -0500 Message-ID: References: <6da0afe2afd2c7a21d16da9a9c7acab09385ae2c.1501247838.git.michal.simek@xilinx.com> <79e2e616a8b7dbf38eb72ba0b620230017dcbc65.1501247838.git.michal.simek@xilinx.com> <20170803223218.ilryp5spqztsr3cz@rob-hp-laptop> <0e40a687-e11b-b5bb-24f0-465144c98929@xilinx.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <0e40a687-e11b-b5bb-24f0-465144c98929-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Michal Simek Cc: "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Michal Simek , Nava kishore Manne , =?UTF-8?Q?S=C3=B6ren_Brinkmann?= , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Arnd Bergmann , Greg Kroah-Hartman , Mark Rutland , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" List-Id: devicetree@vger.kernel.org On Fri, Aug 4, 2017 at 2:49 AM, Michal Simek wrote: > On 4.8.2017 00:32, Rob Herring wrote: >> On Fri, Jul 28, 2017 at 03:17:26PM +0200, Michal Simek wrote: >>> From: Nava kishore Manne >>> >>> This patch fixes the below warning >>> --> Use #include instead of >>> --> Use #include instead of >>> --> please, no space before tabs >>> --> Block comments use a trailing */ on a separate line >>> --> Possible unnecessary 'out of memory' message >>> --> Block comments use * on subsequent lines >>> --> Block comments use a trailing */ on a separate line >>> --> braces {} are not necessary for any arm of this statement >>> --> DT compatible string "xlnx,opb-hwicap-1.00.b" >>> appears un-documented >>> --> DT compatible string "xlnx,xps-hwicap-1.00.a" >>> appears un-documented >>> >>> Signed-off-by: Nava kishore Manne >>> Signed-off-by: Michal Simek >>> --- >>> >>> Documentation/devicetree/bindings/xilinx.txt | 2 ++ >> >> It's preferred to split bindings to separate patches. No need unless you >> respin: >> >> Acked-by: Rob Herring > > thanks. Was there any outcome from that discussion to extract binding > out of kernel source code? Well, the reason to split the patches is so the history of the filtered DT repository we generate from the kernel tree[1] looks saner. As far as actually moving things out, no there's not been any movement. My biggest concern with moving things out would be the loss of kernel subsystem maintainers' review. Once it's a separate tree and not merged thru their tree, we'd loose their reviews and I don't have confidence that we'd be gaining reviews from other places. Though some subsystem maintainers merge bindings and don't look at them already. Rob [1] https://git.kernel.org/pub/scm/linux/kernel/git/devicetree/devicetree-rebasing.git/ -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html