From: Rob Herring <robh@kernel.org>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Hans Verkuil <hans.verkuil@cisco.com>,
dri-devel <dri-devel@lists.freedesktop.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>
Subject: Re: [PATCH 7/9] dt-bindings: media/s5p-cec.txt: document needs-hpd property
Date: Fri, 9 Jun 2017 10:31:49 -0500 [thread overview]
Message-ID: <CAL_JsqLzxMSdQGCiCBa2-VKpe==djCsqP9GxywJ-X-defiRXMQ@mail.gmail.com> (raw)
In-Reply-To: <2fa55431-bef2-9340-4ce8-e06f9648e109@xs4all.nl>
On Fri, Jun 9, 2017 at 9:11 AM, Hans Verkuil <hverkuil@xs4all.nl> wrote:
> On 09/06/17 16:07, Rob Herring wrote:
>> On Wed, Jun 07, 2017 at 04:46:14PM +0200, Hans Verkuil wrote:
>>> From: Hans Verkuil <hans.verkuil@cisco.com>
>>>
>>> Needed for boards that wire the CEC pin in such a way that it
>>> is unavailable when the HPD is low.
>>>
>>> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
>>> Cc: Krzysztof Kozlowski <krzk@kernel.org>
>>> Cc: Andrzej Hajda <a.hajda@samsung.com>
>>> Cc: devicetree@vger.kernel.org
>>> ---
>>> Documentation/devicetree/bindings/media/s5p-cec.txt | 6 ++++++
>>> 1 file changed, 6 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/media/s5p-cec.txt b/Documentation/devicetree/bindings/media/s5p-cec.txt
>>> index 4bb08d9d940b..261af4d1a791 100644
>>> --- a/Documentation/devicetree/bindings/media/s5p-cec.txt
>>> +++ b/Documentation/devicetree/bindings/media/s5p-cec.txt
>>> @@ -17,6 +17,12 @@ Required properties:
>>> - samsung,syscon-phandle - phandle to the PMU system controller
>>> - hdmi-phandle - phandle to the HDMI controller
>>>
>>> +Optional:
>>> + - needs-hpd : if present the CEC support is only available when the HPD
>>> + is high. Some boards only let the CEC pin through if the HPD is high, for
>>> + example if there is a level converter that uses the HPD to power up
>>> + or down.
>>
>> Seems like something common. Can you document in a common location?
>
> Should we do the same with hdmi-phandle? It is also used by CEC drivers to find
> the HDMI driver.
Yes.
> Currently only used by s5p-cec and stih-cec, but there will be more.
>
> I guess this would be a sensible place to document this:
>
> Documentation/devicetree/bindings/media/cec.txt
Sounds good. You can do this as a follow-up to this patch if you want.
For this one:
Acked-by: Rob Herring <robh@kernel.org>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2017-06-09 15:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170607144616.15247-1-hverkuil@xs4all.nl>
2017-06-07 14:46 ` [PATCH 7/9] dt-bindings: media/s5p-cec.txt: document needs-hpd property Hans Verkuil
2017-06-09 14:07 ` Rob Herring
2017-06-09 14:11 ` Hans Verkuil
2017-06-09 15:31 ` Rob Herring [this message]
2017-06-09 15:55 ` Hans Verkuil
[not found] ` <8e6ed9b6-5b4b-8650-2c92-47a593e73d94-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
2017-06-09 16:46 ` Rob Herring
2017-06-07 14:46 ` [PATCH 8/9] s5p_cec: set the CEC_CAP_NEEDS_HPD flag if needed Hans Verkuil
[not found] ` <CGME20170612124120epcas1p3ef17f5a1f6f71c00757d4f3ee283ffc8@epcas1p3.samsung.com>
[not found] ` <20170607144616.15247-9-hverkuil-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org>
2017-06-12 12:41 ` Sylwester Nawrocki
2017-06-07 14:46 ` [PATCH 9/9] ARM: dts: exynos: add needs-hpd to &hdmicec for Odroid-U3 Hans Verkuil
2017-06-07 18:36 ` Krzysztof Kozlowski
2017-06-07 18:59 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL_JsqLzxMSdQGCiCBa2-VKpe==djCsqP9GxywJ-X-defiRXMQ@mail.gmail.com' \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hans.verkuil@cisco.com \
--cc=hverkuil@xs4all.nl \
--cc=krzk@kernel.org \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).