From: Peter Robinson <pbrobinson@gmail.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
NXP Linux Team <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <fabio.estevam@nxp.com>,
Shawn Guo <shawnguo@kernel.org>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] ARM: dts: imx6sx-udoo-neo: enable i2c-2 and i2c-4 for onboard sensors
Date: Mon, 16 Jul 2018 15:43:21 +0100 [thread overview]
Message-ID: <CALeDE9N5AnQba5LirHegWgz2_3Rr6cCT_ttTUtg38OdvdegpFA@mail.gmail.com> (raw)
In-Reply-To: <CAOMZO5B+1atjr3Ur7EGMJSEbqT8zqWdKZWNHrkyCGvgGM4nJFg@mail.gmail.com>
Hi Fabio,
On Fri, Jul 13, 2018 at 7:08 PM, Fabio Estevam <festevam@gmail.com> wrote:
> Hi Peter,
>
> On Fri, Jul 13, 2018 at 2:11 PM, Peter Robinson <pbrobinson@gmail.com> wrote:
>
>> +&i2c4 { /* Onboard Motion sensors */
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pinctrl_i2c4>;
>> + clock-frequency = <100000>;
>> + status = "okay";
>> +};
>
> Would it be possible to add i2c4 to the common dtsi file instead?
>
> I haven't checked the schematics, but if it is only the
> imx6sx-udoo-neo-basic.dts that does not have the i2c4 node, then
> maybe you could add i2c4 to the dtsi and disable it inside
> imx6sx-udoo-neo-basic.dts?
Enabling it to turn around and then disable it again seemed counter
intuitive to me hence the way I did, the WiFi in done that way even
though it's not on all boards and I would imagine it would cause
errors on the devices where there isn't wifi although I don't have
those model(s) to verify.
Peter
next prev parent reply other threads:[~2018-07-16 14:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-13 17:11 [PATCH] ARM: dts: imx6sx-udoo-neo: enable i2c-2 and i2c-4 for onboard sensors Peter Robinson
2018-07-13 18:08 ` Fabio Estevam
2018-07-16 14:43 ` Peter Robinson [this message]
2018-07-17 14:20 ` Fabio Estevam
2019-05-27 17:05 ` Peter Robinson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALeDE9N5AnQba5LirHegWgz2_3Rr6cCT_ttTUtg38OdvdegpFA@mail.gmail.com \
--to=pbrobinson@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).