From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35DA4C2B9F7 for ; Tue, 25 May 2021 03:15:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0CB0361404 for ; Tue, 25 May 2021 03:15:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229575AbhEYDQg (ORCPT ); Mon, 24 May 2021 23:16:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35986 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230219AbhEYDQg (ORCPT ); Mon, 24 May 2021 23:16:36 -0400 Received: from mail-pf1-x42e.google.com (mail-pf1-x42e.google.com [IPv6:2607:f8b0:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 70A52C061574 for ; Mon, 24 May 2021 20:15:07 -0700 (PDT) Received: by mail-pf1-x42e.google.com with SMTP id q67so5440226pfb.4 for ; Mon, 24 May 2021 20:15:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=VHDFyefEfXv2T1h/kXDPOn5vVw8tSm/6FW05x+E2j40=; b=merHIeKNi5Uu6C9TAUujDNIN9FxrI34YUx7aW4WyFELIyYppIt99C4UwGvzWaArcmu 9EaYZFbnrmtDjrMZ7c8349ke6DKJjWiZDCUD5epOu2PqMIr5kYM1CoXZ0XNE1vQ3QFiu bvf2bDyHaIMES3MNNrHcengJbyjgwpDl3VY20= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VHDFyefEfXv2T1h/kXDPOn5vVw8tSm/6FW05x+E2j40=; b=j/Xx4Fd+AM23tHVO46F1dW1ao+hQdp6g6YVen1wbBA8BabCGsDly6W0YnzFHG7QGqa f11BU4RZueQQI3pDi/lLOjfQ0yaiPPKI7BdRwquneOzOVFxcnUFHtly7VI+NZPdaBsR/ JeWfC07ttWkqC5oueMUWFdI5/Y9nef90qgVnq/QTFH3seh1hCGrG4rKyLSYS3zrnnHKQ vYIMnw/WP04M7F0098bNIrtepkcnxjFsL22OZgZBvpO7ou9klSMmKJhiOP43XWC5OqQp aq/a8nfxaXExp5IFlpFrB0TLrlV5L/mhibykq1hwjPxbcqOTeSzx9pU9X4hIkXIZ5PTL Jo6w== X-Gm-Message-State: AOAM530//KFlXmkWBixJ5Irwf83+lT8wjTjXEZJ8Y+YZiqut/uRyR7LU qZiP7RcDHMHAhWaLq5kTf4BaSOFzqWUddg== X-Google-Smtp-Source: ABdhPJxv7iUJ+qYbYo3dKwq/Jag/g9w97fg9FsGoRIGha1c3q/w40QapAUgZ8IwaoA8L33ogi5hV8w== X-Received: by 2002:a65:67d5:: with SMTP id b21mr16596164pgs.117.1621912506723; Mon, 24 May 2021 20:15:06 -0700 (PDT) Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com. [209.85.215.174]) by smtp.gmail.com with ESMTPSA id o186sm12018429pfg.170.2021.05.24.20.15.06 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 May 2021 20:15:06 -0700 (PDT) Received: by mail-pg1-f174.google.com with SMTP id q15so21595070pgg.12 for ; Mon, 24 May 2021 20:15:06 -0700 (PDT) X-Received: by 2002:a6b:7b08:: with SMTP id l8mr16990516iop.50.1621912094090; Mon, 24 May 2021 20:08:14 -0700 (PDT) MIME-Version: 1.0 References: <20210518064215.2856977-1-tientzu@chromium.org> <20210518064215.2856977-2-tientzu@chromium.org> <170a54f2-be20-ec29-1d7f-3388e5f928c6@gmail.com> In-Reply-To: From: Claire Chang Date: Tue, 25 May 2021 11:08:03 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v7 01/15] swiotlb: Refactor swiotlb init functions To: Konrad Rzeszutek Wilk Cc: Florian Fainelli , Rob Herring , mpe@ellerman.id.au, Joerg Roedel , Will Deacon , Frank Rowand , boris.ostrovsky@oracle.com, jgross@suse.com, Christoph Hellwig , Marek Szyprowski , benh@kernel.crashing.org, paulus@samba.org, "list@263.net:IOMMU DRIVERS" , sstabellini@kernel.org, Robin Murphy , grant.likely@arm.com, xypron.glpk@gmx.de, Thierry Reding , mingo@kernel.org, bauerman@linux.ibm.com, peterz@infradead.org, Greg KH , Saravana Kannan , "Rafael J . Wysocki" , heikki.krogerus@linux.intel.com, Andy Shevchenko , Randy Dunlap , Dan Williams , Bartosz Golaszewski , linux-devicetree , lkml , linuxppc-dev@lists.ozlabs.org, xen-devel@lists.xenproject.org, Nicolas Boichat , Jim Quinlan , Tomasz Figa , bskeggs@redhat.com, Bjorn Helgaas , chris@chris-wilson.co.uk, Daniel Vetter , airlied@linux.ie, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, jani.nikula@linux.intel.com, Jianxiong Gao , joonas.lahtinen@linux.intel.com, linux-pci@vger.kernel.org, maarten.lankhorst@linux.intel.com, matthew.auld@intel.com, rodrigo.vivi@intel.com, thomas.hellstrom@linux.intel.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, May 24, 2021 at 11:53 PM Konrad Rzeszutek Wilk wrote: > > > > do the set_memory_decrypted()+memset(). Is this okay or should > > > swiotlb_init_io_tlb_mem() add an additional argument to do this > > > conditionally? > > > > I'm actually not sure if this it okay. If not, will add an additional > > argument for it. > > Any observations discovered? (Want to make sure my memory-cache has the > correct semantics for set_memory_decrypted in mind). It works fine on my arm64 device. > > > > > -- > > > Florian