From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Coquelin Subject: Re: [PATCH v2 02/18] ARM: ARMv7M: Enlarge vector table to 256 entries Date: Mon, 23 Feb 2015 11:33:31 +0100 Message-ID: References: <1424455277-29983-1-git-send-email-mcoquelin.stm32@gmail.com> <1424455277-29983-3-git-send-email-mcoquelin.stm32@gmail.com> <20150220194756.GS19388@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20150220194756.GS19388@pengutronix.de> Sender: linux-arch-owner@vger.kernel.org To: =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= Cc: =?UTF-8?Q?Andreas_F=C3=A4rber?= , Geert Uytterhoeven , Rob Herring , Philipp Zabel , Jonathan Corbet , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , Daniel Lezcano , Thomas Gleixner , Linus Walleij , Greg Kroah-Hartman , Jiri Slaby , Arnd Bergmann , Andrew Morton , "David S. Miller" , Mauro Carvalho Chehab , Joe Perches , Antti Palosaari , Tejun Heo , Will Deacon List-Id: devicetree@vger.kernel.org 2015-02-20 20:47 GMT+01:00 Uwe Kleine-K=C3=B6nig : > On Fri, Feb 20, 2015 at 07:01:01PM +0100, Maxime Coquelin wrote: >> From Cortex-M reference manuals, the nvic supports up to 240 interru= pts. >> So the number of entries in vectors table is up to 256. >> >> This patch adds a new config flag to specify the number of external = interrupts. >> Some ifdeferies are added in order to respect the natural alignment = without >> wasting too much space on smaller systems. >> >> Signed-off-by: Maxime Coquelin >> --- >> arch/arm/kernel/entry-v7m.S | 13 +++++++++---- >> arch/arm/mm/Kconfig | 15 +++++++++++++++ >> 2 files changed, 24 insertions(+), 4 deletions(-) >> >> diff --git a/arch/arm/kernel/entry-v7m.S b/arch/arm/kernel/entry-v7m= =2ES >> index 8944f49..68cde36 100644 >> --- a/arch/arm/kernel/entry-v7m.S >> +++ b/arch/arm/kernel/entry-v7m.S >> @@ -117,9 +117,14 @@ ENTRY(__switch_to) >> ENDPROC(__switch_to) >> >> .data >> - .align 8 >> +#if CONFIG_CPUV7M_NUM_IRQ <=3D 112 > I would have called this CONFIG_CPU_V7M_NUM_IRQ to match the already > existing CPU_V7M symbol. That's better indeed. It will be changed in v3. > >> + .align 9 >> +#else >> + .align 10 >> +#endif >> + > > Other than that: > Acked-by: Uwe Kleine-K=C3=B6nig > > Who do you target to apply this series? I guess it should go through Russell's Patch Tracking System? Thanks, Maxime > > Best regards > Uwe > > -- > Pengutronix e.K. | Uwe Kleine-K=C3=B6nig = | > Industrial Linux Solutions | http://www.pengutronix.d= e/ |