From: Pavitrakumar Managutte <pavitrakumarm@vayavyalabs.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: devicetree@vger.kernel.org, herbert@gondor.apana.org.au,
linux-crypto@vger.kernel.org, robh@kernel.org,
Ruud.Derwig@synopsys.com, manjunath.hadli@vayavyalabs.com,
bhoomikak@vayavyalabs.com
Subject: Re: [PATCH v9 7/7] dt-bindings: crypto: Document support for SPAcc
Date: Tue, 1 Oct 2024 12:53:36 +0530 [thread overview]
Message-ID: <CALxtO0nPzYpW7n37c5hdcigQtq+NOSxaPmLqeiwwiB8kumHjWw@mail.gmail.com> (raw)
In-Reply-To: <fsp2l2ktvwznm64kwlb23yxlvioi47inzdwcngowbvet43us4k@svi4b7eq7gx7>
Hi Krzysztof,
I fully agree, some things got missed out; they were supposed to be addressed
in the v9 patch. Not contesting that. My apologies.
We are doing a code cleanup based on your inputs and previous comments.
I will address everything.
Warm regards,
PK
On Tue, Oct 1, 2024 at 12:03 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On Mon, Sep 30, 2024 at 03:00:54PM +0530, Pavitrakumar M wrote:
> > Add DT bindings related to the SPAcc driver for Documentation.
> > DWC Synopsys Security Protocol Accelerator(SPAcc) Hardware Crypto
> > Engine is a crypto IP designed by Synopsys.
> >
> > Co-developed-by: Bhoomika Kadabi <bhoomikak@vayavyalabs.com>
> > Signed-off-by: Bhoomika Kadabi <bhoomikak@vayavyalabs.com>
> > Co-developed-by: Pavitrakumar Managutte <pavitrakumarm@vayavyalabs.com>
> > Signed-off-by: Pavitrakumar Managutte <pavitrakumarm@vayavyalabs.com>
> > Acked-by: Ruud Derwig <Ruud.Derwig@synopsys.com>
>
> Please run scripts/checkpatch.pl and fix reported warnings. Then please
> run and (probably) fix more warnings.
> Some warnings can be ignored, especially from --strict run, but the code
> here looks like it needs a fix. Feel free to get in touch if the warning
> is not clear.
>
> Best regards,
> Krzysztof
>
prev parent reply other threads:[~2024-10-01 7:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-30 9:30 [PATCH v9 0/7] Add SPAcc Crypto Driver Pavitrakumar M
2024-09-30 9:30 ` [PATCH v9 1/7] Add SPAcc Skcipher support Pavitrakumar M
2024-09-30 13:34 ` Krzysztof Kozlowski
2024-09-30 9:30 ` [PATCH v9 2/7] Add SPAcc AUTODETECT Support Pavitrakumar M
2024-09-30 9:30 ` [PATCH v9 3/7] Add SPAcc ahash support Pavitrakumar M
2024-09-30 9:30 ` [PATCH v9 4/7] Add SPAcc AEAD support Pavitrakumar M
2024-09-30 13:25 ` Krzysztof Kozlowski
2024-09-30 9:30 ` [PATCH v9 5/7] Add SPAcc Kconfig and Makefile Pavitrakumar M
2024-09-30 13:23 ` Krzysztof Kozlowski
2024-09-30 9:30 ` [PATCH v9 6/7] Add SPAcc compilation in crypto Pavitrakumar M
2024-09-30 13:22 ` Krzysztof Kozlowski
2024-09-30 9:30 ` [PATCH v9 7/7] dt-bindings: crypto: Document support for SPAcc Pavitrakumar M
2024-09-30 13:20 ` Krzysztof Kozlowski
2024-10-01 2:57 ` Pavitrakumar Managutte
2024-10-01 6:15 ` Krzysztof Kozlowski
2024-10-01 6:32 ` Krzysztof Kozlowski
2024-10-01 7:23 ` Pavitrakumar Managutte [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALxtO0nPzYpW7n37c5hdcigQtq+NOSxaPmLqeiwwiB8kumHjWw@mail.gmail.com \
--to=pavitrakumarm@vayavyalabs.com \
--cc=Ruud.Derwig@synopsys.com \
--cc=bhoomikak@vayavyalabs.com \
--cc=devicetree@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=krzk@kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=manjunath.hadli@vayavyalabs.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).