From: Jagath Jog J <jagathjog1996@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
andriy.shevchenko@linux.intel.com, lars@metafoo.de,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC 1/2] dt-bindings: iio: imu: Add DT binding doc for BMI323
Date: Thu, 28 Sep 2023 03:07:01 +0530 [thread overview]
Message-ID: <CAM+2EuJ+LGe5Gu8jek32yJe4cLYHSrrbND8WPyPsYsuyFSJNoQ@mail.gmail.com> (raw)
In-Reply-To: <20230924143126.60a142c4@jic23-huawei>
Hi Jonathan
On Sun, Sep 24, 2023 at 7:01 PM Jonathan Cameron <jic23@kernel.org> wrote:
>
> On Tue, 19 Sep 2023 22:14:40 +0530
> Jagath Jog J <jagathjog1996@gmail.com> wrote:
>
> > Hi Krzysztof,
> >
> > On Mon, Sep 18, 2023 at 5:55 PM Krzysztof Kozlowski
> > <krzysztof.kozlowski@linaro.org> wrote:
> > >
> > > On 18/09/2023 10:03, Jagath Jog J wrote:
> > > > Add devicetree description document for Bosch BMI323, a 6-Axis IMU.
> > >
> > > I don't know why this is RFC and cover letter does not explain it. Shall
> > > I just ignore it? Patch is no ready? Recently at least two times someone
> > > was disappointed that his code marked as RFC received my review.
> >
> > Thank you for reviewing. This was the sensor's first patch series,
> > so I initially submitted it as an RFC. I will mark it as "Patch"
> > in the next series.
>
> Have more confidence! RFCs need to have clearly stated questions.
> If you don't have any then you are putting forwards driver for review
> in ordering to get it merged upstream - so PATCH is appropriate.
> As you'll see many IIO drivers go through a 'few' revisions once they
> are posted (hopefully not too many!)
>
> Krzysztof is great at reviewing whatever shows up, but in many
> cases reviewers won't look at an RFC (unless a big discussion starts) because
> they aren't interested in open questions, just code that the author considers
> ready.
Thank you for your feedback and guidance. I appreciate
the insight into the RFC process and the importance of
clearly stated questions. I'll keep this in mind when
preparing future submissions.
Regards
Jagath
>
> Jonathan
next prev parent reply other threads:[~2023-09-27 21:37 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-18 8:03 [RFC 0/2] iio: imu: Add driver and dt-bindings for BMI323 Jagath Jog J
2023-09-18 8:03 ` [RFC 1/2] dt-bindings: iio: imu: Add DT binding doc " Jagath Jog J
2023-09-18 12:25 ` Krzysztof Kozlowski
2023-09-19 16:44 ` Jagath Jog J
2023-09-24 13:31 ` Jonathan Cameron
2023-09-27 21:37 ` Jagath Jog J [this message]
2023-09-24 13:37 ` Jonathan Cameron
2023-09-27 21:37 ` Jagath Jog J
2023-09-30 16:05 ` Jonathan Cameron
2023-10-08 6:24 ` Jagath Jog J
2023-10-10 9:00 ` Jonathan Cameron
2023-10-10 9:06 ` Linus Walleij
2023-10-10 14:42 ` Jonathan Cameron
2023-10-10 19:51 ` Linus Walleij
2023-10-13 8:16 ` Jonathan Cameron
2023-10-13 16:23 ` Jagath Jog J
2023-09-18 8:03 ` [RFC 2/2] iio: imu: Add driver for BMI323 IMU Jagath Jog J
2023-09-18 10:03 ` Andy Shevchenko
2023-09-19 22:43 ` Jagath Jog J
2023-09-20 13:24 ` Andy Shevchenko
2023-10-08 6:25 ` Jagath Jog J
2023-10-10 9:02 ` Jonathan Cameron
2023-09-24 14:30 ` Jonathan Cameron
2023-09-27 19:59 ` Jagath Jog J
2023-09-27 21:25 ` Denis Benato
2023-09-29 7:59 ` Jagath Jog J
2023-09-30 16:17 ` Jonathan Cameron
2023-10-01 13:53 ` Denis Benato
2023-10-03 20:35 ` Jagath Jog J
2023-09-30 16:13 ` Jonathan Cameron
2023-09-27 9:57 ` Uwe Kleine-König
2023-09-27 12:35 ` Andy Shevchenko
2023-09-27 14:34 ` Uwe Kleine-König
2023-10-01 8:20 ` Andy Shevchenko
2023-09-28 18:19 ` Jagath Jog J
2023-09-28 20:48 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAM+2EuJ+LGe5Gu8jek32yJe4cLYHSrrbND8WPyPsYsuyFSJNoQ@mail.gmail.com \
--to=jagathjog1996@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).