From mboxrd@z Thu Jan 1 00:00:00 1970 From: Abhilash Kesavan Subject: Re: [RFC PATCH 2/3] regulator: max77686: Add support for various operating modes Date: Wed, 12 Dec 2012 08:28:36 +0530 Message-ID: References: <1355120784-31118-1-git-send-email-a.kesavan@samsung.com> <1355120784-31118-2-git-send-email-a.kesavan@samsung.com> <1355120784-31118-3-git-send-email-a.kesavan@samsung.com> <20121210064650.GJ10927@opensource.wolfsonmicro.com> <20121211125713.GH9097@opensource.wolfsonmicro.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20121211125713.GH9097-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Mark Brown Cc: Kukjin Kim , sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, lrg-l0cyMroinI0@public.gmane.org List-Id: devicetree@vger.kernel.org On Tue, Dec 11, 2012 at 6:27 PM, Mark Brown wrote: > On Mon, Dec 10, 2012 at 02:06:49PM +0530, Abhilash Kesavan wrote: >> On Mon, Dec 10, 2012 at 1:49 PM, Abhilash Kesavan >> wrote: > >> > Mark Brown opensource.wolfsonmicro.com> writes: > >> >> Binding documenation is mandatory for any new OF properties, please add >> >> this. > >> > Patch 3/3 of this series adds documentation for the max77686-opmode property. > > There is no point in splitting changes like this up, it just makes > review harder - in this case it caused me to not read your patch due > to the missing documentation. Put the whole change together unless > things are getting too big to review. OK. Can you please have a look at Doug's proposal for handling the operating mode generically in patch 3/3 of this series. If you are OK with it then I'll start work on implementing it. Thanks, Abhilash