* Re: [RFC PATCH 2/3] regulator: max77686: Add support for various operating modes [not found] ` <loom.20121210T091624-754-eS7Uydv5nfjZ+VzJOa5vwg@public.gmane.org> @ 2012-12-10 8:36 ` Abhilash Kesavan 2012-12-11 12:57 ` Mark Brown 0 siblings, 1 reply; 3+ messages in thread From: Abhilash Kesavan @ 2012-12-10 8:36 UTC (permalink / raw) To: linux-kernel-u79uwXL29TY76Z2rM5mHXA, Mark Brown, lrg-l0cyMroinI0 Cc: Kukjin Kim, sameo-VuQAYsv1563Yd54FQh9/CA, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ Adding missed Cc's On Mon, Dec 10, 2012 at 1:49 PM, Abhilash Kesavan <kesavan.abhilash-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote: > Mark Brown <broonie <at> opensource.wolfsonmicro.com> writes: > > [...] >> Binding documenation is mandatory for any new OF properties, please add >> this. > Patch 3/3 of this series adds documentation for the max77686-opmode property. >> > > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFC PATCH 2/3] regulator: max77686: Add support for various operating modes 2012-12-10 8:36 ` [RFC PATCH 2/3] regulator: max77686: Add support for various operating modes Abhilash Kesavan @ 2012-12-11 12:57 ` Mark Brown [not found] ` <20121211125713.GH9097-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org> 0 siblings, 1 reply; 3+ messages in thread From: Mark Brown @ 2012-12-11 12:57 UTC (permalink / raw) To: Abhilash Kesavan Cc: linux-kernel, lrg, Olof Johansson, Doug Anderson, Thomas Abraham, Kukjin Kim, Grant Likely, devicetree-discuss, sameo [-- Attachment #1: Type: text/plain, Size: 638 bytes --] On Mon, Dec 10, 2012 at 02:06:49PM +0530, Abhilash Kesavan wrote: > On Mon, Dec 10, 2012 at 1:49 PM, Abhilash Kesavan > <kesavan.abhilash@gmail.com> wrote: > > Mark Brown <broonie <at> opensource.wolfsonmicro.com> writes: > >> Binding documenation is mandatory for any new OF properties, please add > >> this. > > Patch 3/3 of this series adds documentation for the max77686-opmode property. There is no point in splitting changes like this up, it just makes review harder - in this case it caused me to not read your patch due to the missing documentation. Put the whole change together unless things are getting too big to review. [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 836 bytes --] ^ permalink raw reply [flat|nested] 3+ messages in thread
[parent not found: <20121211125713.GH9097-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>]
* Re: [RFC PATCH 2/3] regulator: max77686: Add support for various operating modes [not found] ` <20121211125713.GH9097-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org> @ 2012-12-12 2:58 ` Abhilash Kesavan 0 siblings, 0 replies; 3+ messages in thread From: Abhilash Kesavan @ 2012-12-12 2:58 UTC (permalink / raw) To: Mark Brown Cc: Kukjin Kim, sameo-VuQAYsv1563Yd54FQh9/CA, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ, linux-kernel-u79uwXL29TY76Z2rM5mHXA, lrg-l0cyMroinI0 On Tue, Dec 11, 2012 at 6:27 PM, Mark Brown <broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org> wrote: > On Mon, Dec 10, 2012 at 02:06:49PM +0530, Abhilash Kesavan wrote: >> On Mon, Dec 10, 2012 at 1:49 PM, Abhilash Kesavan >> <kesavan.abhilash-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote: > >> > Mark Brown <broonie <at> opensource.wolfsonmicro.com> writes: > >> >> Binding documenation is mandatory for any new OF properties, please add >> >> this. > >> > Patch 3/3 of this series adds documentation for the max77686-opmode property. > > There is no point in splitting changes like this up, it just makes > review harder - in this case it caused me to not read your patch due > to the missing documentation. Put the whole change together unless > things are getting too big to review. OK. Can you please have a look at Doug's proposal for handling the operating mode generically in patch 3/3 of this series. If you are OK with it then I'll start work on implementing it. Thanks, Abhilash ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-12-12 2:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1355120784-31118-1-git-send-email-a.kesavan@samsung.com>
[not found] ` <1355120784-31118-2-git-send-email-a.kesavan@samsung.com>
[not found] ` <1355120784-31118-3-git-send-email-a.kesavan@samsung.com>
[not found] ` <20121210064650.GJ10927@opensource.wolfsonmicro.com>
[not found] ` <loom.20121210T091624-754@post.gmane.org>
[not found] ` <loom.20121210T091624-754-eS7Uydv5nfjZ+VzJOa5vwg@public.gmane.org>
2012-12-10 8:36 ` [RFC PATCH 2/3] regulator: max77686: Add support for various operating modes Abhilash Kesavan
2012-12-11 12:57 ` Mark Brown
[not found] ` <20121211125713.GH9097-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-12-12 2:58 ` Abhilash Kesavan
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).