From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="cXZDY253" Received: from mail-yb1-xb33.google.com (mail-yb1-xb33.google.com [IPv6:2607:f8b0:4864:20::b33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1943699 for ; Mon, 27 Nov 2023 08:29:01 -0800 (PST) Received: by mail-yb1-xb33.google.com with SMTP id 3f1490d57ef6-db35caa1749so3942570276.2 for ; Mon, 27 Nov 2023 08:29:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; t=1701102540; x=1701707340; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=i70tntcGFXXrEjgo++8Q6tFowckjpLWeV9hv9uXKYaM=; b=cXZDY2536itPDE7PfXTWEbUbOkFgqOcwJI7VnOisF1flRRAZhcwHFcV63m2oLNHb5N ndXJVc7U8CZiJ0YUV0V7CuAnXuWV6emssx43Rhr5Y91B52v6umhWH1Tm3za2TqVTzqMV 3/F+JJ4ojKAOp9azsK8pOMdcNROb4qRfyR/EQplABsKQRYuWbpNkVtqqf/sh1euusfzX S7HDrCSGsFtVZIMa3gpDMc0IrxikXi5bH98VC1F32r99u9/J1iK4v1A57jOss7TA+MJf yIXUX2eSoVPdsqw5EzT2yfHwb04A3py2eedK6c4vtXQ3vuhaYlEN5qScdPz4tXGYX8Ug V0yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701102540; x=1701707340; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=i70tntcGFXXrEjgo++8Q6tFowckjpLWeV9hv9uXKYaM=; b=ZT7xhLlZygdPjCrrkRDCFj4BUsCTUIzv0LazXBHGqrlEmqpVfBZtkbzmmivvgITRvI CL+nittoGLKulHsImesbICSKoaKkCyjpaQOyxhQPzh0Zxp8hBIVe8y5Sc2sq9Gwi0eG1 i8bH1m5POERShBHbYhFeaJlBd4GECgJeA9+HlYG5eGMnCxehLg4UmnZSml+VOMs/vOSv g18tedO2nfrV46XGohnzCVcbs3r8A3wGQjshGd/mb2zfXxLxo2s0Jl7YMfeKYKmNqy+s e5Rz+mfkdbq2wSiUjafXdFqE/nftm/VCMaClZmu/vVEsmsy0S9pR2yaZVcsM6dhPqgpu QwdQ== X-Gm-Message-State: AOJu0Yxzbq882Xys2gKmirgKMEc0N/pRDn0Fs+AwFO0aokHSrGWnnkhY gJ5bVx8d5u2tPfOudcHxsh9EzHJX5n4A0iBhaK2PDQ== X-Google-Smtp-Source: AGHT+IECO7V4AYcbg7yNybQqcBKejUQe6X0wJ0B9pkzgEqrXskYntB79d2VRHm4J8BZo27Bj904D9w0enPPVZtjnbSg= X-Received: by 2002:a25:3626:0:b0:d9c:7d48:3020 with SMTP id d38-20020a253626000000b00d9c7d483020mr11734725yba.20.1701102540286; Mon, 27 Nov 2023 08:29:00 -0800 (PST) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20231126025612.12522-1-wahrenst@gmx.net> <53e1f6e6-a28e-45af-991e-75b283a21b34@broadcom.com> <46320840-09ab-4c86-90c9-bee7b75f248a@gmx.net> <624b79b1-f2dc-4f2e-a225-d1623d905b19@gmx.net> In-Reply-To: <624b79b1-f2dc-4f2e-a225-d1623d905b19@gmx.net> From: Phil Elwell Date: Mon, 27 Nov 2023 16:28:48 +0000 Message-ID: Subject: Re: [PATCH 0/3] ARM: dts: bcm2711-rpi-cm4-io: Enable xHCI host To: Stefan Wahren Cc: Justin Chen , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Mathias Nyman , bcm-kernel-feedback-list@broadcom.com, Cyril Brulebois , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="UTF-8" On Mon, 27 Nov 2023 at 12:39, Stefan Wahren wrote: > > Hi Phil, > > >>>> Hi Justin, > >>>> > >>>> [add Phil] > >>>> > >>>> Am 27.11.23 um 07:02 schrieb Justin Chen: > >>>>> On 11/25/23 6:56 PM, Stefan Wahren wrote: > >>>>>> In contrast to the Raspberry Pi 4, the Compute Module 4 or the IO board > >>>>>> does not have a VL805 USB 3.0 host controller, which is connected via > >>>>>> PCIe. Instead, the BCM2711 on the Compute Module provides the built-in > >>>>>> xHCI. > >>>>>> > >>>>> Does this work? I maintain this built-in xHCI controller internally. I > >>>>> wasn't aware the Compute Module uses this block. > >>>> i successful tested this with a CM4 (arm 32 bit, > >>>> multi_v7_lpae_defconfig) with eMMC. Before this series the USB devices > >>>> (mouse, keyboard) connected to the host interface didn't work. After > >>>> comparing vendor DTS with mainline i noticed the missing xHCI block [1]. > >>>> Unfortunately i wasn't able to get further information from the public > >>>> datasheets. I don't know if the VideoCore does some magic tricks on the > >>>> xHCI or i missed some downstream xHCI changes. > >>>> > >>>>> This block is held in reset and needs a bit toggled to get things > >>>>> going. Florian, just to confirm, this is our "brcm,xhci-brcm-v2" block > >>>>> correct? > >>>>> > >>>>> Justin > >>>> [1] - > >>>> https://github.com/raspberrypi/linux/blob/rpi-6.1.y/arch/arm/boot/dts/bcm2711-rpi-ds.dtsi#L119 > >>> What's the question here? Does the XHCI block present in the > >>> raspberrypi/linux dtsi file really exist? Yes it does. > >> since i don't have any documentation about the xHCI block, i assumed the > >> compatible generic-xhci is correct. But Justin seems to suggest that the > >> xHCI block needs some special treatment and we need a specific compatible. > >> > >> Did i missed some xHCI driver changes? > >> Does the VC firmware something to the xHCI especially on CM4? > > The firmware switches the on-board USB pins from DWC-OTG to XHCI if > > otg_mode=1 is set in config.txt, or if booting over USB MSD. > is this pinctrl/pinmux available from ARM via 0x7e200000 or a different > IO address? It's in a different, undocumented block. Phil