From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C08BF1F8BC9 for ; Thu, 13 Mar 2025 23:29:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741908556; cv=none; b=LJAKi4f90gycRYxykZboK1Id9MjuTBwy3Z7ufN0sV7d3GiFfLHxEuzZ7/ZCb5lQXy5loj4aIwOc7dSs7NBD/Z3kJUo4jMXpFtrtQ/aZOxlV+pcLjheLBC8EjM+azi1EEZopCNv9dwe7EEyvtddV3fXvenc10PixFNt83dbgA7kc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741908556; c=relaxed/simple; bh=fLmgjAemiovWofaWjxUzmEbQJocXHzEtlxZq33BB5yw=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=VhUuAkyQJV69KyINboULBBe88iVV8q28NGnDzxix1Q2x8MYqXtVGs8Ke9azGvo2JEoEG7n6ibE/gePJExDzcOZZ1WczmBPE7DpBSEPdUvPGkfCogRa1ZbuYCtQmMMo/CnyGbtQ21opdxtRoQHLQcZObHUyEV+y70HCEeT+Nyogc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=lfsOlFpb; arc=none smtp.client-ip=209.85.208.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="lfsOlFpb" Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-5e5deb6482cso4679561a12.1 for ; Thu, 13 Mar 2025 16:29:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1741908553; x=1742513353; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=fLmgjAemiovWofaWjxUzmEbQJocXHzEtlxZq33BB5yw=; b=lfsOlFpbTPBRbIvsQsXstONyoujQ9WYBfAVAZDm8fj5yVu302FMqndYW63WGKRacz8 Wob56WUv7RiopHEgwubaiTQNz7LGH60lnhU5zQojeTU5bZkxrwnBzY8sV8YkOYKJnujS Vo9NS93Y2QEvc9w+xlXp/LPpEicdxWIwSvVqg0/SUx9TJ8YyuoQewMhnTvUiAIB1OKqH 28U7fr59mMsddTJpya9PXaQNpmyylQwTAxeSjmTcfBXc2Q5ZF21OD3qYH+f9j7tHG8F5 ZmggM9cUgqkSSDuKqVWK5kGTvua7OX2uHf5lm/gvdrHExalE0kAWJzwIL5jcWFYXog6Y 8Kfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741908553; x=1742513353; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fLmgjAemiovWofaWjxUzmEbQJocXHzEtlxZq33BB5yw=; b=h1lHRUOqxJhGr3dh1XYlCjf3YDdBYH9mvAIbyCfzR03u9Y0RXRzCx+kNTi8gr+bLbz qeat3BAIgEVlKty5W63ZJE4cP8DnqmCuicPnNSoFUIUXaagKZAGZFfvNBuUh6lN7Lupa V0hgIzXudyTWJO83otd9lRP1RQvsA7lYHMQSD4ModVWhyrDa5lXBYVibns2Wre402l0e ddjsd/lEM1PPtDQIcrsrgNd9XiiiGTl1NxI/nFb6T2wPH6HeuzatCGGyu8VfrAkMnqsS 5MgMQDdvJ1MGyyS9fYk1rO61jW4ar4JlrgYYv4Jt6IPAUrBQ+NijfD38oRfqHKiIsnnF ddQA== X-Forwarded-Encrypted: i=1; AJvYcCVrBkrqaoD6k1LdaznLWu0w93mg7r9PbPN6uxZaBDoN4BtfQItqruhKh6owvylm6iE5cYtVocIuwf5n@vger.kernel.org X-Gm-Message-State: AOJu0Yz6h5RsXqCxIXNdn2Tb9dnxCWbfrPUb8VGwMnuVm1yvs0aArBAI BT/1Vn/S47vXXptas3PEfbkvN0NBW+cbL+/pDVF+/LjD0xKWhTRr9CmguwOByY3BFpmX5JHZo7g BZrxtkd4TWx9RIFhB0eZrDj67FAVYaKytU9YJ X-Gm-Gg: ASbGncsO+TeVrEFJkbD6ujopJNLZRMvJ7iAxwD5PB8E3UdBJ1bxllB9AkSHsouNg3P9 33hY7qNEFenqt9InPABU8G5fg5BqxpyGFEWToWzXaXAr9IrJPSWUeuvoaWMvR49TpZZQoNzX/VM UGJofX6twtNOMOasxwVnH4xklwtHdiPqPbNz9DukOOrMY6SLJgT3dA91wrcnY9ncDWvw== X-Google-Smtp-Source: AGHT+IEhG6Uj2ZgXODFDQkPgzEVnFaKEkMeOMCOgSAKxsS7ffAl3Oika6RfeExnwIHlB01YBUlfrm+cZgMXZ8GfGSBI= X-Received: by 2002:a17:907:6ea9:b0:ac0:4364:4083 with SMTP id a640c23a62f3a-ac330de660fmr24794366b.0.1741908552998; Thu, 13 Mar 2025 16:29:12 -0700 (PDT) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20250312195951.1579682-4-jthies@google.com> <202503132357.RnlF5A0E-lkp@intel.com> In-Reply-To: <202503132357.RnlF5A0E-lkp@intel.com> From: Jameson Thies Date: Thu, 13 Mar 2025 16:29:01 -0700 X-Gm-Features: AQ5f1JrveV3I6ofpSQly6Maa1d3lFcNQ3Xq7VBo9SbjQm6kMIPtOwMRmVpnj6fw Message-ID: Subject: Re: [PATCH v1 3/3] mfd: cros_ec: Don't add cros_ec_ucsi if it is defined in OF or ACPI To: kernel test robot Cc: tzungbi@kernel.org, ukaszb@chromium.org, bleung@chromium.org, heikki.krogerus@linux.intel.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, groeck@chromium.org, swboyd@chromium.org, akuchynski@chromium.org, llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, devicetree@vger.kernel.org, chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Echoing my response on patch 1/3, thank you for taking a look at this. I=E2=80=99ll follow up with a v2 series to address your comments and resolv= e the build issues. Additional responses below. > > devices will be created automatically. None of parent devices should > > ever check if the child exist to create a child - it makes no sense. > > This is still valid - none of parents should be poking around to see if > there is a child or not. The core handles it, DT handles it etc. > Understood, we can remove this for DT. We need to keep part of this check for ACPI because there are platforms which need this driver and haven't defined proper ACPI nodes in their FW to load cros_ec_ucsi. Thanks, Jameson