From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 45A83A59 for ; Sat, 11 Oct 2025 00:10:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760141429; cv=none; b=gNkCNV3HNjLL7xOpK0ZaH2C8wRz7PxRArYWFWqsnTgz5p9aISb9IlBK9zjUo+Ryy0Al9ssfxFaBiE7ndLitJRLoxDHq6p5b1HhFNFpd09lJVbQi4B0fzizeMYct4hQgaAuX+BwV3x72CIsFFR9LIawgrfYzaKM71ZLJagWV+DjE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760141429; c=relaxed/simple; bh=vhsuxk96WAH/RhC3vemDEb946RpngHOAqABSwAfzGbw=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=RTjgQ37BDCYA2V6armN59YNVKACZgJhUoVHb9M9M0Lyp0Rxm4VnuJ7POA7syFDhA/esSwWntTEoyp9Ux46ULLWCcmYbisfbXANcZLpe7XP4NUlNXPqbr6Qxk+HDuV/HubRa0dOvwM10bL0DXHAVEtxX2HrM1rV6LtkbEIEqbBTA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=Rim2KHyJ; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Rim2KHyJ" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-3ee15b5435bso1548234f8f.0 for ; Fri, 10 Oct 2025 17:10:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1760141427; x=1760746227; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=vhsuxk96WAH/RhC3vemDEb946RpngHOAqABSwAfzGbw=; b=Rim2KHyJ98x00469RxPskdsO24wkT5bUkS/IVMDwqFgXGfDWdCQd87enYHrWLdF6PV tACAWst80nC0jp4uSqvSJPTnQOVnEub3hq//b3JHEVipyzPBv0qxCoT/rk6+E5Zuag9O /LiN1x5iZ6xlLPVl/6GkmWqDJbUkUQim0esp57vEej28UBxEt/l6nkjDZ8tYckXPH+GS idmiADkcshQBExGuX/Pv32Sr6lq8CTxih58YbEfhFdADivnZeGcpSOk13wGrD82nGFHU wsBqY94E0e1OyyTnRljsimMRpR6QS8RM3RjnOPfp9h/8WXC7FnuxpP1JlHpwrS5o3bLo 7Ebg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760141427; x=1760746227; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=vhsuxk96WAH/RhC3vemDEb946RpngHOAqABSwAfzGbw=; b=rHbUsJkQAF6o4AF7m3uEe97ToYW6fJ5PVoRPPjomBbpddl4SzIhsrnjsQ8fHNZ1PS+ ElD5SVcBd6G/mmDwuDZlTSJo85ZYXj6LjKLUQmEDizI0Tsglfy3v9/Te+zmj8aweLD/d M72YOST6D4RY0p+6BFPgZZIFOTOq2a7XSbVJqKznpB/GP1GlAzvxdUjIy0z5pAzUi9lR TOEj57sSmQbq5IT4jsNYqegyW7MmYBKKFw4W+A6l0mXBcARC/N+n+7ymHyHLZNawMzvu Wa283O+Hek9C+Yk2tVq+V/UuCwQn84K/maxhWRerPFnwpd1CaMpIWt+uupvM/0GsMYIL 92oQ== X-Forwarded-Encrypted: i=1; AJvYcCVppTAuH3OPHRmULnA8SFnrZokIBHh35+YYNfO/xRp+5U6uKCOiCjMk0Q9DdTTsoRG8/OEQSDaM/5dx@vger.kernel.org X-Gm-Message-State: AOJu0YwDI6HwOalxUm5IbWdhtBvkwz0XwA1g5WZ5thAUTnc5A39v1mAR vIL1y72tWtwg/PN3E7KTt6qXFa1Ss0n9kAlQ7YF/qL3K95JY6thzDJxdZoXfZ/ylIA2ojEaPRYU 5ZY2lZ6Rz6lO+IqjoBgfFFzQ/gOx5H+pQdK5Yk4w9 X-Gm-Gg: ASbGnctIaxEnaObErwdyboqFLNA/oYN84POfptR3WkCNz8ccdy1LlRQNnV5WUmw61xP rABTi4b88DK03C/41CpWAwk0CvAn0Mp/W9sZ9a1zmYlO5kzZRJJbcUTd4o3WdPdtiHKgpeg/EFD FyW5kc/ad5USbEIh5F0AdGoEfrk6scF3+iuWq4qTb+tXNLh3sjLlYQDaR9P0bnuhxkmawrPWocL 5FQZIqf1OtvdjZI318SaPXbmBfqCuVS/3m7Q6WZyIss5cWrDcTwXBo6Lm6faOupv9lf4EkDYCmy yLn0+CB4 X-Google-Smtp-Source: AGHT+IE+ZGXJMaXhPli5PfF8e59JjiGHyX8ap1P7iYMH4TowQfmU4UEUloQ42CoLYo3lvX2UUV72pFmKUq2N6vrDDqY= X-Received: by 2002:a05:6000:290d:b0:405:ed47:b22b with SMTP id ffacd0b85a97d-42666abb50fmr7632735f8f.10.1760141426475; Fri, 10 Oct 2025 17:10:26 -0700 (PDT) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20251009010312.2203812-1-jthies@google.com> <20251009010312.2203812-3-jthies@google.com> In-Reply-To: From: Jameson Thies Date: Fri, 10 Oct 2025 17:10:13 -0700 X-Gm-Features: AS18NWD3EfN8pP57xJObsE8Nw-y-Yhc8QT1UxXovpeEXkcrZFbmuYOLzuOBOTJU Message-ID: Subject: Re: [PATCH v3 2/3] usb: typec: cros_ec_ucsi: Load driver from OF and ACPI definitions To: Dmitry Baryshkov Cc: akuchynski@chromium.org, abhishekpandit@chromium.org, krzk+dt@kernel.org, robh@kernel.org, bleung@chromium.org, heikki.krogerus@linux.intel.com, ukaszb@chromium.org, tzungbi@kernel.org, devicetree@vger.kernel.org, chrome-platform@lists.linux.dev, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Hi Dmitry, on early ChromeOS devices using this driver it gets added as a subdevice of the cros_ec_dev mfd. But, we want to change this to load the device from OF/ACPI nodes. The issue here is that older devices which don't define the OF/ACPI nodes to load cros_ec_ucsi will still need to add the device through cros_ec_dev. So cros_ec_ucsi needs to support multiple methods of being instantiated, and going through cros_ec_dev creates an intermediary device in the path which doesn't exist when the driver is loaded through OF/ACPI. I'll add a comment explaining this in the v4 series.