From: Jameson Thies <jthies@google.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: tzungbi@kernel.org, ukaszb@chromium.org, bleung@chromium.org,
heikki.krogerus@linux.intel.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, groeck@chromium.org,
swboyd@chromium.org, akuchynski@chromium.org,
devicetree@vger.kernel.org, chrome-platform@lists.linux.dev,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH v1 1/3] dt-bindings: Add cros-ec-ucsi to cros-ec-typec device tree documentation
Date: Thu, 13 Mar 2025 16:23:30 -0700 [thread overview]
Message-ID: <CAMFSAReJpppA5eb2mxf8ZCwrR1HcBeGWaNXBoFmKq5swKboMJw@mail.gmail.com> (raw)
In-Reply-To: <13c6d57b-0235-4c8d-95ef-111f87d6c25d@linaro.org>
Hi Krzysztof, thank you for taking a look at this series. Clearly it
needs some more work. I’ll follow up with a v2 addressing your
comments.
> > - cros-ec node like google,cros-ec-spi.
> > + cros-ec node like google,cros-ec-spi. On TCPC systems, ChromeOS should
> > + use cros-ec-typec. On PDC systems, ChromeOS should use cros-ec-ucsi.
>
> What does it mean? How is it related to description?
TCPCs and PDCs are different components which can be used for power
delivery messaging on USB-C ports. On ChromeOS devices, they are
mutually exclusive. This line is just saying which driver should be
chosen based on the USB-C port hardware. But, I see that type of
information isn’t really relevant for the device tree documentation.
Thanks,
Jameson
next prev parent reply other threads:[~2025-03-13 23:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-12 19:59 [PATCH v1 0/3] Load cros_ec_ucsi from OF and ACPI definitions Jameson Thies
2025-03-12 19:59 ` [PATCH v1 1/3] dt-bindings: Add cros-ec-ucsi to cros-ec-typec device tree documentation Jameson Thies
2025-03-13 7:10 ` Krzysztof Kozlowski
2025-03-13 7:13 ` Krzysztof Kozlowski
2025-03-13 23:23 ` Jameson Thies [this message]
2025-03-12 19:59 ` [PATCH v1 2/3] usb: typec: cros_ec_ucsi: Load driver from OF and ACPI definitions Jameson Thies
2025-03-12 19:59 ` [PATCH v1 3/3] mfd: cros_ec: Don't add cros_ec_ucsi if it is defined in OF or ACPI Jameson Thies
2025-03-13 7:11 ` Krzysztof Kozlowski
2025-03-13 7:46 ` Krzysztof Kozlowski
2025-03-13 14:53 ` kernel test robot
2025-03-13 16:07 ` kernel test robot
2025-03-13 23:29 ` Jameson Thies
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMFSAReJpppA5eb2mxf8ZCwrR1HcBeGWaNXBoFmKq5swKboMJw@mail.gmail.com \
--to=jthies@google.com \
--cc=akuchynski@chromium.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=devicetree@vger.kernel.org \
--cc=groeck@chromium.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
--cc=tzungbi@kernel.org \
--cc=ukaszb@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).