From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Drake Subject: Re: [PATCH v3] Add OLPC AP-SP input driver Date: Fri, 28 Jun 2013 13:15:35 -0600 Message-ID: References: <20130628171958.CC031FAAD5@dev.laptop.org> <20130628182000.GA21589@core.coreip.homeip.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: In-Reply-To: <20130628182000.GA21589@core.coreip.homeip.net> Sender: linux-input-owner@vger.kernel.org To: Dmitry Torokhov Cc: linux-input@vger.kernel.org, paul fox , "devicetree-discuss@lists.ozlabs.org" List-Id: devicetree@vger.kernel.org On Fri, Jun 28, 2013 at 12:20 PM, Dmitry Torokhov wrote: >> +static void olpc_apsp_close(struct serio *port) >> +{ >> + struct olpc_apsp *priv = port->port_data; >> + unsigned int tmp; >> + >> + if (--priv->open_count == 0) { > > Both need locking. It looks like you need the song and dance similar to > what i8042 has to do with it's multiplexed ports. Or ps2mult.c... I thought they would both be locked already, due to this comment in serio.c: /* called from serio_driver->connect/disconnect methods under serio_mutex */ Or am I missing something there? Thanks Daniel