devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ghatto <ghatto404@gmail.com>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	 Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>,
	 Conor Dooley <conor+dt@kernel.org>,
	linux-arm-msm@vger.kernel.org,  devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/6] arm64: dts: qcom: r0q: add touchscreen support
Date: Tue, 14 Oct 2025 12:10:26 -0300	[thread overview]
Message-ID: <CAMQHOhfjsi1L+3j3TrcjEjPp3xkn94KOdsrVZvJCyUDFBBSeqg@mail.gmail.com> (raw)
In-Reply-To: <e114504e-4bdd-46b9-b708-8eebc3075163@oss.qualcomm.com>

On Tue, Oct 14, 2025 at 7:01 AM Konrad Dybcio
<konrad.dybcio@oss.qualcomm.com> wrote:
>
> On 10/14/25 6:41 AM, Eric Gonçalves wrote:
> > Enable the ST-Microelectronics FTS2BA61Y touchscreen. This patch
> > depends on "Input: add support for the STM FTS2BA61Y touchscreen".
>
> The second sentence doesn't really make sense to be included in
> the git log
I'll keep it to the cover letter then
>
> > The device has an issue where SPI 8 (the bus which the touchscreen is
> > connected to) is not working properly right now, so
> > spi-gpio is used instead.
>
> Some Samsung devices used to use spi/i2c-gpio intentionally, also
> on downstream. I'm assuming this isn't the case for r0q.
It isn't, the device uses fts2ba61y on the spi8 bus - I hosted the
DT at https://github.com/ghatt-o/ss_experiments/blob/main/r0q.dts if you
want to take a look.
>
> Did you enable gpi_dma1, qupv3_id_1 before spi8, when testing
The driver probes, but it fails to recognize the touchscreen device
and ends up erroring, spi-gpio solves this and I did try enabling those.
It also works on the S22+ with spi-gpio, so I decided to do the same on r0q.
> that? I don't see any obvious errors in the dt that would cause
> problems
>
> Konrad

  reply	other threads:[~2025-10-14 15:10 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-14  4:41 [PATCH v2 0/6] arm64: dts: qcom: r0q: enable more peripherals Eric Gonçalves
2025-10-14  4:41 ` [PATCH v2 1/6] arm64: dts: qcom: r0q: small refactor Eric Gonçalves
2025-10-14  4:41 ` [PATCH v2 2/6] arm64: dts: qcom: r0q: add gpio keys Eric Gonçalves
2025-10-14  9:59   ` Konrad Dybcio
2025-10-14  4:41 ` [PATCH v2 3/6] arm64: dts: qcom: r0q: add touchscreen support Eric Gonçalves
2025-10-14 10:01   ` Konrad Dybcio
2025-10-14 15:10     ` Ghatto [this message]
2025-10-14 15:17       ` Konrad Dybcio
2025-10-14 19:04         ` Ghatto
2025-10-16 10:06           ` Konrad Dybcio
2025-10-16 20:08             ` Ghatto
2025-10-17  8:20               ` Konrad Dybcio
2025-10-17 18:22                 ` Eric Gonçalves
2025-10-20 12:18                   ` Konrad Dybcio
2025-10-27 18:32                     ` Eric Gonçalves
2025-10-29  9:50                       ` Konrad Dybcio
2025-10-31 21:06                         ` Ghatto
2025-11-04 14:53                           ` Konrad Dybcio
2025-10-14  4:41 ` [PATCH v2 4/6] arm64: dts: qcom: r0q: enable max77705 fuelgauge Eric Gonçalves
2025-10-14  4:41 ` [PATCH v2 5/6] arm64: dts: qcom: r0q: enable ufs storage Eric Gonçalves
2025-10-14 10:02   ` Konrad Dybcio
2025-10-14  4:41 ` [PATCH v2 6/6] arm64: dts: qcom: r0q: fix reserved memory regions Eric Gonçalves
2025-10-14 10:02   ` Konrad Dybcio
2025-10-14 15:12     ` Ghatto
2025-10-14  9:58 ` [PATCH v2 0/6] arm64: dts: qcom: r0q: enable more peripherals Konrad Dybcio
2025-10-31 21:12   ` Ghatto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMQHOhfjsi1L+3j3TrcjEjPp3xkn94KOdsrVZvJCyUDFBBSeqg@mail.gmail.com \
    --to=ghatto404@gmail.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).