From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0D7BC433F5 for ; Wed, 2 Feb 2022 09:17:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245396AbiBBJRK (ORCPT ); Wed, 2 Feb 2022 04:17:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55190 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245392AbiBBJRH (ORCPT ); Wed, 2 Feb 2022 04:17:07 -0500 Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 677C2C061714 for ; Wed, 2 Feb 2022 01:17:07 -0800 (PST) Received: by mail-ej1-x635.google.com with SMTP id m4so63473906ejb.9 for ; Wed, 02 Feb 2022 01:17:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=x9rntTeDhb6XRDh9/nW9Vd6mnOlOZBc9Iqn9gcca+t4=; b=BHT96a9j020XxUsQWDK20Qo2NUtO20lg55wm++jPoJnYThjUUezbh67CjJK7F0rhHM WMR0SlUFQ67HKnd5UAq3t8wQw0/IcfiDR64E3Bl3ek5iU+rwGtlsQZv4EhHS3HlLll70 vz81NfQyhvIr/DEWlvNCdVHwVdrYwjwE9rJGuyve+JUZRxMWWVM4Ob6EneixpLbaAEL3 mL8ezHkwZky0WbKNDvZRzGI3ZK6UaCQ70KIPB4ePlH3jMJWTS1GZycbEkrbm1j6fw1Um 8sXv5bQxeCXb57VdMFBZNPF2Oeyyi4RN6dtQaE8SAPEe1FFoplZ5LDWHWcIAME4ULSu0 Kj/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=x9rntTeDhb6XRDh9/nW9Vd6mnOlOZBc9Iqn9gcca+t4=; b=oCr5NIY7HmbCvXDcZQ5Xz8hMHscISEEUUwzjoynlxR9JkCUgI8r83J1pFC0/yitd+J CAkrE0pC0DZdXe8eCnlsKYibbb/x39/8y8Koeai4jKaFQD848pnAFM5YZIneHWouIWTh yVYSlUBv02zdweZcHer1NdtO93O0oGjN/m33HTrWEC3grghmmGPUC7aGc05+u5u9CXmT rzVPCF5kcp02j7plSaUyai6HxTap00kWI9amijdKApJL+HAvKviPFtZZUPLr7oKgCJux G+2i36POK3OzbSHsBBFNCB7j8tFqQu56GDrkueQtpsLykQl+4BY+tW16ncE/gfTHLQB/ YW4w== X-Gm-Message-State: AOAM532AQlwM6OvSFOc3ZbjmFDCuVmQdmK8r0/H5A9WIPX7OynS/3+VL E7ZoNGfnjbnH7hiD4ExE0KtvVZikaDvn4KPnHl7TNA== X-Google-Smtp-Source: ABdhPJxO+YT7KVoH0Asl2I194MEaiGQV+55OzPqr2jrXyPvrkGNsigRcmzQHLC5k4+p9ZlceBbVedREV04aU+lGUj4w= X-Received: by 2002:a17:907:6e1f:: with SMTP id sd31mr24802407ejc.286.1643793425982; Wed, 02 Feb 2022 01:17:05 -0800 (PST) MIME-Version: 1.0 References: <20220130145116.88406-1-nbd@nbd.name> <20220130145116.88406-12-nbd@nbd.name> In-Reply-To: <20220130145116.88406-12-nbd@nbd.name> From: Bartosz Golaszewski Date: Wed, 2 Feb 2022 10:16:55 +0100 Message-ID: Subject: Re: [PATCH v9 11/13] dt-bindings: arm: airoha: Add binding for Airoha GPIO controller To: Felix Fietkau Cc: Linus Walleij , Rob Herring , John Crispin , soc@kernel.org, "moderated list:ARM/Mediatek SoC..." , Linux ARM , Rob Herring , "open list:GPIO SUBSYSTEM" , devicetree , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Sun, Jan 30, 2022 at 3:54 PM Felix Fietkau wrote: > > From: John Crispin > > Airoha's GPIO controller on their ARM EN7523 SoCs consists of two banks of 32 > GPIOs > > Reviewed-by: Linus Walleij > Reviewed-by: Rob Herring > Signed-off-by: John Crispin > Signed-off-by: Felix Fietkau > --- > .../bindings/gpio/airoha,en7523-gpio.yaml | 67 +++++++++++++++++++ > 1 file changed, 67 insertions(+) > create mode 100644 Documentation/devicetree/bindings/gpio/airoha,en7523-gpio.yaml > > diff --git a/Documentation/devicetree/bindings/gpio/airoha,en7523-gpio.yaml b/Documentation/devicetree/bindings/gpio/airoha,en7523-gpio.yaml > new file mode 100644 > index 000000000000..66c00ec85731 > --- /dev/null > +++ b/Documentation/devicetree/bindings/gpio/airoha,en7523-gpio.yaml > @@ -0,0 +1,67 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/gpio/airoha,en7523-gpio.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Airoha EN7523 GPIO controller > + > +maintainers: > + - John Crispin > + > +description: | > + Airoha's GPIO controller on their ARM EN7523 SoCs consists of two banks of 32 > + GPIOs. > + > +properties: > + $nodename: > + pattern: "^gpio@[0-9a-f]+$" > + > + compatible: > + items: > + - const: airoha,en7523-gpio > + > + reg: > + description: | > + The first tuple points to the input register. > + The second and third tuple point to the direction registers > + The fourth tuple points to the output register > + maxItems: 4 > + > + "#gpio-cells": > + const: 2 > + > + gpio-controller: true > + > +required: > + - compatible > + - reg > + - "#gpio-cells" > + - gpio-controller > + > +additionalProperties: false > + > +examples: > + - | > + gpio0: gpio@1fbf0200 { > + compatible = "airoha,en7523-gpio"; > + reg = <0x1fbf0204 0x4>, > + <0x1fbf0200 0x4>, > + <0x1fbf0220 0x4>, > + <0x1fbf0214 0x4>; > + gpio-controller; > + #gpio-cells = <2>; > + }; > + > + gpio1: gpio@1fbf0270 { > + compatible = "airoha,en7523-gpio"; > + reg = <0x1fbf0270 0x4>, > + <0x1fbf0260 0x4>, > + <0x1fbf0264 0x4>, > + <0x1fbf0278 0x4>; > + gpio-controller; > + #gpio-cells = <2>; > + }; > + > + I removed this unnecessary newline when applying. > +... > -- > 2.32.0 (Apple Git-132) > Queued for next, thanks! Bart