* Re: [PATCH] arm64: dts: qcom: sa8775p: correct PMIC GPIO label in gpio-ranges
2023-08-18 13:55 [PATCH] arm64: dts: qcom: sa8775p: correct PMIC GPIO label in gpio-ranges Krzysztof Kozlowski
@ 2023-08-18 13:57 ` Konrad Dybcio
2023-08-18 14:27 ` Bartosz Golaszewski
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Konrad Dybcio @ 2023-08-18 13:57 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Bartosz Golaszewski,
linux-arm-msm, devicetree, linux-kernel
Cc: Brian Masney
On 18.08.2023 15:55, Krzysztof Kozlowski wrote:
> There are several PMICs with GPIO nodes and one of the nodes referenced
> other's in gpio-ranges which could result in deferred-probes like:
>
> qcom-spmi-gpio c440000.spmi:pmic@2:gpio@8800: can't add gpio chip
>
> Reported-by: Brian Masney <bmasney@redhat.com>
> Closes: https://lore.kernel.org/all/ZN5KIlI+RDu92jsi@brian-x1/
> Fixes: e5a893a7cec5 ("arm64: dts: qcom: sa8775p: add PMIC GPIO controller nodes")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] arm64: dts: qcom: sa8775p: correct PMIC GPIO label in gpio-ranges
2023-08-18 13:55 [PATCH] arm64: dts: qcom: sa8775p: correct PMIC GPIO label in gpio-ranges Krzysztof Kozlowski
2023-08-18 13:57 ` Konrad Dybcio
@ 2023-08-18 14:27 ` Bartosz Golaszewski
2023-09-13 12:38 ` Brian Masney
2023-09-14 19:36 ` Bjorn Andersson
3 siblings, 0 replies; 5+ messages in thread
From: Bartosz Golaszewski @ 2023-08-18 14:27 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Bartosz Golaszewski,
linux-arm-msm, devicetree, linux-kernel, Brian Masney
On Fri, Aug 18, 2023 at 3:56 PM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> There are several PMICs with GPIO nodes and one of the nodes referenced
> other's in gpio-ranges which could result in deferred-probes like:
>
> qcom-spmi-gpio c440000.spmi:pmic@2:gpio@8800: can't add gpio chip
>
> Reported-by: Brian Masney <bmasney@redhat.com>
> Closes: https://lore.kernel.org/all/ZN5KIlI+RDu92jsi@brian-x1/
> Fixes: e5a893a7cec5 ("arm64: dts: qcom: sa8775p: add PMIC GPIO controller nodes")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi b/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi
> index 3c3b6287cd27..eaa43f022a65 100644
> --- a/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi
> @@ -173,7 +173,7 @@ pmm8654au_1_gpios: gpio@8800 {
> compatible = "qcom,pmm8654au-gpio", "qcom,spmi-gpio";
> reg = <0x8800>;
> gpio-controller;
> - gpio-ranges = <&pmm8654au_2_gpios 0 0 12>;
> + gpio-ranges = <&pmm8654au_1_gpios 0 0 12>;
> #gpio-cells = <2>;
> interrupt-controller;
> #interrupt-cells = <2>;
> --
> 2.34.1
>
My bad, must have been a bad copy-and-paste.
Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Tested-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] arm64: dts: qcom: sa8775p: correct PMIC GPIO label in gpio-ranges
2023-08-18 13:55 [PATCH] arm64: dts: qcom: sa8775p: correct PMIC GPIO label in gpio-ranges Krzysztof Kozlowski
2023-08-18 13:57 ` Konrad Dybcio
2023-08-18 14:27 ` Bartosz Golaszewski
@ 2023-09-13 12:38 ` Brian Masney
2023-09-14 19:36 ` Bjorn Andersson
3 siblings, 0 replies; 5+ messages in thread
From: Brian Masney @ 2023-09-13 12:38 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Bartosz Golaszewski,
linux-arm-msm, devicetree, linux-kernel
On Fri, Aug 18, 2023 at 03:55:38PM +0200, Krzysztof Kozlowski wrote:
> There are several PMICs with GPIO nodes and one of the nodes referenced
> other's in gpio-ranges which could result in deferred-probes like:
>
> qcom-spmi-gpio c440000.spmi:pmic@2:gpio@8800: can't add gpio chip
>
> Reported-by: Brian Masney <bmasney@redhat.com>
> Closes: https://lore.kernel.org/all/ZN5KIlI+RDu92jsi@brian-x1/
> Fixes: e5a893a7cec5 ("arm64: dts: qcom: sa8775p: add PMIC GPIO controller nodes")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Brian Masney <bmasney@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] arm64: dts: qcom: sa8775p: correct PMIC GPIO label in gpio-ranges
2023-08-18 13:55 [PATCH] arm64: dts: qcom: sa8775p: correct PMIC GPIO label in gpio-ranges Krzysztof Kozlowski
` (2 preceding siblings ...)
2023-09-13 12:38 ` Brian Masney
@ 2023-09-14 19:36 ` Bjorn Andersson
3 siblings, 0 replies; 5+ messages in thread
From: Bjorn Andersson @ 2023-09-14 19:36 UTC (permalink / raw)
To: Andy Gross, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Bartosz Golaszewski, linux-arm-msm, devicetree,
linux-kernel, Krzysztof Kozlowski
Cc: Brian Masney
On Fri, 18 Aug 2023 15:55:38 +0200, Krzysztof Kozlowski wrote:
> There are several PMICs with GPIO nodes and one of the nodes referenced
> other's in gpio-ranges which could result in deferred-probes like:
>
> qcom-spmi-gpio c440000.spmi:pmic@2:gpio@8800: can't add gpio chip
>
>
Applied, thanks!
[1/1] arm64: dts: qcom: sa8775p: correct PMIC GPIO label in gpio-ranges
commit: f822899c28572a854f2c746da5ed707d752458ab
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 5+ messages in thread