From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D06CC43334 for ; Wed, 29 Jun 2022 18:50:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231251AbiF2Sun (ORCPT ); Wed, 29 Jun 2022 14:50:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37114 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231396AbiF2Sum (ORCPT ); Wed, 29 Jun 2022 14:50:42 -0400 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8F2F51A827 for ; Wed, 29 Jun 2022 11:50:41 -0700 (PDT) Received: by mail-ej1-x633.google.com with SMTP id g26so34386879ejb.5 for ; Wed, 29 Jun 2022 11:50:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=VGp0r8sM5mZknQfVI2yfDxCg19sys5aNVE3+EWpAW9s=; b=Tl/EXqGcU+gTZSJmaC6LTPd+O7MER1FPtuy99jHEqhAJI/gQ51pcJXiwpACzJZ7SES PVtX7w8SgecUl6H809W36x0KyBpId8SOGe53QQQmllzidRX780Cdeb22xUz+c+JqVPAX RvSKHQahI3BCy0KxOdr2vuBHV3vOztuK15zP8XJ5LsSMJArgDvy7pgMr4DDaLjeckJcU hNGq233FtQPYdjVFDJ+yMrJd4FPogy3Ovb/9HgQkQSoUe8aLTGjrspqcTADrDNsFm1DH xIeJJh9tVwExx6FB5MlJIAA21YDuuIEbD1gTBEEXl46NYq5uHl6p05LnaTjge0MUpoqA PViQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VGp0r8sM5mZknQfVI2yfDxCg19sys5aNVE3+EWpAW9s=; b=uC6HlWdgJY9Z2tQDv9J3U1Qd+qozdnSf9Cr9KFMICbHaXwiHADZGuJMDLLEAEzzUYY vPzfVDuHfzgnnD1Tx1bw/d79bIn5uaOpXU6xL481FIx7NAKovYdICc3bVg8rEQ7J4RpS b+YaVFC8qiDBw9fNUBbW7bjnRMpIYvaxZYMo0V1mOpbbcQQsBOma0trU91zXRs+h809M MO9b0pXg1/eFR5Bkzjw+u70GLV4q/nXbqHGJyC4hH7J7AGxNPGnUXKG/mP83EUV40qxK kOtAlj8KIPumq/8jgIgPxxCreueOTzXZ2NeZwndY6BlB/IKGFRDz8CNqSukfb9CK+KoN Ro+g== X-Gm-Message-State: AJIora83i9SUlxWsE0jd5Klp7xn45nvplyXhvYjgRD72Rvm5fRutpHUG rEE3DwTVNZoJrvyoraI6ruWfyMZ9XRaQEh4Zfk7wkw== X-Google-Smtp-Source: AGRyM1uAEQa5n0jWp6G0//caHTKUPFeS+Y57BmjJG23TZwaIXDhf11hwGuBY2nZ8ndjyCfvJbyaKABb3F1Guh9y72+0= X-Received: by 2002:a17:907:60cc:b0:722:e564:eb11 with SMTP id hv12-20020a17090760cc00b00722e564eb11mr4643048ejc.736.1656528640056; Wed, 29 Jun 2022 11:50:40 -0700 (PDT) MIME-Version: 1.0 References: <20220629115010.10538-1-andriy.shevchenko@linux.intel.com> In-Reply-To: <20220629115010.10538-1-andriy.shevchenko@linux.intel.com> From: Bartosz Golaszewski Date: Wed, 29 Jun 2022 20:50:28 +0200 Message-ID: Subject: Re: [PATCH v3 1/2] of: unittest: Switch to use fwnode instead of of_node To: Andy Shevchenko Cc: Rob Herring , Frank Rowand , devicetree , Linux Kernel Mailing List , "open list:GPIO SUBSYSTEM" , Rob Herring , Frank Rowand , Linus Walleij Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, Jun 29, 2022 at 1:50 PM Andy Shevchenko wrote: > > GPIO library now accepts fwnode as a firmware node, so > switch the module to use it. > > Signed-off-by: Andy Shevchenko > --- > v3: no changes > drivers/of/unittest.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c > index 7f6bba18c515..5a842dfc27e8 100644 > --- a/drivers/of/unittest.c > +++ b/drivers/of/unittest.c > @@ -1602,7 +1602,7 @@ static int unittest_gpio_probe(struct platform_device *pdev) > > platform_set_drvdata(pdev, devptr); > > - devptr->chip.of_node = pdev->dev.of_node; > + devptr->chip.fwnode = dev_fwnode(&pdev->dev); > devptr->chip.label = "of-unittest-gpio"; > devptr->chip.base = -1; /* dynamic allocation */ > devptr->chip.ngpio = 5; > @@ -1611,7 +1611,7 @@ static int unittest_gpio_probe(struct platform_device *pdev) > ret = gpiochip_add_data(&devptr->chip, NULL); > > unittest(!ret, > - "gpiochip_add_data() for node @%pOF failed, ret = %d\n", devptr->chip.of_node, ret); > + "gpiochip_add_data() for node @%pfw failed, ret = %d\n", devptr->chip.fwnode, ret); > > if (!ret) > unittest_gpio_probe_pass_count++; > -- > 2.35.1 > Reviewed-by: Bartosz Golaszewski