From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vk1-f177.google.com (mail-vk1-f177.google.com [209.85.221.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92FBE2BB1B for ; Thu, 22 Feb 2024 11:00:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708599628; cv=none; b=CuwCO2RW9hWKIRWSWP9MS9lSGIOHPi7ub5RrOb46kKCpw+VmTMsISKlhPR/OiLyKnAQ/w1GZvdNGilYxFEIAyoQfuJ938T9R/jJaLsKxX/6F/AksVGsyrZ3XCWkJ8cPC3yE7vGx1xGsXvjt9HQoBNmzIhdwRZAw8IQDv2X1LhO0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708599628; c=relaxed/simple; bh=4SUhFECzfgHvN70ojLHKQ96rAaBsv2JrpKaeoW6p6NU=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=KZXEXGIRz9igcl+KOHjjsL1NS6CrxtdcUtKtJ6U6IcH7z2eJvqn9va4hmkNHsiG+1oitKkblXy6qOUgsPCItio5P2Xb2uBx1yoWYzm2Vvd2FioWYFri7pBAyBZ6UOCVfcjHndVYug3phVHCuPVM/NF1uRRnUyLQZvwXdGELPguI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=VkMj3gfd; arc=none smtp.client-ip=209.85.221.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="VkMj3gfd" Received: by mail-vk1-f177.google.com with SMTP id 71dfb90a1353d-4d147f87bb6so132862e0c.1 for ; Thu, 22 Feb 2024 03:00:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1708599625; x=1709204425; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=/H/VIpoB4an+Mp36arHK/D3Ob8nW5Qqkhlyoj2/3jaw=; b=VkMj3gfdcFnz42zo5KLDCMaRFv4b0U0/AkjZW3epTqbYbaaD/h/iHU2FIa7Mnr67md RBQ/zLS3xiCJ7ptiCQHAbPPXT3IafWKRdsIVBZfOFupfDQikMwPe+HIUEEXz5hUCweSC 7iangEDzwS2C0DVrsWpOxQ1BXQquior9uqGpoJhTf3S8FWWEAW5lh1VLiQ7H6pfpAnta zQF50G8AMFwP+rxRZrPI8PlG3ULBuAz6yR0FfurGccUNuZrxkzFdhihk0QxIZskLoEfQ fpB8b5AMkjka5xduQ7XAaeUdfCGEyQNStzPei9FXlsjUhdP0N7qvAAPEsQ6hTOFCtr/v 3fqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708599625; x=1709204425; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/H/VIpoB4an+Mp36arHK/D3Ob8nW5Qqkhlyoj2/3jaw=; b=B2RNt0tU60c4HtT1Gi0/7mYdi6OpCB0YxzBfIqIjCY3qlZB6YG/Y4PLpMwq01lSQKK z0NuWWLfUaqM0twE4S3dMxzTo3CcaW2yorJBFyMAN7aW70ME1hjQTmV20RSl6zjHhja8 93uqAA1J85zsJLY2lOUhlgZmP/xo+ifLGpCIhi21+dfuzfjGlNIF32zIxnjEl45+ahMU T5Y/2JD3Ky3LeR9ato77iDiTpuhY2W9GNkQuGGTgyMKla8dxgKhJ1/m1NhqZ4z7Psx29 tqFu896r/lKn/Z37kki30exPzh4iFcKekxkbbcOwq8sJS/1CLC6REXO7jQFLipIUJLco C71A== X-Forwarded-Encrypted: i=1; AJvYcCVHVTVConS0GgrYQwfyeF68pDszyGFFxK8ixYGJoAJI27gy5LffWyjiMibqNOorOMQ3kd+A7AGcD857fbJ+dMJl/zwFzoBTJdOO5g== X-Gm-Message-State: AOJu0YyqX2sBJz80ToKTLOAF0VRTQZI4dYZKDqa+HF8KhyXAFuxDotvX OKtlToafemS+63lVO1/YBPbhf/NM9rPBYvyvl8MPEz2N3C1EcQTRf8oPyLSRRrsD8Pfz/095C7B im87FZzHreD08X6gXca73Vt5RjetJhPDhsNNPHw== X-Google-Smtp-Source: AGHT+IGc4k4afM7yOHcqPtsyx85w0wC4eDvcktSKZo2fOpRx3WfdsV144zf5agpJ1l8kNtCEpqQOOt7K2tgZtw6QOw8= X-Received: by 2002:a1f:4a45:0:b0:4c7:7760:8f12 with SMTP id x66-20020a1f4a45000000b004c777608f12mr12070252vka.2.1708599625549; Thu, 22 Feb 2024 03:00:25 -0800 (PST) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240216203215.40870-1-brgl@bgdev.pl> <4d2a6f16-bb48-4d4e-b8fd-7e4b14563ffa@linaro.org> In-Reply-To: From: Bartosz Golaszewski Date: Thu, 22 Feb 2024 12:00:14 +0100 Message-ID: Subject: Re: [PATCH v5 00/18] power: sequencing: implement the subsystem and add first users To: Dmitry Baryshkov Cc: neil.armstrong@linaro.org, Marcel Holtmann , Luiz Augusto von Dentz , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Kalle Valo , Bjorn Andersson , Konrad Dybcio , Liam Girdwood , Mark Brown , Catalin Marinas , Will Deacon , Bjorn Helgaas , Saravana Kannan , Geert Uytterhoeven , Arnd Bergmann , Marek Szyprowski , Alex Elder , Srini Kandagatla , Greg Kroah-Hartman , Abel Vesa , Manivannan Sadhasivam , Lukas Wunner , linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, linux-pm@vger.kernel.org, Bartosz Golaszewski Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Feb 19, 2024 at 11:21=E2=80=AFPM Dmitry Baryshkov wrote: > > On Mon, 19 Feb 2024 at 19:18, wrote: > > > > On 19/02/2024 13:33, Dmitry Baryshkov wrote: > > > On Mon, 19 Feb 2024 at 14:23, Bartosz Golaszewski wro= te: > > >> > > >> On Mon, Feb 19, 2024 at 11:26=E2=80=AFAM Dmitry Baryshkov > > >> wrote: > > >>> > > >> > > >> [snip] > > >> > > >>>>>>>> > > >>>>>>>> For WCN7850 we hide the existence of the PMU as modeling it is= simply not > > >>>>>>>> necessary. The BT and WLAN devices on the device-tree are repr= esented as > > >>>>>>>> consuming the inputs (relevant to the functionality of each) o= f the PMU > > >>>>>>>> directly. > > >>>>>>> > > >>>>>>> We are describing the hardware. From the hardware point of view= , there > > >>>>>>> is a PMU. I think at some point we would really like to describ= e all > > >>>>>>> Qualcomm/Atheros WiFI+BT units using this PMU approach, includi= ng the > > >>>>>>> older ath10k units present on RB3 (WCN3990) and db820c (QCA6174= ). > > >>>>>> > > >>>>>> While I agree with older WiFi+BT units, I don't think it's neede= d for > > >>>>>> WCN7850 since BT+WiFi are now designed to be fully independent a= nd PMU is > > >>>>>> transparent. > > >>>>> > > >>>>> I don't see any significant difference between WCN6750/WCN6855 an= d > > >>>>> WCN7850 from the PMU / power up point of view. Could you please p= oint > > >>>>> me to the difference? > > >>>>> > > >>>> > > >>>> The WCN7850 datasheet clearly states there's not contraint on the = WLAN_EN > > >>>> and BT_EN ordering and the only requirement is to have all input r= egulators > > >>>> up before pulling up WLAN_EN and/or BT_EN. > > >>>> > > >>>> This makes the PMU transparent and BT and WLAN can be described as= independent. > > >>> > > >>> From the hardware perspective, there is a PMU. It has several LDOs= . So > > >>> the device tree should have the same style as the previous > > >>> generations. > > >>> > > >> > > >> My thinking was this: yes, there is a PMU but describing it has no > > >> benefit (unlike QCA6x90). If we do describe, then we'll end up havin= g > > >> to use pwrseq here despite it not being needed because now we won't = be > > >> able to just get regulators from WLAN/BT drivers directly. > > >> > > >> So I also vote for keeping it this way. Let's go into the package > > >> detail only if it's required. > > > > > > The WiFi / BT parts are not powered up by the board regulators. They > > > are powered up by the PSU. So we are not describing it in the accurat= e > > > way. > > > > I disagree, the WCN7850 can also be used as a discrete PCIe M.2 card, a= nd in > > this situation the PCIe part is powered with the M.2 slot and the BT si= de > > is powered separately as we currently do it now. > > QCA6390 can also be used as a discrete M.2 card. > > > So yes there's a PMU, but it's not an always visible hardware part, fro= m the > > SoC PoV, only the separate PCIe and BT subsystems are visible/controlla= ble/powerable. > > From the hardware point: > - There is a PMU > - The PMU is connected to the board supplies > - Both WiFi and BT parts are connected to the PMU > - The BT_EN / WLAN_EN pins are not connected to the PMU > > So, not representing the PMU in the device tree is a simplification. > What about the existing WLAN and BT users of similar packages? We would have to deprecate a lot of existing bindings. I don't think it's worth it. The WCN7850 is already described in bindings as consuming what is PMUs inputs and not its outputs. Bart > > > > Neil > > > > > > > > Moreover, I think we definitely want to move BT driver to use only th= e > > > pwrseq power up method. Doing it in the other way results in the code > > > duplication and possible issues because of the regulator / pwrseq > > > taking different code paths. > > -- > With best wishes > Dmitry