From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Sekhar Nori <nsekhar@ti.com>
Cc: Kevin Hilman <khilman@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
David Lechner <david@lechnology.com>,
Adam Ford <aford173@gmail.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
devicetree <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: Re: [PATCH v3 1/3] ARM: dts: da850: add cpu node and operating points to DT
Date: Fri, 12 Apr 2019 17:31:12 +0200 [thread overview]
Message-ID: <CAMRc=Me8vppb9vEmKOUcU28YKVR9jJ64sBSn-KwNyNnZA=VB9Q@mail.gmail.com> (raw)
In-Reply-To: <3f6c906b-53b0-8284-bf4d-9b404f341e7b@ti.com>
pt., 12 kwi 2019 o 15:53 Sekhar Nori <nsekhar@ti.com> napisał(a):
>
> On 12/04/19 5:41 PM, Bartosz Golaszewski wrote:
> > pt., 12 kwi 2019 o 13:26 Sekhar Nori <nsekhar@ti.com> napisał(a):
> >>
> >> Hi Bartosz,
> >>
> >> On 08/04/19 1:29 PM, Bartosz Golaszewski wrote:
> >>> From: David Lechner <david@lechnology.com>
> >>>
> >>> This adds a cpu node and operating points to the common da850.dtsi file.
> >>>
> >>> Additionally, a regulator is added to the LEGO EV3 board along with
> >>> some board-specific CPU configuration.
> >>>
> >>> Regulators need to be hooked up on other boards to get them working.
> >>>
> >>> Signed-off-by: David Lechner <david@lechnology.com>
> >>> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> >>
> >> I remember you mentioning about some problems using OCHI and cpufreq
> >> together. Are those resolved now? CPU PLL on DA850 can affect other
> >> peripheral clock frequencies too. So enabling it should really be a
> >> per-board decision.
> >>
> >
> > The problems are still there. I've never been able to find the
> > culprit, but it also occurs on TI BSP in the same way (a couple
> > cpufreq transitions will make the controller unresponsive).
>
> Is that on LCDK as well? As I recall cpufreq was never enabled on LCDK
> in TI BSP.
>
Yes, I just verified that the bug occurs on LCDK with patches from this series.
> If the OHCI problem is present on LCDK, then there is a user visible
> regression on mainline after this patch. Lets enable cpufreq in LCDK
> only if all working peripherals keep working afterwards.
>
The OHCI driver doesn't register any cpufreq transition notifier
callbacks. I can't really find anything in the datasheet, but I'm
wondering if we shouldn't do something similar to what the driver for
davinci i2c controller does. I'll try a couple things tomorrow.
Bart
next prev parent reply other threads:[~2019-04-12 15:31 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-08 7:59 [PATCH v3 0/3] ARM: da850: enable cpufreq in DT mode Bartosz Golaszewski
2019-04-08 7:59 ` [PATCH v3 1/3] ARM: dts: da850: add cpu node and operating points to DT Bartosz Golaszewski
2019-04-08 13:47 ` David Lechner
2019-04-08 13:51 ` Bartosz Golaszewski
2019-04-08 13:55 ` David Lechner
2019-04-12 11:26 ` Sekhar Nori
2019-04-12 12:11 ` Bartosz Golaszewski
2019-04-12 13:53 ` Sekhar Nori
2019-04-12 15:31 ` Bartosz Golaszewski [this message]
2019-04-15 10:21 ` Sekhar Nori
2019-04-15 11:54 ` Bartosz Golaszewski
2019-04-15 13:02 ` Adam Ford
2019-04-16 8:37 ` Bartosz Golaszewski
2019-04-16 11:48 ` Adam Ford
2019-04-17 8:15 ` Sekhar Nori
2019-04-16 14:38 ` David Lechner
2019-04-17 8:24 ` Sekhar Nori
2019-04-08 7:59 ` [PATCH v3 2/3] ARM: dts: da850-evm: enable cpufreq Bartosz Golaszewski
2019-04-12 13:06 ` Sekhar Nori
2019-04-12 13:09 ` Bartosz Golaszewski
2019-04-12 13:59 ` Adam Ford
2019-04-12 14:23 ` Bartosz Golaszewski
2019-04-08 7:59 ` [PATCH v3 3/3] ARM: davinci_all_defconfig: Enable CPUFREQ_DT Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMRc=Me8vppb9vEmKOUcU28YKVR9jJ64sBSn-KwNyNnZA=VB9Q@mail.gmail.com' \
--to=brgl@bgdev.pl \
--cc=aford173@gmail.com \
--cc=bgolaszewski@baylibre.com \
--cc=david@lechnology.com \
--cc=devicetree@vger.kernel.org \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nsekhar@ti.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).