[PATCH] dt-bindings: eeprom: at24: Fix ST M24C64-D compatible schema

[PATCH] dt-bindings: eeprom: at24: Fix ST M24C64-D compatible schema

[Rob Herring]

The schema for the ST M24C64-D compatible string doesn't work.
Validation fails as the 'd-wl' suffix is not added to the preceeding
schema which defines the entries and vendors. The actual users are
incorrect as well because the vendor is listed as Atmel whereas the
part is made by ST.

As this part doesn't appear to have multiple vendors, move it to its own
entry.

Fixes: 0997ff1fc143 ("dt-bindings: at24: add ST M24C64-D Additional Write lockable page")
Fixes: c761068f484c ("dt-bindings: at24: add ST M24C32-D Additional Write lockable page")
Signed-off-by: Rob Herring <robh@kernel.org>
---
 Documentation/devicetree/bindings/eeprom/at24.yaml | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/eeprom/at24.yaml b/Documentation/devicetree/bindings/eeprom/at24.yaml
index 1812ef31d5f1..3c36cd0510de 100644
--- a/Documentation/devicetree/bindings/eeprom/at24.yaml
+++ b/Documentation/devicetree/bindings/eeprom/at24.yaml
@@ -68,14 +68,10 @@ properties:
                   pattern: cs16$
               - items:
                   pattern: c32$
-              - items:
-                  pattern: c32d-wl$
               - items:
                   pattern: cs32$
               - items:
                   pattern: c64$
-              - items:
-                  pattern: c64d-wl$
               - items:
                   pattern: cs64$
               - items:
@@ -136,6 +132,7 @@ properties:
               - renesas,r1ex24128
               - samsung,s524ad0xd1
           - const: atmel,24c128
+      - pattern: '^atmel,24c(32|64)d-wl$' # Actual vendor is st
 
   label:
     description: Descriptive name of the EEPROM.
-- 
2.43.0

Re: [PATCH] dt-bindings: eeprom: at24: Fix ST M24C64-D compatible schema

[Marek Vasut]

On 4/15/24 3:11 PM, Rob Herring wrote:
> The schema for the ST M24C64-D compatible string doesn't work.
> Validation fails as the 'd-wl' suffix is not added to the preceeding
> schema which defines the entries and vendors. The actual users are
> incorrect as well because the vendor is listed as Atmel whereas the
> part is made by ST.
> 
> As this part doesn't appear to have multiple vendors, move it to its own
> entry.
> 
> Fixes: 0997ff1fc143 ("dt-bindings: at24: add ST M24C64-D Additional Write lockable page")
> Fixes: c761068f484c ("dt-bindings: at24: add ST M24C32-D Additional Write lockable page")
> Signed-off-by: Rob Herring <robh@kernel.org>

For what it is worth:

Reviewed-by: Marek Vasut <marex@denx.de>

Re: [PATCH] dt-bindings: eeprom: at24: Fix ST M24C64-D compatible schema

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 747 bytes --]

On Mon, Apr 15, 2024 at 08:11:03AM -0500, Rob Herring wrote:
> The schema for the ST M24C64-D compatible string doesn't work.
> Validation fails as the 'd-wl' suffix is not added to the preceeding
> schema which defines the entries and vendors. The actual users are
> incorrect as well because the vendor is listed as Atmel whereas the
> part is made by ST.
> 
> As this part doesn't appear to have multiple vendors, move it to its own
> entry.
> 
> Fixes: 0997ff1fc143 ("dt-bindings: at24: add ST M24C64-D Additional Write lockable page")
> Fixes: c761068f484c ("dt-bindings: at24: add ST M24C32-D Additional Write lockable page")
> Signed-off-by: Rob Herring <robh@kernel.org>

Acked-by: Conor Dooley <conor.dooley@microchip.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH] dt-bindings: eeprom: at24: Fix ST M24C64-D compatible schema

[Bartosz Golaszewski]

On Mon, Apr 15, 2024 at 3:11 PM Rob Herring <robh@kernel.org> wrote:
>
> The schema for the ST M24C64-D compatible string doesn't work.
> Validation fails as the 'd-wl' suffix is not added to the preceeding
> schema which defines the entries and vendors. The actual users are
> incorrect as well because the vendor is listed as Atmel whereas the
> part is made by ST.
>
> As this part doesn't appear to have multiple vendors, move it to its own
> entry.
>
> Fixes: 0997ff1fc143 ("dt-bindings: at24: add ST M24C64-D Additional Write lockable page")
> Fixes: c761068f484c ("dt-bindings: at24: add ST M24C32-D Additional Write lockable page")
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>  Documentation/devicetree/bindings/eeprom/at24.yaml | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/eeprom/at24.yaml b/Documentation/devicetree/bindings/eeprom/at24.yaml
> index 1812ef31d5f1..3c36cd0510de 100644
> --- a/Documentation/devicetree/bindings/eeprom/at24.yaml
> +++ b/Documentation/devicetree/bindings/eeprom/at24.yaml
> @@ -68,14 +68,10 @@ properties:
>                    pattern: cs16$
>                - items:
>                    pattern: c32$
> -              - items:
> -                  pattern: c32d-wl$
>                - items:
>                    pattern: cs32$
>                - items:
>                    pattern: c64$
> -              - items:
> -                  pattern: c64d-wl$
>                - items:
>                    pattern: cs64$
>                - items:
> @@ -136,6 +132,7 @@ properties:
>                - renesas,r1ex24128
>                - samsung,s524ad0xd1
>            - const: atmel,24c128
> +      - pattern: '^atmel,24c(32|64)d-wl$' # Actual vendor is st
>
>    label:
>      description: Descriptive name of the EEPROM.
> --
> 2.43.0
>

Applied, thanks!

Bart