From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D12A5A4CF for ; Tue, 16 Apr 2024 21:14:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713302048; cv=none; b=oG45lv9HHKxfwa6O6LkQpIMJ6BntjFRJWXkm7F9y2A8LojKH8a46gZhliVDqRQ+YXWhNlTLFE/pMdQPiXQj/vXp3BCw3y4t3MyjMjN5wa4QPTywd8elMjIbMkqwPivErrIaSWoC/o3zFQ2WGfttAEayF/pah56F9MVxUa3NBIB4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713302048; c=relaxed/simple; bh=hYbx6PTsoNsyBmCWhe2uOm9re81gqj53ZsseQt9fWB4=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=oLKfwrZilOEAqiJKeuhWCMl18NiUt2fqzzHde6eX/66vRMa7xtnFg64JIAJZjDnv99rcqdr0xfB5DyUDX/GpuE4iI6ABQNk4x+HghWOiEwY8Yzktm6SCghK+k1G14iISC0AvYSfiKZ5TgkxCA8MmPgNGVSxx5j2kgG7Rm0QxDus= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=sluXXdnc; arc=none smtp.client-ip=209.85.167.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="sluXXdnc" Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-516db2214e6so6040276e87.1 for ; Tue, 16 Apr 2024 14:14:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1713302044; x=1713906844; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=dn04wT0JBm+obxx+kTlgG9j7vzEDda0ye02bvz0wRxM=; b=sluXXdnc6zdIs4x9p+gDWVyfXHvhECnrb0kh/6H9CxC3yxUcvbKWCW0Ape+I8l0i9U W9ZeZobz1qmCW39geKwWfPYrDAlXPXVifNNvv0bawPASmEwmF/LA7J7lhrApjyRLiVdz 4TfEeajCgDREwrov0hKC7Oshdsam1q91u7msP2RoulU+sgsY5fMr97QSxD8uP8N59sWL Qx9+/BUHXLKoV7+5P2fzGXyBJ18ZWyTIXK51qTFC0RkJcsi16/6w7O8ixhVzxWcWUVfN wVla90dAB15OGkhRWafEYM+wi7txvBODZ5xK2eEAo1/bXudY99irrjauwtSz9rUBodwX fctg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713302044; x=1713906844; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dn04wT0JBm+obxx+kTlgG9j7vzEDda0ye02bvz0wRxM=; b=GVYQOe7+pTUleDchQj7mIuW7TEVs5tx9LOzFDyzio4jRAAwLXVP92nPjZOg2fY22lt 8Gcv00llbr3ux99I3UTTm+9m8Ir8YCn5yEijju+T/eHRCizgPYMT6djQOnAtgDmrlqqe 4GDo4nKnIMgdEZg7o15ruhhU/CfxE+/J5CqW7KHb2TjiP8YBYH2B47xBEDaO2P8ibBUy aONIhRlp6M6SyVkMpN6EDweARk68BPFKt11bkyYsxMISLjNKTDqVQI290RsyVuL4BEfv bbwvbkmho4D02aqNRRri+exNxRtQi2mxnKpHCZ6Jx4RhWbYaHJD8UWQW3aKBgV8BzJLV 7qWA== X-Forwarded-Encrypted: i=1; AJvYcCXRn4k2QxLOriGof9AaNU8eefMqY5Wv2HqsDiss8GmIy2TTsPtucrD/RMGW19isfYowTnzrW5zs9Wfu92JSGEZ5mXgrSqmjTrdgug== X-Gm-Message-State: AOJu0Yw97Ju0T3cjYshIshMd4XXF6Ygn1YU9eNzh44O3dDpt9dfhic7G JTT6QLUS+i7I+kC6uV6gDfkPUTYNk7xlkSyg9QyL6x3MPtyOQ0A/4fjgqm6OXRGWvEI8ucMwT46 PrSbCAGiX+67cHA0yOpVGH8+AAp9I3CM7GwxjrA== X-Google-Smtp-Source: AGHT+IGAyUGV6VvWLvHMDAGW8JKzTq1oIDcVu3L+TgdMnw0Thj8YRZxvbWr+f5vVYXNKQFG5YhxvVU34ldmvzwxme38= X-Received: by 2002:a19:8c49:0:b0:517:87ba:aff3 with SMTP id i9-20020a198c49000000b0051787baaff3mr9237406lfj.43.1713302044303; Tue, 16 Apr 2024 14:14:04 -0700 (PDT) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240415131104.2807041-1-robh@kernel.org> In-Reply-To: <20240415131104.2807041-1-robh@kernel.org> From: Bartosz Golaszewski Date: Tue, 16 Apr 2024 23:13:53 +0200 Message-ID: Subject: Re: [PATCH] dt-bindings: eeprom: at24: Fix ST M24C64-D compatible schema To: Rob Herring Cc: Krzysztof Kozlowski , Conor Dooley , Alexander Stein , Marek Vasut , Conor Dooley , linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Apr 15, 2024 at 3:11=E2=80=AFPM Rob Herring wrote= : > > The schema for the ST M24C64-D compatible string doesn't work. > Validation fails as the 'd-wl' suffix is not added to the preceeding > schema which defines the entries and vendors. The actual users are > incorrect as well because the vendor is listed as Atmel whereas the > part is made by ST. > > As this part doesn't appear to have multiple vendors, move it to its own > entry. > > Fixes: 0997ff1fc143 ("dt-bindings: at24: add ST M24C64-D Additional Write= lockable page") > Fixes: c761068f484c ("dt-bindings: at24: add ST M24C32-D Additional Write= lockable page") > Signed-off-by: Rob Herring > --- > Documentation/devicetree/bindings/eeprom/at24.yaml | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/eeprom/at24.yaml b/Documen= tation/devicetree/bindings/eeprom/at24.yaml > index 1812ef31d5f1..3c36cd0510de 100644 > --- a/Documentation/devicetree/bindings/eeprom/at24.yaml > +++ b/Documentation/devicetree/bindings/eeprom/at24.yaml > @@ -68,14 +68,10 @@ properties: > pattern: cs16$ > - items: > pattern: c32$ > - - items: > - pattern: c32d-wl$ > - items: > pattern: cs32$ > - items: > pattern: c64$ > - - items: > - pattern: c64d-wl$ > - items: > pattern: cs64$ > - items: > @@ -136,6 +132,7 @@ properties: > - renesas,r1ex24128 > - samsung,s524ad0xd1 > - const: atmel,24c128 > + - pattern: '^atmel,24c(32|64)d-wl$' # Actual vendor is st > > label: > description: Descriptive name of the EEPROM. > -- > 2.43.0 > Applied, thanks! Bart