From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F0B54A2E19 for ; Wed, 22 Jul 2026 10:03:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784714598; cv=none; b=DQezlIxNV12QwAaUJC1ckXtNLcdL3Bq5cBbZBeTLyiC7sWPY0/UYQaLjvSrOr1cY/VeCaxNM/gCmWv/OrSf7kwovug03rm4naohSSvNSRtZDCJCDD3KNt6Cqc2TsdN3w/OLHHIKKkBSKbj2SgWMkeHOt7CWMo7tpk+c2TpTEDXE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784714598; c=relaxed/simple; bh=zoqfEescrEM4/AemE1soEzPnfcrpe9p3YE38rq4XzRQ=; h=From:In-Reply-To:MIME-Version:References:Date:Message-ID:Subject: To:Cc:Content-Type; b=is1v65LXKkvH9r0EOFus707DAUs1lvkTn/vs5GhbpHmJjPEm0D7o4J6WUUZnMmvWzQgwMgp5Dayo0te947CrgJW1ywBf1E4SRNFMpiKsvuYbpFnXyJNTffNyeXmG6ouKjGnOgmv0eYWMUz4huFsQ33O2DhcJ64UikiaNd6GM2oo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=aGMuUyLH; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="aGMuUyLH" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 63ECF1F0155D for ; Wed, 22 Jul 2026 10:03:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784714594; bh=v2nl4VWueEk9cKUhbw+kqvh7s/L/Uh+km+tAT2bP7fg=; h=From:In-Reply-To:References:Date:Subject:To:Cc; b=aGMuUyLHguxVRr1lFjeEqsXxI5a3BDv/DaaV4zoODVdfUElN6OPq6bkx5ATub1s7X NqCOBztx6noD+QfHAvSgTWe7vgJnIbtFqRfBncNwEd8MZhJAPkwQ6o1PmCErDh2eSF 54ujH4MI/X8WrSdzSMvJdDCh0pZpi+hUqSU2T1bUPAGLbQO4yixldnti713LXPNkci YythZGNmbpNbSYX0SZ1YxdtUM26wau81e41aUGstklcHdYCONGNwfqBX6p8ICowp/6 g9HicL6hWe6OdIC4YCD4+8eDDyuWsnOkh3GMzOh/RFUuABV1W9tcDEy8Izwff+b8ok dcHRMOjcvphAQ== Received: by mail-lf1-f42.google.com with SMTP id 2adb3069b0e04-5b15c6fb864so5868715e87.1 for ; Wed, 22 Jul 2026 03:03:14 -0700 (PDT) X-Forwarded-Encrypted: i=1; AHgh+Ro7bQmpE41/EHTzZ+iyV5j091YJhQ0zKHFcwJzBOcGmKrbExHEJ63nwZPnrHTpQyndPgy8su2H6kEfZ@vger.kernel.org X-Gm-Message-State: AOJu0YxKZjG0TFTjuyVVk58dkrAFZakemYMrHuXbfiHH8fsBvL0YlSGv biyuNPCeV5O7RaMIXyTRntNGsMHxbiBhR5yaLLi/DhK8LDJU7Av+7OAG94sTaJ3aOIzygSMDFY5 zxmwh+XeCzMI9XUetZyVuA5oGCFEeAPROQCfocyAQQw== X-Received: by 2002:a05:6512:3185:b0:5ae:b2e3:fc24 with SMTP id 2adb3069b0e04-5b28fabb0afmr5670333e87.60.1784714593132; Wed, 22 Jul 2026 03:03:13 -0700 (PDT) Received: from 969154062570 named unknown by gmailapi.google.com with HTTPREST; Wed, 22 Jul 2026 03:03:08 -0700 Received: from 969154062570 named unknown by gmailapi.google.com with HTTPREST; Wed, 22 Jul 2026 03:03:08 -0700 From: Bartosz Golaszewski In-Reply-To: Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20260721065413.2306137-1-wenst@chromium.org> <20260721065413.2306137-4-wenst@chromium.org> Date: Wed, 22 Jul 2026 03:03:08 -0700 X-Gmail-Original-Message-ID: X-Gm-Features: AUfX_mz93U1zn17dWP9tyqRdXvFYbDQgxlYVyw0vjRryfcxfP9O2fsTk4G3zrhY Message-ID: Subject: Re: [PATCH v6 03/16] power: sequencing: Add pwrseq_power_is_on() To: Chen-Yu Tsai Cc: linux-acpi@vger.kernel.org, driver-core@lists.linux.dev, linux-pm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam , Alan Stern , Bartosz Golaszewski , Greg Kroah-Hartman , Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , "Rafael J. Wysocki" , Danilo Krummrich , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Bartosz Golaszewski Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 22 Jul 2026 11:01:20 +0200, Chen-Yu Tsai said: > On Tue, Jul 21, 2026 at 5:08=E2=80=AFPM Bartosz Golaszewski wrote: >> >> > >> > +/** >> > + * pwrseq_power_is_on() - Queries the last requested state of the pow= er sequencer. >> > + * @desc: Descriptor referencing the power sequencer. >> > + * >> > + * This returns the last requested state of the power sequencer. >> > + * >> > + * Returns: >> > + * On success, 1 for on and 0 for off; negative error number on failu= re. >> > + */ >> > +int pwrseq_power_is_on(struct pwrseq_desc *desc) >> > +{ >> > + if (!desc) >> > + return -EINVAL; >> > + >> > + return desc->powered_on; >> > +} >> > +EXPORT_SYMBOL_GPL(pwrseq_power_is_on); >> > + >> >> Didn't we agree on introducing an enum to make it future-proof for when = we >> also pull in pwrseq_is_controllable() from Loic? > > My bad. I misunderstood and thought it wasn't needed yet. It's not technically needed *yet* but since we know where we're going, it makes sense to be proactive. > >> I think this should work like so: >> >> enum { >> PWRSEQ_STATE_UNKNOWN, >> PWRSEQ_STATE_ON, >> PWRSEQ_STATE_OFF, >> }; >> >> int pwrseq_get_state(struct pwrseq_desc *desc) >> { > > I think you still want this here? > > if (!desc) > return -EINVAL; > > Yes. Bart