From: Sasha Finkelstein <fnkl.kernel@gmail.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: thierry.reding@gmail.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, marcan@marcan.st,
sven@svenpeter.dev, alyssa@rosenzweig.io, asahi@lists.linux.dev,
linux-arm-kernel@lists.infradead.org, linux-pwm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 2/5] pwm: Add Apple PWM controller
Date: Fri, 13 Jan 2023 21:25:08 +0300 [thread overview]
Message-ID: <CAMT+MTToR+0_CmVBuGfLemALUv1XuevObAMB=TQXV0Vd7HdW5Q@mail.gmail.com> (raw)
In-Reply-To: <20230110230618.pfz267jj5ne34ava@pengutronix.de>
On Wed, 11 Jan 2023 at 02:06, Uwe Kleine-König
<u.kleine-koenig@pengutronix.de> wrote:
> > + * Limitations:
> > + * - The writes to cycle registers are shadowed until a write to
> > + * the control register.
> > + * - If both OFF_CYCLES and ON_CYCLES are set to 0, the output
> > + * is a constant off signal.
>
> How does the PWM behave with *APPLE_PWM_CTRLAPPLE_PWM_CTRL = 0?
> (typically: drives constant low)
>
APPLE_PWM_CTRL = 0 implies that the APPLE_CTRL_ENABLE bit is set low, which
turns off the pwm signal (constant low). I do not think that it is
necessary to explicitly
specify that case in the comments.
> Can you please rename such that the (maybe new) name for APPLE_PWM_CTRL
> is a prefix for the (maybe new) APPLE_CTRL_ENABLE and the other register
> bit definitions?
To make sure, you want the register named APPLE_PWM_CTRL, and the bits named
APPLE_PWM_CTRL_ENABLE, APPLE_PWM_CTRL_MODE and so on?
next prev parent reply other threads:[~2023-01-13 18:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-06 13:58 [PATCH v6 0/5] PWM and keyboard backlight driver for ARM Macs Sasha Finkelstein
2023-01-06 13:58 ` [PATCH v6 1/5] dt-bindings: pwm: Add Apple PWM controller Sasha Finkelstein
2023-01-06 13:58 ` [PATCH v6 2/5] " Sasha Finkelstein
2023-01-10 23:06 ` Uwe Kleine-König
2023-01-13 18:25 ` Sasha Finkelstein [this message]
2023-01-13 18:39 ` Uwe Kleine-König
2023-01-06 13:58 ` [PATCH v6 3/5] arm64: dts: apple: t8103: Add " Sasha Finkelstein
2023-01-06 13:58 ` [PATCH v6 4/5] arm64: dts: apple: t600x: " Sasha Finkelstein
2023-01-06 16:51 ` Hector Martin
2023-01-06 13:58 ` [PATCH v6 5/5] MAINTAINERS: Add entries for Apple PWM driver Sasha Finkelstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMT+MTToR+0_CmVBuGfLemALUv1XuevObAMB=TQXV0Vd7HdW5Q@mail.gmail.com' \
--to=fnkl.kernel@gmail.com \
--cc=alyssa@rosenzweig.io \
--cc=asahi@lists.linux.dev \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=robh+dt@kernel.org \
--cc=sven@svenpeter.dev \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).