Re: [PATCH 2/3] backlight/arcxcnn fix vendor prefix

From: Daniel Thompson <daniel.thompson@linaro.org>
To: Brian Dodge <bdodge09@gmail.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>, Jingoo Han <jingoohan1@gmail.com>,
	DRI Development <dri-devel@lists.freedesktop.org>,
	Rob Herring <robh+dt@kernel.org>,
	Jacek Anaszewski <jacek.anaszewski@gmail.com>,
	Pavel Machek <pavel@ucw.cz>, Peter Bacon <pbacon@psemi.com>,
	Lee Jones <lee.jones@linaro.org>,
	Linux LED Subsystem <linux-leds@vger.kernel.org>
Subject: Re: [PATCH 2/3] backlight/arcxcnn fix vendor prefix
Date: Fri, 21 Jun 2019 14:39:01 +0100	[thread overview]
Message-ID: <CAMTL27EJuD3WOBDVd_wen=VCxMZ-RPMZ52JnGBKjzftr-twKsw@mail.gmail.com> (raw)
In-Reply-To: <e372391c-1fd5-41ec-b766-7669fffb928d@gmail.com>

[-- Attachment #1.1: Type: text/plain, Size: 2123 bytes --]

Hi Brian

On Tue, 27 Nov 2018 at 00:44, Brian Dodge <bdodge09@gmail.com> wrote:

> Thank you Pavel, that is a good point.
>
> The chip vendor has indicated that there is no reason to maintain the
> old/improper prefix and wishes to go forward (only) with the "arctic"
> prefix and any existing dts files are or will be updated.
>

Looks like this patch series has fallen into the cracks a little.

I think I assumed this info would end in the description of patch v2 1/3
(in order to answer Rob's feedback) and I sat and waited for a respin. On
the other hand... I didn't actually say that explicitly anywhere! So... I'd
recommend a respin perhaps with a small bit of text explaining how the
vendor can state that any existing dts files will be updated. This is a
peripheral device so these strings are probably embedded into OEM
devicetrees rather than exclusively under the control of the vendor.

Daniel.

> On 11/11/18 6:30 AM, Pavel Machek wrote:
> > Hi!
> >
> >> The vendor-prefixes.txt file properly refers to ArcticSand
> >> as arctic but the driver improperly abbreviated the prefix
> >> to arc. This was a mistake in the original patch
> >>
> >> Signed-off-by: Brian Dodge <bdodge09@gmail.com>
> >> ---
> >>   drivers/video/backlight/arcxcnn_bl.c | 22 +++++++++++-----------
> >>   1 file changed, 11 insertions(+), 11 deletions(-)
> >>
> >>    *
> >> - * Copyright 2016 ArcticSand, Inc.
> >> - * Author : Brian Dodge <bdodge@arcticsand.com>
> >> + * Copyright 2018 pSemi, Inc.
> >> + * Author : Brian Dodge <bdodge@psemi.com>
> > Ummm. Copyright 2016-2018?
> >
> >> @@ -202,27 +202,27 @@ static void arcxcnn_parse_dt(struct arcxcnn *lp)
> >>      if (ret == 0)
> >>              lp->pdata->initial_brightness = prog_val;
> >>
> >> -    ret = of_property_read_u32(node, "arc,led-config-0", &prog_val);
> >> +    ret = of_property_read_u32(node, "arctic,led-config-0", &prog_val);
> >>      if (ret == 0)
> >>              lp->pdata->led_config_0 = (u8)prog_val;
> >>
> > If there's a dts using this, you want to update it at the same
> > time. You may want to support both names going forward.
> >
>  Pavel
>

[-- Attachment #1.2: Type: text/html, Size: 3331 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel