From mboxrd@z Thu Jan 1 00:00:00 1970 From: Colin Cross Subject: Re: [PATCH v6 04/10] arm/tegra: prepare early init for multiple tegra variants Date: Fri, 9 Dec 2011 10:35:09 -0800 Message-ID: References: <1323348254-29072-1-git-send-email-pdeschrijver@nvidia.com> <1323348254-29072-5-git-send-email-pdeschrijver@nvidia.com> <74CDBE0F657A3D45AFBB94109FB122FF1750B77A7E@HQMAIL01.nvidia.com> <20111209111925.GK27578@tbergstrom-lnx.Nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20111209111925.GK27578@tbergstrom-lnx.Nvidia.com> Sender: linux-doc-owner@vger.kernel.org To: Peter De Schrijver Cc: Stephen Warren , Grant Likely , Rob Herring , Randy Dunlap , Russell King , Olof Johansson , Gary King , "devicetree-discuss@lists.ozlabs.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-tegra@vger.kernel.org" List-Id: devicetree@vger.kernel.org On Fri, Dec 9, 2011 at 3:19 AM, Peter De Schrijver wrote: > On Thu, Dec 08, 2011 at 07:29:43PM +0100, Colin Cross wrote: >> On Thu, Dec 8, 2011 at 9:57 AM, Stephen Warren = wrote: >> > Peter De Schrijver wrote at Thursday, December 08, 2011 5:44 AM: >> >> This patch splits the early init code in a common and a tegra20 s= pecific part. >> >> L2 cache initialization is generalized and discovers the cache as= sociativity >> >> at runtime. Also use arm_pm_restart instead of arm_arch_reset and= reset the >> >> the system using the PMC reset feature rather then the CAR system= reset. >> > >> > This one really should be at least 3 separate patches: >> > * s/tegra_init_early/tegra20_init_early/ in machine descriptions >> > * Switch reset mechanism from CAR to PMC >> > * tegra_init_cache modifications >> > * Not sure if all the ifdef additions go in the above, or if some = should be >> > =A0separate? >> > >> > Still, I think it's probably OK to go in as it is even if it isn't= optimal. >> >> Please at least split out the reset change. =A0Does using the PMC re= set >> instead of the CAR reset still result in a warm reset, or does it >> change to a cold reset? > > What do you consider a cold reset in the tegra world? Power rails turn off and on. Some of our debugging tools rely on memory contents surviving across a reset, and that is generally true of a warm reset, but not a cold reset.