devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v1 1/1] arm64: dts: qcom: x1e80100-lenovo-yoga-slim7x: enable MICs LDO
@ 2025-04-11 15:54 Aleksandrs Vinarskis
  2025-04-11 19:25 ` Konrad Dybcio
  0 siblings, 1 reply; 3+ messages in thread
From: Aleksandrs Vinarskis @ 2025-04-11 15:54 UTC (permalink / raw)
  To: Bjorn Andersson, linux-arm-msm, devicetree, linux-kernel
  Cc: Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Aleksandrs Vinarskis

Particular device comes without headset combo jack, hence does not
feature wcd codec IC. In such cases, DMICs are powered from vreg_l1b.
Set regulator as always-on to enable microphones.

Signed-off-by: Aleksandrs Vinarskis <alex.vinarskis@gmail.com>
---
 arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts b/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts
index 35d97db9e1f6..4a35846b5947 100644
--- a/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts
+++ b/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts
@@ -269,6 +269,7 @@ vreg_l1b_1p8: ldo1 {
 			regulator-min-microvolt = <1800000>;
 			regulator-max-microvolt = <1800000>;
 			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+			regulator-always-on;
 		};
 
 		vreg_l2b_3p0: ldo2 {
-- 
2.45.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v1 1/1] arm64: dts: qcom: x1e80100-lenovo-yoga-slim7x: enable MICs LDO
  2025-04-11 15:54 [PATCH v1 1/1] arm64: dts: qcom: x1e80100-lenovo-yoga-slim7x: enable MICs LDO Aleksandrs Vinarskis
@ 2025-04-11 19:25 ` Konrad Dybcio
  2025-04-12 12:45   ` Aleksandrs Vinarskis
  0 siblings, 1 reply; 3+ messages in thread
From: Konrad Dybcio @ 2025-04-11 19:25 UTC (permalink / raw)
  To: Aleksandrs Vinarskis, Bjorn Andersson, linux-arm-msm, devicetree,
	linux-kernel
  Cc: Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley

On 4/11/25 5:54 PM, Aleksandrs Vinarskis wrote:
> Particular device comes without headset combo jack, hence does not
> feature wcd codec IC. In such cases, DMICs are powered from vreg_l1b.
> Set regulator as always-on to enable microphones.
> 
> Signed-off-by: Aleksandrs Vinarskis <alex.vinarskis@gmail.com>
> ---

Can we bind it to the soundcard or something, so that we're not leaking
power?

Konrad

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v1 1/1] arm64: dts: qcom: x1e80100-lenovo-yoga-slim7x: enable MICs LDO
  2025-04-11 19:25 ` Konrad Dybcio
@ 2025-04-12 12:45   ` Aleksandrs Vinarskis
  0 siblings, 0 replies; 3+ messages in thread
From: Aleksandrs Vinarskis @ 2025-04-12 12:45 UTC (permalink / raw)
  To: Konrad Dybcio
  Cc: Bjorn Andersson, linux-arm-msm, devicetree, linux-kernel,
	Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley

You are right, this is probably too 'dirty' fix.
I did some more digging, and found the root cause of the problem -
MICs were not configured in audio routings, even though vreg was
already binded to lpass_macro. Will send v2.

Thanks,
Alex


On Fri, 11 Apr 2025 at 21:25, Konrad Dybcio
<konrad.dybcio@oss.qualcomm.com> wrote:
>
> On 4/11/25 5:54 PM, Aleksandrs Vinarskis wrote:
> > Particular device comes without headset combo jack, hence does not
> > feature wcd codec IC. In such cases, DMICs are powered from vreg_l1b.
> > Set regulator as always-on to enable microphones.
> >
> > Signed-off-by: Aleksandrs Vinarskis <alex.vinarskis@gmail.com>
> > ---
>
> Can we bind it to the soundcard or something, so that we're not leaking
> power?
>
> Konrad

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-04-12 12:45 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-11 15:54 [PATCH v1 1/1] arm64: dts: qcom: x1e80100-lenovo-yoga-slim7x: enable MICs LDO Aleksandrs Vinarskis
2025-04-11 19:25 ` Konrad Dybcio
2025-04-12 12:45   ` Aleksandrs Vinarskis

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).