* [PATCH] arm64: dts: rockchip: Fix Pine64 Quartz4-B PMIC interrupt
@ 2022-11-06 16:15 Chen-Yu Tsai
2022-11-07 0:58 ` Peter Geis
2022-11-15 11:10 ` Heiko Stuebner
0 siblings, 2 replies; 3+ messages in thread
From: Chen-Yu Tsai @ 2022-11-06 16:15 UTC (permalink / raw)
To: Heiko Stuebner
Cc: Chen-Yu Tsai, devicetree, linux-arm-kernel, linux-rockchip,
linux-kernel
From: Chen-Yu Tsai <wens@csie.org>
Ths PMIC's interrupt line is tied to GPIO0_A3. This is described
correctly for the pinmux setting, but incorrectly for the interrupt.
Correct the interrupt setting so that interrupts from the PMIC get
delivered.
Fixes: dcc8c66bef79 ("arm64: dts: rockchip: add Pine64 Quartz64-B device tree")
Signed-off-by: Chen-Yu Tsai <wens@csie.org>
---
arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts
index 77b179cd20e7..b276eb0810c7 100644
--- a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts
@@ -246,7 +246,7 @@ rk809: pmic@20 {
compatible = "rockchip,rk809";
reg = <0x20>;
interrupt-parent = <&gpio0>;
- interrupts = <RK_PA7 IRQ_TYPE_LEVEL_LOW>;
+ interrupts = <RK_PA3 IRQ_TYPE_LEVEL_LOW>;
assigned-clocks = <&cru I2S1_MCLKOUT_TX>;
assigned-clock-parents = <&cru CLK_I2S1_8CH_TX>;
clock-names = "mclk";
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: Fix Pine64 Quartz4-B PMIC interrupt
2022-11-06 16:15 [PATCH] arm64: dts: rockchip: Fix Pine64 Quartz4-B PMIC interrupt Chen-Yu Tsai
@ 2022-11-07 0:58 ` Peter Geis
2022-11-15 11:10 ` Heiko Stuebner
1 sibling, 0 replies; 3+ messages in thread
From: Peter Geis @ 2022-11-07 0:58 UTC (permalink / raw)
To: Chen-Yu Tsai
Cc: Heiko Stuebner, Chen-Yu Tsai, devicetree, linux-arm-kernel,
linux-rockchip, linux-kernel
On Sun, Nov 6, 2022 at 11:15 AM Chen-Yu Tsai <wens@kernel.org> wrote:
>
> From: Chen-Yu Tsai <wens@csie.org>
>
> Ths PMIC's interrupt line is tied to GPIO0_A3. This is described
> correctly for the pinmux setting, but incorrectly for the interrupt.
>
> Correct the interrupt setting so that interrupts from the PMIC get
> delivered.
>
> Fixes: dcc8c66bef79 ("arm64: dts: rockchip: add Pine64 Quartz64-B device tree")
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
Good catch, thanks!
Reviewed-by: Peter Geis <pgwipeout@gmail.com>
> ---
> arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts
> index 77b179cd20e7..b276eb0810c7 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts
> @@ -246,7 +246,7 @@ rk809: pmic@20 {
> compatible = "rockchip,rk809";
> reg = <0x20>;
> interrupt-parent = <&gpio0>;
> - interrupts = <RK_PA7 IRQ_TYPE_LEVEL_LOW>;
> + interrupts = <RK_PA3 IRQ_TYPE_LEVEL_LOW>;
> assigned-clocks = <&cru I2S1_MCLKOUT_TX>;
> assigned-clock-parents = <&cru CLK_I2S1_8CH_TX>;
> clock-names = "mclk";
> --
> 2.34.1
>
>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: Fix Pine64 Quartz4-B PMIC interrupt
2022-11-06 16:15 [PATCH] arm64: dts: rockchip: Fix Pine64 Quartz4-B PMIC interrupt Chen-Yu Tsai
2022-11-07 0:58 ` Peter Geis
@ 2022-11-15 11:10 ` Heiko Stuebner
1 sibling, 0 replies; 3+ messages in thread
From: Heiko Stuebner @ 2022-11-15 11:10 UTC (permalink / raw)
To: Chen-Yu Tsai
Cc: Heiko Stuebner, linux-arm-kernel, Chen-Yu Tsai, linux-kernel,
devicetree, linux-rockchip
On Mon, 7 Nov 2022 00:15:13 +0800, Chen-Yu Tsai wrote:
> From: Chen-Yu Tsai <wens@csie.org>
>
> Ths PMIC's interrupt line is tied to GPIO0_A3. This is described
> correctly for the pinmux setting, but incorrectly for the interrupt.
>
> Correct the interrupt setting so that interrupts from the PMIC get
> delivered.
>
> [...]
Applied, thanks!
[1/1] arm64: dts: rockchip: Fix Pine64 Quartz4-B PMIC interrupt
commit: 562105c1b072411c71ac2202410d83ee79297624
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-11-15 11:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-06 16:15 [PATCH] arm64: dts: rockchip: Fix Pine64 Quartz4-B PMIC interrupt Chen-Yu Tsai
2022-11-07 0:58 ` Peter Geis
2022-11-15 11:10 ` Heiko Stuebner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).