From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FE13C433EF for ; Sat, 9 Apr 2022 11:30:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238428AbiDILdD (ORCPT ); Sat, 9 Apr 2022 07:33:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40174 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232971AbiDILdC (ORCPT ); Sat, 9 Apr 2022 07:33:02 -0400 Received: from mail-yb1-xb36.google.com (mail-yb1-xb36.google.com [IPv6:2607:f8b0:4864:20::b36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AC794329BF; Sat, 9 Apr 2022 04:30:55 -0700 (PDT) Received: by mail-yb1-xb36.google.com with SMTP id z33so19347954ybh.5; Sat, 09 Apr 2022 04:30:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mEdKNOhh1cJDumzmCZuUJ2Wd2FaFg67XH6NgTF7v8WY=; b=LIxE2fWa9+x7p5aHVMDiLcfp1TOnxGHGxyZ+iEYDu3WEdZ20PCzgEy/SjoLWMMN7Vz 003K2adDJcFxWm6BpWILM+aMKWEAv3lJEB1q7gJ2GdO4441kuhy1N/p06Mqdx3PeM5ib jLaeNTVPv30y8zGCAy8h8dFsAqXYcKzLC1++wueiCPxYjI2b7AugrzDpSq+qGNh9nG/M QjtL0IHWKi1yvvv87ZJKzMA9HX9YRXZxUYmU4VaEX4inSqTYkHxKpGp4fF9dkICUtalx +nG3HF4p/z8DftmT2e5pTEKmnvGGd2oIBUqU7OlihbGCtHi94FYbEyz2sYksWRNuFQ8F R7eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mEdKNOhh1cJDumzmCZuUJ2Wd2FaFg67XH6NgTF7v8WY=; b=65NDOtalHwNUI0iVmvcYKN0Uu/8bukmRQAFtunf4qzQoet/bXeTCl8aw5LKswaZuQy NS9aeXMJOliZ+xJ+ekZ4t8RHHOP2auYes5qSA5hKsYFlSPEorq0l47P3EbAnVt3MgoHs ViB9D1EL83Tn3nLOPSCqdjp8Gh/1ki78ptHnEuGADNnopX0DWCztU2iw1/he5AAh24st DZqwTciRPd/r/J2nJl6JOxabSe6+sxX4wlrvpHvr5A/bt8J+6cFggRT6AIMWE6QuzWc/ 1sZw8n0bSImQec1Oq+1kEVERtjxQtmWpkK3+IzVMWSWl6+c6ier68QjPr8/bT62zfjZJ LMyg== X-Gm-Message-State: AOAM5327QruJaL3Jj04PSS+v5CPVVO5TegdxmdNbFopdJIzAQv/ThRfn 8xPPELHTRnQFnH2/N2OfbgJsWzsqIbGfVPauBEs= X-Google-Smtp-Source: ABdhPJxqVEZXDf3+mCnU5nKUvPBmSkptvptGaHEpqZlM50Q8ex928jQytNFPWQ3jzbK4691NI6HFuB4CUcuyT1o8nCA= X-Received: by 2002:a05:6902:cf:b0:641:32bb:53fc with SMTP id i15-20020a05690200cf00b0064132bb53fcmr365654ybs.232.1649503854885; Sat, 09 Apr 2022 04:30:54 -0700 (PDT) MIME-Version: 1.0 References: <20220409075147.136187-1-linux@fw-web.de> <4559790.iIbC2pHGDl@phil> In-Reply-To: From: Peter Geis Date: Sat, 9 Apr 2022 07:30:44 -0400 Message-ID: Subject: Re: Aw: Re: Re: [PATCH] arm64: dts: rockchip: Fix clocks for rk356x usb To: Heiko Stuebner Cc: Dan Johansen , Frank Wunderlich , Frank Wunderlich , "open list:ARM/Rockchip SoC..." , Rob Herring , Krzysztof Kozlowski , Michael Riesch , devicetree , arm-mail-list , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Sat, Apr 9, 2022 at 7:14 AM Peter Geis wrote: > > On Sat, Apr 9, 2022 at 7:01 AM Heiko Stuebner wrote: > > > > Am Samstag, 9. April 2022, 12:57:39 CEST schrieb Frank Wunderlich: > > > Hi > > > > Gesendet: Samstag, 09. April 2022 um 12:40 Uhr > > > > Von: "Dan Johansen" > > > > > > > So the issue is only with usb 3 ports, not usb 2 ports? > > > > > > my board has no standalone usb2-ports. usb2 is integrated into the usb3 ports (dual phy). here both were not working. > > > > > > afaik rk3566 has standalone usb2 ports that may not be broken, but i have no such board for testing. > > Good Morning, > > > > > As far as I understand the issue now after checking the code, this > > patch actually fixes the usb3 series from Peter, right? > > > > I.e. the usb-nodes that are fixed in this patch are not yet present > > in the main rk356x dtsi and only get added in > > "arm64: dts: rockchip: add rk356x dwc3 usb3 nodes" [0] > > > > As we don't want to add broken changes, this fix should squashed > > into a next version of the patch adding the nodes. > > Thank you for reporting this, I will squash this fix in and add your signed-off. > > However the offending patch is in fact the clock separation patch, and > it breaks backwards compatibility with the rk3328 dtsi which is why my > series also is broken. > > The rockchip,dwc3.yaml needs to be fixed to align with the > snps,dwc3.yaml, and both the rk3328 and rk3399 clock names updated. > Also the offending clock separation patch needs a fix to grab the old > clock names for rk3328 backwards compatibility to be retained. > > This might also be a good time to look into moving rk3399 to the core > dwc3 driver? > > This is a delightful mess. In the idea of getting this series to land, if all parties agree, I'll submit a patch that fixes the clock separation patch with this series and leave the naming as is for now. The renaming of clocks and alignment of everything can be addressed in a future series once discussion on how best to handle it has happened. Do you concur with this? > > > > > > > Heiko > > > > [0] https://lore.kernel.org/r/20220408151237.3165046-4-pgwipeout@gmail.com > > > > > > Very Respectfully, > Peter Geis