From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C4E5C28CF5 for ; Wed, 26 Jan 2022 16:04:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233488AbiAZQEj (ORCPT ); Wed, 26 Jan 2022 11:04:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53334 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231276AbiAZQEj (ORCPT ); Wed, 26 Jan 2022 11:04:39 -0500 Received: from mail-yb1-xb34.google.com (mail-yb1-xb34.google.com [IPv6:2607:f8b0:4864:20::b34]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DD07DC06161C for ; Wed, 26 Jan 2022 08:04:38 -0800 (PST) Received: by mail-yb1-xb34.google.com with SMTP id i62so227456ybg.5 for ; Wed, 26 Jan 2022 08:04:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=I1PFWUBDwhEY3Hv2QBW+PKkoeBVqFCkIFV0TuJ7bvS8=; b=P0OwVjXGqxYvsrwB7spRllLzGtiOBqjE0WSO7AYtGnmDOvkbK58mgms4Kc+Cfe9CAb VCEcyBeitlDZUrJI9x+1xHYvONl3nxmo38WuR/WbDnARdBvrcbnw4EMDihlOd9gvprrI UioSkgQz5gCMF0iNPrsnwuxtjq5AKy17Nc3MH5MKgjwIstBOgWTGpEraXDgZxNkhip2W 5yRw89f4Rvmk+/tyRxy7haKoJMZgPw4Z+5oNXnC7qyLkJuaYvQt0oPNMCv+UWlNyiSQN BQuicCfmyi08sy50mYqftEt2JmvWlzo+QzjW+SS57BdbgZmAUSrqESwfbqhBYi/qfru4 PXwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=I1PFWUBDwhEY3Hv2QBW+PKkoeBVqFCkIFV0TuJ7bvS8=; b=qYoPRfYBlFdNbAE1nEQTCQhpWwI/PijxKxwv24ckaPd6/V3IwpdRZ6TCWVrStmQaUg 8xoahVvJAvdbNMqKQzZWFK9PSLugc/jI5rbpLLXOFnzlEczAyEE5hrROx/3opHCuB/Al So7UY16mPWCWqYX2QSmJX2hmQX9DGPqJNw1MmBTlc+R9NiO687r/QJXp1/viqNw1MvcS vIK9833DYzWuFs78HdRRfNjiL70YgXu7YpgrRZ2nnUdIbMP6NirQ9WdkjzXm4FV+4E2q jYsn1KfX6nZq4PL1lGnfwxFmANDarzM+g2CgdyemUN/xrvU50fhMBEfR0+GM22Qit/Ac Thog== X-Gm-Message-State: AOAM530t9ONLlQG7WgYDBCTk117ftO3qv3pCMmbsKbbGrKwrXtQOPpjd f0UcudR03+NTuedUt7Zo7HlR7WqFjEoRE7PytUFwioWRXcM= X-Google-Smtp-Source: ABdhPJw0/pa8cCSqurWfk1GgO29W+8GRV6N3mR0rOJRhQPTh932RajwBQ5CXANcMfITbWzinmuCmScUdNZmKYWuDiyc= X-Received: by 2002:a25:8888:: with SMTP id d8mr33876297ybl.405.1643213077990; Wed, 26 Jan 2022 08:04:37 -0800 (PST) MIME-Version: 1.0 References: <20220126145549.617165-1-s.hauer@pengutronix.de> <20220126145549.617165-22-s.hauer@pengutronix.de> In-Reply-To: <20220126145549.617165-22-s.hauer@pengutronix.de> From: Peter Geis Date: Wed, 26 Jan 2022 11:04:26 -0500 Message-ID: Subject: Re: [PATCH 21/27] arm64: dts: rockchip: rk356x: Add HDMI nodes To: Sascha Hauer Cc: dri-devel@lists.freedesktop.org, arm-mail-list , "open list:ARM/Rockchip SoC..." , devicetree , kernel@pengutronix.de, Andy Yan , Benjamin Gaignard , Michael Riesch , Sandy Huang , =?UTF-8?Q?Heiko_St=C3=BCbner?= Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, Jan 26, 2022 at 9:58 AM Sascha Hauer wrote: > > Add support for the HDMI port found on RK3568. > > Signed-off-by: Sascha Hauer > --- > arch/arm64/boot/dts/rockchip/rk356x.dtsi | 37 +++++++++++++++++++++++- > 1 file changed, 36 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk356x.dtsi b/arch/arm64/boot/dts/rockchip/rk356x.dtsi > index 4008bd666d01..e38fb223e9b8 100644 > --- a/arch/arm64/boot/dts/rockchip/rk356x.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk356x.dtsi > @@ -10,7 +10,6 @@ > #include > #include > #include > -#include > #include > > / { > @@ -502,6 +501,42 @@ vop_mmu: iommu@fe043e00 { > status = "disabled"; > }; > > + hdmi: hdmi@fe0a0000 { > + compatible = "rockchip,rk3568-dw-hdmi"; > + reg = <0x0 0xfe0a0000 0x0 0x20000>; > + interrupts = ; > + clocks = <&cru PCLK_HDMI_HOST>, > + <&cru CLK_HDMI_SFR>, > + <&cru CLK_HDMI_CEC>, > + <&pmucru CLK_HDMI_REF>, > + <&cru HCLK_VOP>; > + clock-names = "iahb", "isfr", "cec", "ref", "hclk"; > + pinctrl-names = "default"; > + pinctrl-0 = <&hdmitx_scl &hdmitx_sda &hdmitxm0_cec>; I looked into CEC support here, and it seems that it does work with one change. Please add the two following lines to your patch: assigned-clocks = <&cru CLK_HDMI_CEC>; assigned-clock-rates = <32768>; The issue is the clk_rtc32k_frac clock that feeds clk_rtc_32k which feeds clk_hdmi_cec is 24mhz at boot, which is too high for CEC to function. > + power-domains = <&power RK3568_PD_VO>; > + reg-io-width = <4>; > + rockchip,grf = <&grf>; > + #sound-dai-cells = <0>; > + status = "disabled"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + hdmi_in: port@0 { > + reg = <0>; > + #address-cells = <1>; > + #size-cells = <0>; > + }; > + > + hdmi_out: port@1 { > + reg = <1>; > + #address-cells = <1>; > + #size-cells = <0>; > + }; > + }; > + }; > + > qos_gpu: qos@fe128000 { > compatible = "rockchip,rk3568-qos", "syscon"; > reg = <0x0 0xfe128000 0x0 0x20>; > -- > 2.30.2 >