From: Sergio Paracuellos <sergio.paracuellos@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Greg KH <gregkh@linuxfoundation.org>,
Linus Walleij <linus.walleij@linaro.org>,
driverdev-devel@linuxdriverproject.org,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>, NeilBrown <neil@brown.name>
Subject: Re: [PATCH v2 1/2] gpio: mediatek: add driver for MT7621
Date: Fri, 29 Jun 2018 15:51:05 +0200 [thread overview]
Message-ID: <CAMhs-H9NcFrTUM+9zSSObYZPvc8sqeAgomnT3RRpRgumwe8ZzQ@mail.gmail.com> (raw)
In-Reply-To: <20180629133135.dohzidxjm5k7jkbn@mwanda>
On Fri, Jun 29, 2018 at 3:31 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> Looks pretty clean to me. Sorry for not reviewing v1. Smatch (private
> devel version) points out a little bit of dead code.
>
> drivers/staging/mt7621-gpio/gpio-mt7621.c:200 mediatek_gpio_irq_handler() warn: address of 'gpio_data->gc_map[i]' is non-NULL
> drivers/staging/mt7621-gpio/gpio-mt7621.c:225 mediatek_gpio_irq_unmask() warn: address of 'gpio_data->gc_map[bank]' is non-NULL
> drivers/staging/mt7621-gpio/gpio-mt7621.c:246 mediatek_gpio_irq_mask() warn: address of 'gpio_data->gc_map[bank]' is non-NULL
> drivers/staging/mt7621-gpio/gpio-mt7621.c:266 mediatek_gpio_irq_type() warn: address of 'gpio_data->gc_map[bank]' is non-NULL
>
> But that's harmless and very minor.
That warnings should not being in the staging version. Last patch
series was applied yesterday... Maybe you have not run against the
updated tree?
This patch fix them:
https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/commit/?h=staging-testing&id=bfb623c5b0935a2e4b5fe86eab79a37a37b67209
>
> regards,
> dan carpenter
Thanks.
Best regards,
Sergio Paracuellos
>
next prev parent reply other threads:[~2018-06-29 13:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-29 12:43 [PATCH v2 0/2] gpio: mediatek: driver for gpio chip in MT7621 SoC Sergio Paracuellos
2018-06-29 12:43 ` [PATCH v2 1/2] gpio: mediatek: add driver for MT7621 Sergio Paracuellos
2018-06-29 13:31 ` Dan Carpenter
2018-06-29 13:34 ` Dan Carpenter
2018-06-29 13:51 ` Sergio Paracuellos [this message]
2018-06-29 16:43 ` kbuild test robot
2018-06-29 16:52 ` Sergio Paracuellos
2018-06-29 19:30 ` Sergio Paracuellos
2018-06-30 6:12 ` Sergio Paracuellos
2018-06-29 12:43 ` [PATCH v2 2/2] dt-bindings: document gpio-mt7621 bindings Sergio Paracuellos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMhs-H9NcFrTUM+9zSSObYZPvc8sqeAgomnT3RRpRgumwe8ZzQ@mail.gmail.com \
--to=sergio.paracuellos@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=devicetree@vger.kernel.org \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=neil@brown.name \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).