From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A7C2EB64D9 for ; Thu, 15 Jun 2023 13:47:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343965AbjFONrl (ORCPT ); Thu, 15 Jun 2023 09:47:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55462 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230443AbjFONrk (ORCPT ); Thu, 15 Jun 2023 09:47:40 -0400 Received: from mail-qk1-x72a.google.com (mail-qk1-x72a.google.com [IPv6:2607:f8b0:4864:20::72a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 615ED1BDB for ; Thu, 15 Jun 2023 06:47:39 -0700 (PDT) Received: by mail-qk1-x72a.google.com with SMTP id af79cd13be357-762215a64e6so12919885a.1 for ; Thu, 15 Jun 2023 06:47:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686836858; x=1689428858; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=HlZJFQHGnnGtL9UMgugLsRODzWb3kDKPZVxr84A3G1U=; b=lNWXFDzCR59VgJ5LNZpPBjWbbMoVrpWdSpFbIsODbhVv7+mFtpIr/PQw7VIabqJlPD saQI0qmGe3TReDc1TlRpqcR4kiOxQtNqPv9CDsms4JRnWSuAtgFTx+grFiQ1gs8KKLPg 0h/DgmqrMInZfe/+UXFQSHCktjo7q1PoheThf2rKMvG9RmI+O1SoDhyj6r8EAqF/rrev VTw10YDPpzkYISVW4MvqoDv4XFSt8LuJSq5YStzNj8eROq/R56ocLe/8fhfdgQaMHotq 4W2jvDQ60qXxq28pXPyMgnzllgufXTpZvCDn8rdLqKOq4vm2g4BaTunNxfHi1mn3KO2y gEPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686836858; x=1689428858; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=HlZJFQHGnnGtL9UMgugLsRODzWb3kDKPZVxr84A3G1U=; b=i/RsWccivYL6qgUHYMP/CTfIzdzoXC87wsfsOEnvq95dTLkWmRfnkynItnf8L+BRrJ dAD+2G/Fe0vmKj3kwbVSRIoXrSk/cGG0ofTt5YaoW/jst373Ox9xbuaKYyG2Knq5hJNe q0Hx3o2Wo27qmzwo/QW1tAjn7ZEVlhUXrINURzw4E1AoyxHAvLUqq/cE0ilH91Bfpi1l p8NqLjRjXGUy0DwHA6oKhtlemiohspG/BJDcNw8WLcpTLFmtpdIMnKp8XkkYF6qIvjhX GBtfza/QJgttndEZGfVnkd9KrY3zPs/tCbO3kIY9PR0heuWdX3Uu3KHjT/4V03t0qaI0 pDhA== X-Gm-Message-State: AC+VfDzgGQXZ97rU9xgwiwxHxjZc2dXemaWzq4tcHYg7a/wPRyb04TN/ 9E/KO3P4AOAxP7V47DGYE/BUPmjfnht4//vBrqzaxg== X-Google-Smtp-Source: ACHHUZ5L3ZNI4mtuSiaC2uTD2gKYjnuz0pHO5+/2rAu1ZpYEpHnOveGpH3JaKWLKXP+kxxIm8tsTcJtzy0kuRZKwMTM= X-Received: by 2002:ad4:5d63:0:b0:62f:edd7:3155 with SMTP id fn3-20020ad45d63000000b0062fedd73155mr3161258qvb.45.1686836858413; Thu, 15 Jun 2023 06:47:38 -0700 (PDT) MIME-Version: 1.0 References: <20230602161246.1855448-1-amit.pundir@linaro.org> <358c69ad-fa8a-7386-fe75-92369883ee48@leemhuis.info> <0f6c9dcb-b7f6-fff9-6bed-f4585ea8e487@linaro.org> In-Reply-To: From: Amit Pundir Date: Thu, 15 Jun 2023 19:17:02 +0530 Message-ID: Subject: Re: [PATCH] arm64: dts: qcom: sdm845-db845c: Move LVS regulator nodes up To: Krzysztof Kozlowski Cc: Linux regressions mailing list , Mark Brown , Doug Anderson , Bjorn Andersson , Andy Gross , Rob Herring , Konrad Dybcio , Krzysztof Kozlowski , Caleb Connolly , Conor Dooley , linux-arm-msm , dt , lkml Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, 15 Jun 2023 at 00:38, Amit Pundir wrote: > > On Thu, 15 Jun 2023 at 00:17, Krzysztof Kozlowski > wrote: > > > > On 14/06/2023 20:18, Linux regression tracking (Thorsten Leemhuis) wrote: > > > On 02.06.23 18:12, Amit Pundir wrote: > > >> Move lvs1 and lvs2 regulator nodes up in the rpmh-regulators > > >> list to workaround a boot regression uncovered by the upstream > > >> commit ad44ac082fdf ("regulator: qcom-rpmh: Revert "regulator: > > >> qcom-rpmh: Use PROBE_FORCE_SYNCHRONOUS""). > > >> > > >> Without this fix DB845c fail to boot at times because one of the > > >> lvs1 or lvs2 regulators fail to turn ON in time. > > > > > > /me waves friendly > > > > > > FWIW, as it's not obvious: this... > > > > > >> Link: https://lore.kernel.org/all/CAMi1Hd1avQDcDQf137m2auz2znov4XL8YGrLZsw5edb-NtRJRw@mail.gmail.com/ > > > > > > ...is a report about a regression. One that we could still solve before > > > 6.4 is out. One I'll likely will point Linus to, unless a fix comes into > > > sight. > > > > > > When I noticed the reluctant replies to this patch I earlier today asked > > > in the thread with the report what the plan forward was: > > > https://lore.kernel.org/all/CAD%3DFV%3DV-h4EUKHCM9UivsFHRsJPY5sAiwXV3a1hUX9DUMkkxdg@mail.gmail.com/ > > > > > > Dough there replied: > > > > > > ``` > > > Of the two proposals made (the revert vs. the reordering of the dts), > > > the reordering of the dts seems better. It only affects the one buggy > > > board (rather than preventing us to move to async probe for everyone) > > > and it also has a chance of actually fixing something (changing the > > > order that regulators probe in rpmh-regulator might legitimately work > > > around the problem). That being said, just like the revert the dts > > > reordering is still just papering over the problem and is fragile / > > > not guaranteed to work forever. > > > ``` > > > > > > Papering over obviously is not good, but has anyone a better idea to fix > > > this? Or is "not fixing" for some reason an viable option here? > > > > > > > I understand there is a regression, although kernel is not mainline > > (hash df7443a96851 is unknown) and the only solutions were papering the > > problem. Reverting commit is a temporary workaround. Moving nodes in DTS > > is not acceptable because it hides actual problem and only solves this > > one particular observed problem, while actual issue is still there. It > > would be nice to be able to reproduce it on real mainline with normal > > operating system (not AOSP) - with ramdiks/without/whatever. So far no > > one did it, right? > > No, I did not try non-AOSP system yet. I'll try it tomorrow, if that > helps. With mainline hash. Hi, here is the crash report on db845c running vanilla v6.4-rc6 with a debian build https://bugs.linaro.org/attachment.cgi?id=1142 And fwiw here is the db845c crash log with AOSP running vanilla v6.4-rc6 https://bugs.linaro.org/attachment.cgi?id=1141 Regards, Amit Pundir PS: rootfs in this bug report doesn't matter much because I'm loading all the kernel modules from a ramdisk and in the case of a crash the UFS doesn't probe anyway.