From: Mike Frysinger <vapier.adi-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Jamie Iles <jamie-wmLquQDDieKakBO8gow8eQ@public.gmane.org>
Cc: David Woodhouse <dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Artem Bityutskiy
<Artem.Bityutskiy-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH] mtd: gpio-nand: add device tree bindings
Date: Wed, 27 Jul 2011 17:07:05 -0700 [thread overview]
Message-ID: <CAMjpGUdPaAi=8ktisse0W_qWWPvaPXyCf9RgKAV02YzD7cn1aA@mail.gmail.com> (raw)
In-Reply-To: <1311775410-5158-1-git-send-email-jamie-wmLquQDDieKakBO8gow8eQ@public.gmane.org>
On Wed, Jul 27, 2011 at 07:03, Jamie Iles wrote:
> --- a/drivers/mtd/nand/gpio.c
> +++ b/drivers/mtd/nand/gpio.c
>
> +static const struct of_device_id gpio_nand_id_table[] = {
> + { .compatible = "gpio-nand" },
> + {}
> +};
> +MODULE_DEVICE_TABLE(of, gpio_nand_id_table);
all this new logic is missing CONFIG_OF ifdef protection for all the
ports not using device trees
-mike
_______________________________________________
devicetree-discuss mailing list
devicetree-discuss@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/devicetree-discuss
prev parent reply other threads:[~2011-07-28 0:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-27 14:03 [PATCH] mtd: gpio-nand: add device tree bindings Jamie Iles
[not found] ` <1311775410-5158-1-git-send-email-jamie-wmLquQDDieKakBO8gow8eQ@public.gmane.org>
2011-07-27 19:45 ` Scott Wood
[not found] ` <20110727144501.7e0420cd-1MYqz8GpK7RekFaExTCHk1jVikpgYyvb5NbjCUgZEJk@public.gmane.org>
2011-07-27 19:55 ` Jamie Iles
2011-07-27 21:01 ` Scott Wood
2011-07-28 0:06 ` Mike Frysinger
2011-07-28 0:07 ` Mike Frysinger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMjpGUdPaAi=8ktisse0W_qWWPvaPXyCf9RgKAV02YzD7cn1aA@mail.gmail.com' \
--to=vapier.adi-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=Artem.Bityutskiy-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=jamie-wmLquQDDieKakBO8gow8eQ@public.gmane.org \
--cc=linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).