From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f182.google.com (mail-lj1-f182.google.com [209.85.208.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1894359B77 for ; Sun, 11 Feb 2024 17:03:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707671040; cv=none; b=ldPb+XZAQWVXnYRsAPM/N1MqY7yPlZl7R2Isy3hz26Cb9GZb8QQBVK88/cbkh6vS+LuMeIlHpSZjAFwhISrWUs2vOpyp667zUSXPFykrom8XnehmEAAcpOxYRdaAOF2QCzw553t2HMWD01ZElPjd8JzKX9/bwou/CzxDlEZuZYA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707671040; c=relaxed/simple; bh=EaYBvPTL5340RMBzf1X/yXQwMXrnL0mGGyjOfVqJ/8g=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=fmXohn2enZr3HTsFqF57W/lpnjuIaG1i0QR3p/w6ROZHIOC6w9lPX5IOBB6136uik7R6cGSNzrQanuEHn32DNMpQa9cERTQdcppWnewio/dWTKFA7di1BE5TGxqEKrjJg0U8mSkwsKIr5rkMKS4m0SagtQDnHyQ+FnWPE2TKWAc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=JwXCvwKn; arc=none smtp.client-ip=209.85.208.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="JwXCvwKn" Received: by mail-lj1-f182.google.com with SMTP id 38308e7fff4ca-2d09faadba5so32408711fa.1 for ; Sun, 11 Feb 2024 09:03:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1707671035; x=1708275835; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=l6r6uQO0yvhxMh2sO8XzcbE67h9/FEe/yCCnsnSaz5I=; b=JwXCvwKn2QtzpDo0Z+YLgAGxSUdQJTWY31TIJW717+pfEB1ejLLqIBF1MWPMOhtx2e HS3UsdFRljcimS6AdNwW8E+8AkB4JmsygI1Fi6DF78yoHh5YaMjuWIQCUv9Dwicr6h+i wV0gXIU2YwKSAaYAdJWYtCdn72KLuMXVvZXBXgunmFUp59QJDhTm1fPxpg6hhYsliaVd VZFZWiZFoH/DWaD3UGIrXlJQkB0h3LRZSuuFdnY0cDhYuWJXKEu4BUFLDBgkj5kQTeVv MSgGsQRGlSaDl2fEGr7scJGKDsEfxECYJhPCxGfPKTVi5H4jxhDEwOWw+BCVPbeeEiy+ 6sNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707671035; x=1708275835; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=l6r6uQO0yvhxMh2sO8XzcbE67h9/FEe/yCCnsnSaz5I=; b=Piwcv7uuAF9PsuHYOjqrobprQoVsaav6NnhfgiwyVW3xtpFuMh/bVCm7Gz955ERs2W tblKtqZZ0hvNMQpi4KRztSPlUTfUx/+u6ltO/h2NKcPakQ4OmmHOJKXzOJPVa2NouNVQ L8U/to4syj6VhwqEgBHhWAaw9GrAQPgo2W/ULL9tI5oQWm1xJRd+JNicMcDunNLFSLv0 otJ6tDTGWfgWbGjIrCuZYm41OPXX8jJm56BWbouYRPn75lAmi9aZ4Nz04E87toam8mzA RVvINIl62vZ6oaT32aWVFKyGhAG0O2dAcSBK+ywHspGDqHIC+BmN15qGYVA2FPx1j9ZE UNsA== X-Forwarded-Encrypted: i=1; AJvYcCWc+sN/QMRdA+y8DPHpNZPDX29cXNUx4I58A6maXheWtL/OEMj/JDElH380ibzl2jKMubbWYuzUErrcJIc4c93kONMBIWwLTmKQUQ== X-Gm-Message-State: AOJu0YxsV/t7HaIh3/XMVSfoVuVlaX8cWf7nTNGhiJwF9Se5j3F5uC8r LCmjJCv2+ZWbKNmEUsOOLNhl7laE7wPd5Qs+wzdEIz0IgjnHci5/tNb66R2TotN35lDbxe74snk xKbwFkeubgf894IqAxqZpT8Gd0Lj2miMt7c4z0A== X-Google-Smtp-Source: AGHT+IFeDYfZDJITP4t95JWsaHGGTqFSftILCragwFVbCOlKyMcp3OUXURqrXAodacWjBBT74IYU2gIgeUHSZyAxt+8= X-Received: by 2002:a05:651c:89:b0:2d0:a21b:c62c with SMTP id 9-20020a05651c008900b002d0a21bc62cmr2510616ljq.52.1707671034856; Sun, 11 Feb 2024 09:03:54 -0800 (PST) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240206-ad7944-mainline-v1-0-bf115fa9474f@baylibre.com> <20240206-ad7944-mainline-v1-2-bf115fa9474f@baylibre.com> <20240210174729.7c6cb953@jic23-huawei> In-Reply-To: <20240210174729.7c6cb953@jic23-huawei> From: David Lechner Date: Sun, 11 Feb 2024 11:03:43 -0600 Message-ID: Subject: Re: [PATCH 2/2] iio: adc: ad7944: add driver for AD7944/AD7985/AD7986 To: Jonathan Cameron Cc: linux-iio@vger.kernel.org, Michael Hennerich , Rob Herring , Krzysztof Kozlowski , Conor Dooley , =?UTF-8?B?TnVubyBTw6E=?= , Liam Girdwood , Mark Brown , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, Feb 10, 2024 at 11:47=E2=80=AFAM Jonathan Cameron wrote: > > On Tue, 6 Feb 2024 11:26:00 -0600 > David Lechner wrote: > > > This adds a driver for the Analog Devices Inc. AD7944, AD7985, and > > AD7986 ADCs. These are a family of pin-compatible ADCs that can sample > > at rates up to 2.5 MSPS. > > > > The initial driver adds support for sampling at lower rates using the > > usual IIO triggered buffer and can handle all 3 possible reference > > voltage configurations. > > > > Signed-off-by: David Lechner > > > The one thing in here that will probably bite if this gets much use of > different boards is the use of non multiple of 8 word sizes. > > Often we can get away with padding those with trailing clocks. > Any idea if that is safe here? We can probably get away with it on these chips. The ultimate goal here, though, is to get these chips working a max sample rate which only has a few 10s of nanoseconds of wiggle room between SPI transfers. So I would rather have a bit more play in the timing than try to support generic SPI controllers.