From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f179.google.com (mail-lj1-f179.google.com [209.85.208.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C7DBD2C3248 for ; Wed, 1 Oct 2025 11:19:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759317547; cv=none; b=JdoCX7ISJeevSbZGQ+j76QzgSvxKH07++8WBeKUEcck9lUfnFjP4qrFqpj2nwdhW+zygM0Mo8eb1t+x8qjKMkEAycIQ3Xhpkf5r0G+PiAxxC231j0HSMXfcukgxoiab+CMlnVRNTWoEFt4aQudFMxugjDJp/VtvEPwe0hXDM1As= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759317547; c=relaxed/simple; bh=1HFBdPH4nuIY6H6y/ZojnkMEpQ1m1rGMA+QhLTxwZMs=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=mGB9uX15jUOhn4SGn3vM/vk06omx2Jff/zTtBqBkrhqYJHxleCKoE4c/GW1UCdI1ORuUS8yQ+/TasZaFWIj8vugYUAfyZGOIFmqCYTEvoo73wSt3MyRwdaRgs1vmGcc9yg7kASOws7BiraItE9MwVtx2fosL8RWUwV5qE0OOl2M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=Pz8/tY2W; arc=none smtp.client-ip=209.85.208.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="Pz8/tY2W" Received: by mail-lj1-f179.google.com with SMTP id 38308e7fff4ca-36527ac0750so66854671fa.3 for ; Wed, 01 Oct 2025 04:19:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1759317543; x=1759922343; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=LzALmU9leCk7b6gYpUMB7NSJN6+Tl6di9Bbt+pXEhZg=; b=Pz8/tY2WHeO3OFRM/UQGLGE7Ilxule3+QElQwLZQR0zfOx3uo4jw4ogCA9oOQ1Iggp GMCon4idiaqvEu2nXW71zOTkVYFCyBff+W33OovwPlR4tUYwc2X7R0GLI15lBV+r/n3E 8+JC23Xc1cuDdF2y8olns7eJvGjG4uyGCC03MZXvt3zULG346ic9PzTBZgwE05OEvD5o tV9Ed7FYneS8cvexWhyvXGgf0Obd9bE6yvxD+Ba72dv163ktRMMUCDkUBZBp0b0sdWlY 1EmEr4trX53xFV5Q5hGQVib+85Q0BFBERK4Xk4LVPf/YAZGCJAjuGn/fBYbmIKJiAmVG N70Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759317543; x=1759922343; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LzALmU9leCk7b6gYpUMB7NSJN6+Tl6di9Bbt+pXEhZg=; b=dOtL+pP9VhFl60PgKC7oUKz5optwvz8W3Q4/kJjAceajddPGnPc6tvtdwp3NPSxNts 7vW/sOhu2Kc4mIbSAhgTNMU1R83Z9zUXm4vr0o3uLdUHqIXKUwJY2Djz44vtVwQJ/owz KumouYjmVorDLBjT1YPzRTb1Pw5ByVVvMeeJq7YE4XS1LpwZFEH8C7+mlVce7rsb8a41 2j/eI0AcjnaKBZRwC75ucAAnAYiTGZ6wvXN4EO05Pux/yGZHNVDFGFjgpiQdrTQXNQe0 fEbin8kshgESvUXS56/yFw+GJMxUyp9lUnMLy5f+5/LbHeKw7E7NuDykr84pIuK6zp7b OLeQ== X-Forwarded-Encrypted: i=1; AJvYcCXOlRAu9GdtRuuEePUm95DlJt7MWK1DOPeXV3Q7xaKO3BeskXPwlzBsRQjY6XJSuc1qSUde17bUhVOT@vger.kernel.org X-Gm-Message-State: AOJu0YxC9sm9BOywyzFo+nqPSop0kxj281NB0jrrKIxSqUF427gjkktG SqXkFbXP9QVFNUE0sIyTlk+7iOXRgXu8OlsSkDWaGZW/Au7S833v/C15cOP9zfWWAgkH4JgAVqn m3Ftgvmp9Sp4gt6UQjYI8OEXDl8yO629flIn3BTEnvg== X-Gm-Gg: ASbGncuIh0zcNlezNst26y/7PX7aMG8eyHN6vIJgZm3Hd7Ojv/RjMTdo5NV7mc7cQmO LJ4Who8CMW7GA3SKAyjDeRNP3pGugA30qaoLPpM62q7tVNxOlgL3QL1kiAnYHfhKii22xr1NtWm 7+lybAse4u41UxFM7Q/Zhcz/36OTDDZd9E+OXbbnrNMqQ0Gjx6g9nqpLqeNBamZ5zMFjNj9Yzjg YqD1IgZt34lXIglBYrFqvD1DktmDVk= X-Google-Smtp-Source: AGHT+IEjhWzPMlj17Uy7qd2LicirAASApXwhCe4VbKO72/os2UztLtK5uJY9uTbzBv/l7QF9CdPnWL/3cGWP9kZX9p4= X-Received: by 2002:a05:651c:1988:b0:373:a537:69f6 with SMTP id 38308e7fff4ca-373a74c163dmr11755181fa.33.1759317542967; Wed, 01 Oct 2025 04:19:02 -0700 (PDT) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20250925-ltm8054-driver-v2-0-bb61a401a0dc@bootlin.com> <5331035.LvFx2qVVIh@fw-rgant> <20250927-spoon-yearning-c1a8df796173@spud> <5926760.DvuYhMxLoT@fw-rgant> In-Reply-To: <5926760.DvuYhMxLoT@fw-rgant> From: David Lechner Date: Wed, 1 Oct 2025 13:18:51 +0200 X-Gm-Features: AS18NWBS8-yzFEbPE539-aBIzutpc2mebsewYlTX4Q1OfyH7iUd46IqQowJM_Kg Message-ID: Subject: Re: [PATCH v2 1/5] regulator: dt-bindings: Add Linear Technology LTM8054 regulator To: Romain Gantois Cc: Conor Dooley , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jonathan Cameron , =?UTF-8?B?TnVubyBTw6E=?= , Andy Shevchenko , Hans de Goede , Thomas Petazzoni , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-iio@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Oct 1, 2025 at 9:12=E2=80=AFAM Romain Gantois wrote: > > On Sunday, 28 September 2025 00:31:05 CEST Conor Dooley wrote: > ... > > > > > > > > > + lltc,fb-voltage-divider: > > > > Why does this property have a ?linear? vendor prefix? > > > > Shouldn't it be adi to match the other property and compatible? > > > > > > This component was originally from Linear Technology, before it was > > > acquired by Analog Devices. The new properties and compatibles have t= he > > > Analog Devices prefix, but the "fb-voltage-divider" property is alrea= dy > > > used by the LTC3676 and LTC3589 regulators, so I left the Linear > > > Technology prefix for this one to avoid introducing a new property ju= st > > > to specify a vendor prefix change. > > > > > > I don't have a strong opinion about this though. > > > > Do they share the same driver? > > They do not. However, they use it in the exact same way, and I would've > liked to factor out the handling of this property in a future patch. This > would also make it easier to handle other types of feedback pin circuits > and have a generic binding for "regulators using a feedback pin connected > to some kind of analog circuit". > > For example: > > Vout----+ > | > | > +++ > | | > | | Rtop > | | > +++ > | > | > FB ----+ > | > +--+--+ > | | | > | | |CCS > +--v--+ > | > | > -+- > - > > This is all speculation at this point though, so I don't mind changing th= e > property to "adi,fb-voltage-divider" and handling the different compatibl= es > when it comes to it. > Could we just make it `fb-voltage-divider-ohms`? The -ohms suffix makes it match the standard property-units suffix which already has the uint32-array type. There are a couple of bindings that have `vout-voltage-divider` without a vendor prefix, so it sounds like this pattern is considered somewhat of a standard property already. But I think it would be better with the -ohms suffix. For example, there is already `gw,voltage-divider-ohms` as well. But there are so many similar properties without the suffix, it is kind of the defacto standard already, so might be better to stick with that rather than making it even more different variants than there already are.