devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Lechner <dlechner@baylibre.com>
To: nuno.sa@analog.com
Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	 Dragos Bogdan <dragos.bogdan@analog.com>,
	Lars-Peter Clausen <lars@metafoo.de>,
	 Michael Hennerich <Michael.Hennerich@analog.com>,
	Jonathan Cameron <jic23@kernel.org>,
	 Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	 Conor Dooley <conor+dt@kernel.org>,
	Olivier Moysan <olivier.moysan@foss.st.com>
Subject: Re: [PATCH v3 07/10] dt-bindings: iio: dac: add docs for AD9739A
Date: Fri, 12 Apr 2024 18:47:33 -0500	[thread overview]
Message-ID: <CAMknhBHZRfvNtkbpWbi7tTXYa_rgRk+Q4z5MOd0O61FeEqBQnQ@mail.gmail.com> (raw)
In-Reply-To: <20240412-iio-backend-axi-dac-v3-7-3e9d4c5201fb@analog.com>

On Fri, Apr 12, 2024 at 8:36 AM Nuno Sa via B4 Relay
<devnull+nuno.sa.analog.com@kernel.org> wrote:
>
> From: Nuno Sa <nuno.sa@analog.com>
>

...

> +  adi,full-scale-microamp:
> +    description: This property represents the DAC full scale current.

The description could be improved by saying what determines the value
that need to be entered here. (Also wondering if this is not something
that should be set at runtime using the _scale attribute instead.)

> +    minimum: 8700
> +    maximum: 31700

Missing a default value since this is not a required property?

> +
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - io-backends
> +  - vdd-3p3-supply
> +  - vdd-supply
> +  - vdda-supply
> +  - vddc-supply
> +

  reply	other threads:[~2024-04-12 23:47 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-12 13:36 [PATCH v3 00/10] iio: dac: support IIO backends on the output direction Nuno Sa via B4 Relay
2024-04-12 13:36 ` [PATCH v3 01/10] iio: buffer-dma: add iio_dmaengine_buffer_setup() Nuno Sa via B4 Relay
2024-04-12 13:36 ` [PATCH v3 02/10] iio: buffer-dma: Rename iio_dma_buffer_data_available() Nuno Sa via B4 Relay
2024-04-12 13:36 ` [PATCH v3 03/10] iio: buffer-dma: Enable buffer write support Nuno Sa via B4 Relay
2024-04-12 13:36 ` [PATCH v3 04/10] iio: buffer-dmaengine: Support specifying buffer direction Nuno Sa via B4 Relay
2024-04-12 13:36 ` [PATCH v3 05/10] iio: buffer-dmaengine: Enable write support Nuno Sa via B4 Relay
2024-04-12 13:36 ` [PATCH v3 06/10] dt-bindings: iio: dac: add docs for AXI DAC IP Nuno Sa via B4 Relay
2024-04-12 13:36 ` [PATCH v3 07/10] dt-bindings: iio: dac: add docs for AD9739A Nuno Sa via B4 Relay
2024-04-12 23:47   ` David Lechner [this message]
2024-04-15 12:25     ` Nuno Sá
2024-04-15 13:51       ` David Lechner
2024-04-12 13:36 ` [PATCH v3 08/10] iio: backend: add new functionality Nuno Sa via B4 Relay
2024-04-12 13:36 ` [PATCH v3 09/10] iio: dac: add support for AXI DAC IP core Nuno Sa via B4 Relay
2024-04-12 13:36 ` [PATCH v3 10/10] iio: dac: support the ad9739a RF DAC Nuno Sa via B4 Relay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMknhBHZRfvNtkbpWbi7tTXYa_rgRk+Q4z5MOd0O61FeEqBQnQ@mail.gmail.com \
    --to=dlechner@baylibre.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dragos.bogdan@analog.com \
    --cc=jic23@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=olivier.moysan@foss.st.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).