From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f180.google.com (mail-lj1-f180.google.com [209.85.208.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B396318030 for ; Fri, 10 May 2024 17:30:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715362260; cv=none; b=gYyIKdzbzZztOOQ6bQyRmm2L4Pgxo0iywGaswJR1K6LroBfA8MH2cKD32e9eLM46DNnVXcKSbXmf9FC4ajCW5PPmh+/7M7AjghXgSx8UmemZQkPBrJoGT5to3jgQEEuvUKEBeO6/H4gYs1BTeHsYh28VqkA6k56+//cawH2mZJc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715362260; c=relaxed/simple; bh=XqrCfizCQyF2KKw0/WdajRp4//EIlKPiWT2wjme1sQg=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=p7EsSndsBFkFLEwAuZ1wdQeLejjeaQGTAyjsBGR77Fz3RcJ3fnDql2IWWlwGIxZFW3tvNUESig/CUb5yM3MASAdRhxHbiz2qszRVWh/yZTg4OuEQLIAW7vX/URSVSdPzP3qroQVgh4DSoC4mcKHOgpMZaF1md2X2z/C2s3qqOBs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=MKMFiRVN; arc=none smtp.client-ip=209.85.208.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="MKMFiRVN" Received: by mail-lj1-f180.google.com with SMTP id 38308e7fff4ca-2e2b468ea12so19803991fa.1 for ; Fri, 10 May 2024 10:30:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1715362257; x=1715967057; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Occ+O3gQaZXJydVURkKGuh31GRbkBBYoYZRwqv9bgzU=; b=MKMFiRVNAcyzIJGC2QnIM1QG7lmYziPooPnFU2OAmhysGLxVjbf6sjZ1sWW+6g/UN1 5V9yI6E6A1f/TlYlKrW5wokEQly/x2Dx5a6tHyut5iMoGruVjkmG4L60vnTmCNLBd6Fk jpy6tlsln4szy9nwGBJx/AEQeZheYLJ4f+Dys+3XMr7eJAf29IU/hGopikjjI8fuFJRf M/udYs83RH17iIGCVrrsAD/oPPA41c9PmaeUaU20hEGjFLmDoA3nOSBNiFwjui80je4M LFYiZtgrgBm/tMHG5R8lyJT/RL/uQ8VDPpj500UNYrM4Woj2/0bPrlD7IEGHjri4SGO3 n4qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715362257; x=1715967057; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Occ+O3gQaZXJydVURkKGuh31GRbkBBYoYZRwqv9bgzU=; b=Dfrb9hXzmnSopIMn+FWwYUiQSEi7JzTrSUAfakVXmCjFA47FziFCmIkktSAKidgZ2+ uxniNcEcXivq/kS3fHTybrTemRrMrW0VxCWG3LDbxB/6asMNUyNrf/1L2COmw7MOauZu yrQXltavH7GBDKJY6zO5SDI9U3SUNxgNnI/hcNtHAxOFkv+zpKKgeAbx5azafgCZKmTj 3RE3hdWjBVRddNIGpjOq/lnDHQ3I6SMF/a3IkpA0COzS8MwgOuRCHTnGhZdX669VbzEt 8QjYyVNOtp6YSEvOCxa6TexcqjPzdMxDTLx2Bo2NjYtFpWLVQV12tFKhcEwnuFx5LH8G yFfQ== X-Forwarded-Encrypted: i=1; AJvYcCU8oysHu6uI2XDyDhnSj0wxbgKTsU9/5JE18zbw4FfHZR8uoId+UT3hiIC0+++t6ZdRMqLPdafjomSrGHBPdAIsR+H0HZuL9a55OA== X-Gm-Message-State: AOJu0Yzgo7eXF1y1lxvTo3JN10Dsy+43yejT4zkXNoTfX3qELBaOCgIY v2wiHzOGCJcq3dQ1doYU2/yNS9ffSbV7s1e4dvABCZsGhYVHygdO/9bo5F0aYVAkD1DeHEOltth Mmx3fficKm3zVz2YpqPQ4uW1oCkUUku+x2NcDLg== X-Google-Smtp-Source: AGHT+IEth9+yiMEnT0dyi6WAr5+H1hY9rOJ8pfNbE7ESLJAECOzbNoW9ASNpZO6jpztELqcXrloxCo8atIKPBbyxWz8= X-Received: by 2002:a05:651c:c7:b0:2db:2385:d024 with SMTP id 38308e7fff4ca-2e4b1ad9c2amr17614851fa.26.1715362256957; Fri, 10 May 2024 10:30:56 -0700 (PDT) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240510064053.278257-1-Mariel.Tinaco@analog.com> In-Reply-To: <20240510064053.278257-1-Mariel.Tinaco@analog.com> From: David Lechner Date: Fri, 10 May 2024 12:30:46 -0500 Message-ID: Subject: Re: [PATCH 0/2] add AD8460 DAC driver To: Mariel Tinaco Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Jonathan Cameron , Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Liam Girdwood , Mark Brown , Michael Hennerich , Marcelo Schmitt , Dimitri Fedrau , Guenter Roeck Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, May 10, 2024 at 1:42=E2=80=AFAM Mariel Tinaco wrote: > > The AD8460 is a 14-bit, high power +-40V 1A, high-speed DAC, > with dual digital input modes, programmable supply current and > fault monitoring and protection settings for output current, > output voltage and junction temperature. > > The fault monitoring and shutdown protection features were > supported in the earlier versions of the IIO driver but was > scrapped due to uncertainties if the functionalities belong to > the IIO driver. However, it would be best to implement it for > the device's quality of life. I'd like to know if it's better > suited as a stand-alone HWMON driver. > > The following are the configurable and readable parameters > through SPI that could be implemented on the HWMON driver: > * An enable bit to arm/protect the device on overcurrent, > overvoltage or overtemperature events. The device is shut down > upon detection. > * A configurable range/threshold for voltage, current and > temperature that raises alarm when exceeded while the device is > armed. > * Flags that can be polled to raise alarm upon detection of > overcurrent, overvoltage or overtemperature events, and apply > additional protective measures. > * Programmable quiescent current (optional) > * Thermal monitoring is done by measuring voltage on TMP pin > (unlikely to be included) > Adding myself to the cc: here since I'm interested to see what Jonathan (or anyone else) has to say about the fault monitoring.