From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59B3FC2BB9A for ; Thu, 17 Dec 2020 17:38:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 33F92235DD for ; Thu, 17 Dec 2020 17:38:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726291AbgLQRiL (ORCPT ); Thu, 17 Dec 2020 12:38:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37270 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729668AbgLQRiL (ORCPT ); Thu, 17 Dec 2020 12:38:11 -0500 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A07AFC0617A7 for ; Thu, 17 Dec 2020 09:37:30 -0800 (PST) Received: by mail-ej1-x632.google.com with SMTP id lt17so39092916ejb.3 for ; Thu, 17 Dec 2020 09:37:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fLF6P+O62fQPSTng8hy4I8KBrSJzO2q6Xzt7+Jwjbu0=; b=Q/35/lbhLWd7jUP9iWj7T78K4JA+OJ44nAbfF31fVN6QvO0ng+xEqQQgcKVl0BFHpi Z076P1aqJldE8WHi0zDHBW3AyHaJI3WnASBCuK3UuTaprL8pmN75uX2V2SuE65pJcVhF LkrJeVoLrk+6qdMsXWATBpuoAu6zAo7Xl0wCs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fLF6P+O62fQPSTng8hy4I8KBrSJzO2q6Xzt7+Jwjbu0=; b=bhCRvCRidMvsMFkcq2SmorQLWYlmofJJixjQuapDVseDllc9rAlgmAblCro7RUV9IP djraULZMz6K/Rrk9j4qQK6VYSuA4SBOzznHY0cN5T/pC77zyluQFkKZGvHN0OeNsypjY JxueYRdKkIQGVLDJ/nrq5S3mI7ZkQyBIgiQrA/FJtp9cEAYZBYQ0qNQezfrjlFxEFbqT OfeCdvAm+Ayca1jnpshXJvgL1WmxZrtGuD3VSsXKE6VOjBgvKa43BQiBQL77Ewg9smpm He+B1VXLlJ5SC3WOd0ORxpQzstZmhBa/jENitsG2DfpyxdDJaBiA8Y2i+xcq15w9k+bj qf5g== X-Gm-Message-State: AOAM5339mIlw44h/mPGuUh652Tp8Xbn1kM/PvYtVocSz4ftQeAn7Prpv grw4hptJJRLowQaCsjqE9qsqCczunp78wquVqmWBjA== X-Google-Smtp-Source: ABdhPJyiLapDbFryDYgU3FGxGsnjDcJSPA4Y00bhcDs6zSyPtOYvkH6TskhdgNAa8vH9+dJF3a94dkgm9iNC0Vv5t78= X-Received: by 2002:a17:906:2707:: with SMTP id z7mr89185ejc.418.1608226649339; Thu, 17 Dec 2020 09:37:29 -0800 (PST) MIME-Version: 1.0 References: <20201215235639.31516-1-adrien.grassein@gmail.com> <20201215235639.31516-4-adrien.grassein@gmail.com> In-Reply-To: <20201215235639.31516-4-adrien.grassein@gmail.com> From: Jagan Teki Date: Thu, 17 Dec 2020 23:07:18 +0530 Message-ID: Subject: Re: [PATCH v2 3/7] regulator: dt-bindings: pf8x00: fix nxp,phase-shift doc To: Adrien Grassein Cc: Mark Brown , Liam Girdwood , Rob Herring , linux-kernel , devicetree , Troy Kisky Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, Dec 16, 2020 at 5:27 AM Adrien Grassein wrote: > > nxp,phase-shift is an enum so use enum format to describe it. > Minimum and maximum values are also wrong. > > Signed-off-by: Adrien Grassein > --- > .../bindings/regulator/nxp,pf8x00-regulator.yaml | 16 ++++------------ > 1 file changed, 4 insertions(+), 12 deletions(-) > > diff --git a/Documentation/devicetree/bindings/regulator/nxp,pf8x00-regulator.yaml b/Documentation/devicetree/bindings/regulator/nxp,pf8x00-regulator.yaml > index 913532d0532e..1da724c6e2ba 100644 > --- a/Documentation/devicetree/bindings/regulator/nxp,pf8x00-regulator.yaml > +++ b/Documentation/devicetree/bindings/regulator/nxp,pf8x00-regulator.yaml > @@ -60,21 +60,13 @@ properties: > > nxp,phase-shift: > $ref: "/schemas/types.yaml#/definitions/uint32" > - minimum: 45 > - maximum: 0 > + minimum: 0 > + maximum: 315 > + default: 0 > + enum: [ 0, 45, 90, 135, 180, 225, 270, 315 ] On Wed, Dec 16, 2020 at 5:27 AM Adrien Grassein wrote: > > pf8x00 module build was not documented. > > Signed-off-by: Adrien Grassein > --- > drivers/regulator/Kconfig | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig > index 53fa84f4d1e1..9c6508e99fdd 100644 > --- a/drivers/regulator/Kconfig > +++ b/drivers/regulator/Kconfig > @@ -828,6 +828,10 @@ config REGULATOR_PF8X00 > Say y here to support the regulators found on the NXP > PF8100/PF8121A/PF8200 PMIC. > > + Say M here if you want to support for the regulators found > + on the NXP PF8100/PF8121A/PF8200 PMIC. The module will be named > + "pf8x00-regulator". Reviewed-by: Jagan Teki