From: Jagan Teki <jagan@amarulasolutions.com>
To: Chen-Yu Tsai <wens@csie.org>
Cc: Maxime Ripard <maxime.ripard@bootlin.com>,
Rob Herring <robh+dt@kernel.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-input@vger.kernel.org,
devicetree <devicetree@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Lee Jones <lee.jones@linaro.org>,
linux-sunxi <linux-sunxi@googlegroups.com>
Subject: Re: [PATCH 5/9] dt-bindings: input: touchscreen: goodix: Document vcc-supply property
Date: Thu, 6 Dec 2018 01:26:42 +0530 [thread overview]
Message-ID: <CAMty3ZAd9eZRkBM2Pitp_B+kVLsGjufL6ALMCJ=f7iUL=7SfsQ@mail.gmail.com> (raw)
In-Reply-To: <CAGb2v67ocaKL05yt68F+juBeAq8BRQ49mB4uoHWijGRy8duamw@mail.gmail.com>
On Mon, Dec 3, 2018 at 4:11 PM Chen-Yu Tsai <wens@csie.org> wrote:
>
> On Mon, Dec 3, 2018 at 6:16 PM Jagan Teki <jagan@amarulasolutions.com> wrote:
> >
> > vcc-supply property is need for some Goodix CTP controller like GT5663
> > where 3.3V external pull-up regulator connected via controller VCC pin.
>
> "External pull-up regulator" sounds fishy. Chips have power supply
> pins, either combined, or separate rails for analog, digital, and I/O.
> For Goodix chips these are AVDD28, AVDD22, DVDD12, amd VDDIO. The name
> and description you provide match none of these.
We have vcc pin in the connector to supply vcc-ctp, but indeed it is
AVDD28 supply as per the reference schematic design[1] Page 23. Host
interface has AVDD pin which is connected to ADVDD28 on goodix chip,
so I can name this as avdd28-supply. is that OK?
[1] https://www.crystalfontz.com/controllers/GOODIX/GT5663/459/
next prev parent reply other threads:[~2018-12-05 19:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-03 10:15 [PATCH 1/9] dt-bindings: gpio-axp209: Add AXP803 GPIOs compatible (w/ AXP813 fallback) Jagan Teki
[not found] ` <20181203101547.16835-1-jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>
2018-12-03 10:15 ` [PATCH 2/9] mfd: axp20x: Add GPIO/pinctrl support for AXP803 Jagan Teki
2018-12-03 10:15 ` [PATCH 3/9] arm64: allwinner: dts: axp803: Add GPIO DT node Jagan Teki
2018-12-03 10:15 ` [PATCH 4/9] arm64: allwinner: dts: axp803: Set GPIO0/1 pinmux for LD0s Jagan Teki
2018-12-03 10:15 ` [PATCH 5/9] dt-bindings: input: touchscreen: goodix: Document vcc-supply property Jagan Teki
[not found] ` <20181203101547.16835-5-jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>
2018-12-03 10:41 ` Chen-Yu Tsai
2018-12-05 19:56 ` Jagan Teki [this message]
[not found] ` <CAMty3ZAd9eZRkBM2Pitp_B+kVLsGjufL6ALMCJ=f7iUL=7SfsQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-12-06 3:01 ` Chen-Yu Tsai
2018-12-03 10:15 ` [PATCH 6/9] Input: goodix - Add vcc-supply regulator support Jagan Teki
[not found] ` <20181203101547.16835-6-jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>
2018-12-03 19:13 ` Dmitry Torokhov
2018-12-03 10:15 ` [PATCH 7/9] dt-bindings: input: touchscreen: goodix: Add GT5663 compatible Jagan Teki
[not found] ` <20181203101547.16835-7-jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>
2018-12-19 17:15 ` Rob Herring
2018-12-03 10:15 ` [PATCH 8/9] Input: goodix - Add GT5663 CTP support Jagan Teki
2018-12-03 10:15 ` [PATCH 9/9] arm64: dts: allwinner: a64-amarula-relic: Add GT5663 CTP node Jagan Teki
2018-12-03 10:32 ` [PATCH 1/9] dt-bindings: gpio-axp209: Add AXP803 GPIOs compatible (w/ AXP813 fallback) Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMty3ZAd9eZRkBM2Pitp_B+kVLsGjufL6ALMCJ=f7iUL=7SfsQ@mail.gmail.com' \
--to=jagan@amarulasolutions.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=maxime.ripard@bootlin.com \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).