From: Jagan Teki <jagan@amarulasolutions.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
Li Yang <leoyang.li@nxp.com>, Fabio Estevam <festevam@gmail.com>,
devicetree <devicetree@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
NXP Linux Team <linux-imx@nxp.com>,
linux-amarula <linux-amarula@amarulasolutions.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>
Subject: Re: [PATCH v2 2/6] dt-bindings: arm: fsl: Add Engicam i.Core MX8M Mini C.TOUCH 2.0
Date: Tue, 22 Dec 2020 23:58:43 +0530 [thread overview]
Message-ID: <CAMty3ZCzB87_NGTRRvugcurSHWikcaCvKPuBBJJ1ocmqDQ8wzw@mail.gmail.com> (raw)
In-Reply-To: <CAMty3ZD8JAp3UGuOS2zTsOZ5QcFE6_Ba_UjtmhKpD3R3qra5jg@mail.gmail.com>
On Mon, Dec 21, 2020 at 8:17 PM Jagan Teki <jagan@amarulasolutions.com> wrote:
>
> On Mon, Dec 21, 2020 at 8:12 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> >
> > On Mon, Dec 21, 2020 at 08:09:47PM +0530, Jagan Teki wrote:
> > > On Mon, Dec 21, 2020 at 7:35 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> > > >
> > > > On Mon, Dec 21, 2020 at 07:29:22PM +0530, Jagan Teki wrote:
> > > > > On Mon, Dec 21, 2020 at 7:16 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> > > > > >
> > > > > > On Mon, Dec 21, 2020 at 05:01:47PM +0530, Jagan Teki wrote:
> > > > > > > i.Core MX8M Mini is an EDIMM SoM based on NXP i.MX8M Mini from Engicam.
> > > > > > >
> > > > > > > C.TOUCH 2.0 is a general purpose carrier board with capacitive
> > > > > > > touch interface support.
> > > > > > >
> > > > > > > i.Core MX8M Mini needs to mount on top of this Carrier board for
> > > > > > > creating complete i.Core MX8M Mini C.TOUCH 2.0 board.
> > > > > > >
> > > > > > > Add bindings for it.
> > > > > > >
> > > > > > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> > > > > > > ---
> > > > > > > Changes for v2:
> > > > > > > - updated commit message
> > > > > > >
> > > > > > > Documentation/devicetree/bindings/arm/fsl.yaml | 2 ++
> > > > > > > 1 file changed, 2 insertions(+)
> > > > > > >
> > > > > > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> > > > > > > index 67980dcef66d..e653e0a43016 100644
> > > > > > > --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> > > > > > > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> > > > > > > @@ -667,6 +667,8 @@ properties:
> > > > > > > items:
> > > > > > > - enum:
> > > > > > > - beacon,imx8mm-beacon-kit # i.MX8MM Beacon Development Kit
> > > > > > > + - engicam,icore-mx8mm # i.MX8MM Engicam i.Core MX8M Mini SOM
> > > > > > > + - engicam,icore-mx8mm-ctouch2 # i.MX8MM Engicam i.Core MX8M Mini C.TOUCH 2.0
> > > > > >
> > > > > > Please test your DTS against new schema with dtbs_check. This won't
> > > > > > match.
> > > > >
> > > > > Sorry, not sure I understand clearly here.
> > > > >
> > > > > This the dts file ie used matched compatible.
> > > > > compatible = "engicam,icore-mx8mm-ctouch2", "engicam,icore-mx8mm",
> > > > > "fsl,imx8mm";
> > > > >
> > > > > I did build the dtbs_check without showing any issues like,
> > > > >
> > > > > $ make ARCH=arm64 dtbs_check
> > > > > ...
> > > > >
> > > > > From schema: /w/dt-schema/dt-schema/dtschema/schemas/property-units.yaml
> > > > > DTC arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2.dtb
> > > > > DTC arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2-of10.dtb
> > > > > DTC arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dtb
> > > > > ..
> > > > >
> > > > > Can you let me know what I missed here?
> > > >
> > > > You pasted here output of validating with property-units.yaml (or
> > > > something else), not the schema which you changed. If you want to limit
> > > > the tests, use DT_SCHEMA_FILES.
> > > >
> > > > I mentioned about exactly the same problem in yout previous v1
> > > > at patch #5. No changes here stil.
> > >
> > > Yes, I usually did that check before posting. Please check the build
> > > log below and fsl.yaml binding is fine to build.
> > >
> > > # make dt_binding_check DT_SCHEMA_FILES=arm/fsl.yaml
> >
> > 1. Wrong path to schema file,
> > 2. Bindings pass, they are not a problem. You were running dtbs_check,
> > right?
>
> But kbuild is building the fsl.yaml I did verify with by adding some
> wrong character in the file, it is showing build issues.
>
> Please check the clean log.
>
> # make mrproper
> CLEAN Documentation/devicetree/bindings
> CLEAN scripts/basic
> CLEAN scripts/dtc
> # make dt_binding_check
> DT_SCHEMA_FILES=Documentation/devicetree/bindings/arm/fsl.yaml
> HOSTCC scripts/basic/fixdep
> HOSTCC scripts/dtc/dtc.o
> HOSTCC scripts/dtc/flattree.o
> HOSTCC scripts/dtc/fstree.o
> HOSTCC scripts/dtc/data.o
> HOSTCC scripts/dtc/livetree.o
> HOSTCC scripts/dtc/treesource.o
> HOSTCC scripts/dtc/srcpos.o
> HOSTCC scripts/dtc/checks.o
> HOSTCC scripts/dtc/util.o
> LEX scripts/dtc/dtc-lexer.lex.c
> YACC scripts/dtc/dtc-parser.tab.[ch]
> HOSTCC scripts/dtc/dtc-lexer.lex.o
> HOSTCC scripts/dtc/dtc-parser.tab.o
> HOSTCC scripts/dtc/yamltree.o
> HOSTLD scripts/dtc/dtc
> CHKDT Documentation/devicetree/bindings/processed-schema-examples.json
> /w/linux/Documentation/devicetree/bindings/soc/litex/litex,soc-controller.yaml:
> 'additionalProperties' is a required property
> /w/linux/Documentation/devicetree/bindings/soc/mediatek/devapc.yaml:
> 'additionalProperties' is a required property
> /w/linux/Documentation/devicetree/bindings/media/coda.yaml:
> 'additionalProperties' is a required property
> /w/linux/Documentation/devicetree/bindings/serial/litex,liteuart.yaml:
> 'additionalProperties' is a required property
> SCHEMA Documentation/devicetree/bindings/processed-schema-examples.json
> /w/linux/Documentation/devicetree/bindings/soc/litex/litex,soc-controller.yaml:
> ignoring, error in schema:
> warning: no schema found in file:
> ./Documentation/devicetree/bindings/soc/litex/litex,soc-controller.yaml
> /w/linux/Documentation/devicetree/bindings/soc/mediatek/devapc.yaml:
> ignoring, error in schema:
> warning: no schema found in file:
> ./Documentation/devicetree/bindings/soc/mediatek/devapc.yaml
> /w/linux/Documentation/devicetree/bindings/media/coda.yaml: ignoring,
> error in schema:
> warning: no schema found in file:
> ./Documentation/devicetree/bindings/media/coda.yaml
> /w/linux/Documentation/devicetree/bindings/serial/litex,liteuart.yaml:
> ignoring, error in schema:
> warning: no schema found in file:
> ./Documentation/devicetree/bindings/serial/litex,liteuart.yaml
> DTEX Documentation/devicetree/bindings/arm/fsl.example.dts
> DTC Documentation/devicetree/bindings/arm/fsl.example.dt.yaml
> CHECK Documentation/devicetree/bindings/arm/fsl.example.dt.yaml
Any further comments? I'm planning to send v3.
Jagan.
next prev parent reply other threads:[~2020-12-22 18:29 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-21 11:31 [PATCH v2 0/6] arm64: dts: imx8mm: Add Engicam i.Core MX8M Mini Jagan Teki
2020-12-21 11:31 ` [PATCH v2 1/6] arm64: defconfig: Enable REGULATOR_PF8X00 Jagan Teki
2020-12-21 13:42 ` Krzysztof Kozlowski
2020-12-21 11:31 ` [PATCH v2 2/6] dt-bindings: arm: fsl: Add Engicam i.Core MX8M Mini C.TOUCH 2.0 Jagan Teki
2020-12-21 13:46 ` Krzysztof Kozlowski
2020-12-21 13:59 ` Jagan Teki
2020-12-21 14:05 ` Krzysztof Kozlowski
2020-12-21 14:39 ` Jagan Teki
2020-12-21 14:42 ` Krzysztof Kozlowski
2020-12-21 14:47 ` Jagan Teki
2020-12-22 18:28 ` Jagan Teki [this message]
2020-12-22 20:25 ` Krzysztof Kozlowski
2020-12-22 20:32 ` Krzysztof Kozlowski
2020-12-21 11:31 ` [PATCH v2 3/6] arm64: dts: imx8mm: Add Engicam i.Core MX8M Mini SoM Jagan Teki
2020-12-21 13:52 ` Krzysztof Kozlowski
2020-12-21 11:31 ` [PATCH v2 4/6] arm64: dts: imx8mm: Add Engicam i.Core MX8M Mini C.TOUCH 2.0 Jagan Teki
2020-12-21 14:01 ` Krzysztof Kozlowski
2020-12-21 11:31 ` [PATCH v2 5/6] dt-bindings: arm: fsl: Add Engicam i.Core MX8M Mini EDIMM2.2 Starter Kit Jagan Teki
2020-12-21 11:31 ` [PATCH v2 6/6] arm64: dts: imx8mm: " Jagan Teki
2020-12-21 14:06 ` Krzysztof Kozlowski
2020-12-21 19:33 ` Jagan Teki
2020-12-21 21:06 ` Krzysztof Kozlowski
2020-12-22 8:50 ` Jagan Teki
2020-12-22 8:53 ` Krzysztof Kozlowski
2020-12-22 9:05 ` Jagan Teki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMty3ZCzB87_NGTRRvugcurSHWikcaCvKPuBBJJ1ocmqDQ8wzw@mail.gmail.com \
--to=jagan@amarulasolutions.com \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=krzk@kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-amarula@amarulasolutions.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).