From: Jagan Teki <jagan@amarulasolutions.com>
To: Adrien Grassein <adrien.grassein@gmail.com>
Cc: Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
Troy Kisky <troy.kisky@boundarydevices.com>
Subject: Re: [PATCH 3/6] regulator: dt-bindings: pf8x00: fix nxp,phase-shift doc
Date: Wed, 16 Dec 2020 02:36:54 +0530 [thread overview]
Message-ID: <CAMty3ZD2WsFeuCnt4DEL87Ou-sxHPYiBVu1n-LoK2gEzgO3XwQ@mail.gmail.com> (raw)
In-Reply-To: <20201215204858.8186-4-adrien.grassein@gmail.com>
On Wed, Dec 16, 2020 at 2:19 AM Adrien Grassein
<adrien.grassein@gmail.com> wrote:
>
> nxp,phase-shift is an enum so use enum format to describe it.
> Minimum and maximum values are also wrong.
>
> Signed-off-by: Adrien Grassein <adrien.grassein@gmail.com>
> ---
> .../bindings/regulator/nxp,pf8x00-regulator.yaml | 16 ++++------------
> 1 file changed, 4 insertions(+), 12 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/regulator/nxp,pf8x00-regulator.yaml b/Documentation/devicetree/bindings/regulator/nxp,pf8x00-regulator.yaml
> index 913532d0532e..1da724c6e2ba 100644
> --- a/Documentation/devicetree/bindings/regulator/nxp,pf8x00-regulator.yaml
> +++ b/Documentation/devicetree/bindings/regulator/nxp,pf8x00-regulator.yaml
> @@ -60,21 +60,13 @@ properties:
>
> nxp,phase-shift:
> $ref: "/schemas/types.yaml#/definitions/uint32"
> - minimum: 45
> - maximum: 0
> + minimum: 0
> + maximum: 315
> + default: 0
> + enum: [ 0, 45, 90, 135, 180, 225, 270, 315 ]
Do you mean 0 is the minimum or starting value? I can see Table 48.
SWx phase configuration with minimum and maximum values are starting
from 45, 90, 135, 180, 225, 270, 315, 0 with phase bits as 0x0 to 0x7
Jagan.
next prev parent reply other threads:[~2020-12-15 21:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-15 20:48 [PATCH 0/6] Fix issues on pf8x00 driver Adrien Grassein
2020-12-15 20:48 ` [PATCH 1/6] regulator: dt-bindings: remove useless properties Adrien Grassein
2020-12-15 20:48 ` [PATCH 2/6] regulator: pf8x00: add a doc for the module Adrien Grassein
2020-12-15 20:48 ` [PATCH 3/6] regulator: dt-bindings: pf8x00: fix nxp,phase-shift doc Adrien Grassein
2020-12-15 21:06 ` Jagan Teki [this message]
2020-12-15 21:09 ` Adrien Grassein
2020-12-15 20:48 ` [PATCH 4/6] regulator: dt-bindings: pf8x00: remove nxp,ilim-ma property Adrien Grassein
2020-12-15 20:48 ` [PATCH 5/6] regulator: " Adrien Grassein
2020-12-15 20:48 ` [PATCH 6/6] regulator: pf8x00: use linear range for buck 1-6 Adrien Grassein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMty3ZD2WsFeuCnt4DEL87Ou-sxHPYiBVu1n-LoK2gEzgO3XwQ@mail.gmail.com \
--to=jagan@amarulasolutions.com \
--cc=adrien.grassein@gmail.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=troy.kisky@boundarydevices.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).