From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jagan Teki Subject: Re: [PATCH 09/21] arm64: dts: allwinner: a64: Add HDMI support Date: Mon, 14 May 2018 16:01:15 +0530 Message-ID: References: <20180430114058.5061-1-jagan@amarulasolutions.com> <20180430114058.5061-10-jagan@amarulasolutions.com> <20180502113413.vv2r3ubfoh7gm3ms@flea> <20180514084050.ix5corfuvx33gsyn@flea> Reply-To: jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org In-Reply-To: <20180514084050.ix5corfuvx33gsyn@flea> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Maxime Ripard Cc: Chen-Yu Tsai , Icenowy Zheng , Jernej Skrabec , Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , David Airlie , dri-devel , Michael Turquette , Stephen Boyd , linux-clk , Michael Trimarchi , linux-arm-kernel , devicetree , linux-kernel , linux-sunxi List-Id: devicetree@vger.kernel.org On Mon, May 14, 2018 at 2:10 PM, Maxime Ripard wrote: > On Mon, May 14, 2018 at 02:03:36PM +0530, Jagan Teki wrote: >> On Wed, May 2, 2018 at 5:04 PM, Maxime Ripard wrote: >> > Hi, >> > >> > On Mon, Apr 30, 2018 at 05:10:46PM +0530, Jagan Teki wrote: >> >> + hdmi_phy: hdmi-phy@1ef0000 { >> >> + compatible = "allwinner,sun50i-a64-hdmi-phy", >> >> + "allwinner,sun8i-h3-hdmi-phy"; >> >> + reg = <0x01ef0000 0x10000>; >> >> + clocks = <&ccu CLK_BUS_HDMI>, <&ccu CLK_HDMI_DDC>, >> >> + <&ccu CLK_PLL_VIDEO1>; >> > >> > You were discussing that the PLL0 could also be used to clock the PHY, >> > has that been figured out? >> >> This is what I understand from Fig: 3-3. Module Clock Diagram, both >> tcon0 and tcon1 are using HDMI. I'm thinking based on the tcon >> configuration we need use proper PLL or some logic to get common PLL >> don't know yet. Since this series adding tcon1 I've attached PLL1. > > You're not describing the TCON node here though, but the HDMI one, and > the HDMI block is listed in both the PLL video 0 and 1. So how can we attach particular PLL with particular HDMI(PLL0 to HDMI0 and so-on) or do we need to attached both the PLL's any suggestion?