From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54C0AC4332F for ; Thu, 29 Dec 2022 09:57:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233186AbiL2J5n (ORCPT ); Thu, 29 Dec 2022 04:57:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40882 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233269AbiL2Jzl (ORCPT ); Thu, 29 Dec 2022 04:55:41 -0500 Received: from mail-yb1-xb2f.google.com (mail-yb1-xb2f.google.com [IPv6:2607:f8b0:4864:20::b2f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8845EAE41 for ; Thu, 29 Dec 2022 01:54:00 -0800 (PST) Received: by mail-yb1-xb2f.google.com with SMTP id t15so20034593ybq.4 for ; Thu, 29 Dec 2022 01:54:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=+yOD3yNpp4Sg8yVPxedVVEWiPubXWdIpWJ3m/jNQjH0=; b=dQ6fcikk6vSdmKrU4eLNH7HDLeidwKolv/8H1oeAG7B3pwfbe/kHq+/7rbE/BKd+RA n+mqeyGKLCphg6xq4Oz5tF6OBBE4Q1JQFKzdIxXoilNO4y4H0hyxMzb+9L1169fnqqy3 un6K0fBFwKRxCBklBsCzB3FI2vkT89pN/4fyQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+yOD3yNpp4Sg8yVPxedVVEWiPubXWdIpWJ3m/jNQjH0=; b=oHGZfzO2N4H0JszWjo9vw2XzoZWlEzJKnJ+LyQeKy4sdzDAc8CpHwoDVAvKt2t030E hGOyo09Uo+MZlNpLZov2bQDrgT06kC0ujeOjf2MHnnyhD4jQI+wSzDgtRNzhdqROMu8J eWa0BJpBeTg+AXUvU7v76o39jLvR6lRJj3PvXkJxvU0reZLTsnh0O93RNMv1WAdVNawk 5ueAcu83aHodV+8MkjXcKYP/oP3JV5IQEGUERu1rasolvkjQWHwaKhNU5zkzeVuUvPI9 cERz45YcQQihYK3p3DZ6vKs15mLl/Kb1MDGafWcjqhdLgP59bmLeb9AQ58q8UGAikZmK 54QA== X-Gm-Message-State: AFqh2kqC+Ub/UDJz42rcMDZ31CDoNi85bqfRequBnvPdRc8WGa4eh5NM OXVhT9BdrlYMUExEbHGA9PDfUZAgLRbvcMbxpUSr+AtY+MAq5+4LuME= X-Google-Smtp-Source: AMrXdXuoA9vvADI0ga1A0rofeM2WbLDlgYQM51CNwbZv9FCgQQSqThlpYZEU3IL66FDhwNeWBldubTZDmOBxovx8eek= X-Received: by 2002:a25:cc82:0:b0:6f9:bd14:f0b4 with SMTP id l124-20020a25cc82000000b006f9bd14f0b4mr3559292ybf.408.1672307639746; Thu, 29 Dec 2022 01:53:59 -0800 (PST) MIME-Version: 1.0 References: <20221227110335.2923359-1-javierm@redhat.com> <20221227110335.2923359-2-javierm@redhat.com> In-Reply-To: From: Jagan Teki Date: Thu, 29 Dec 2022 15:23:48 +0530 Message-ID: Subject: Re: [PATCH v3 1/4] dt-bindings: display: Add Himax HX8394 panel controller To: Javier Martinez Canillas Cc: Javier Martinez Canillas , devicetree@vger.kernel.org, Robert Mader , Onuralp Sezer , Neal Gompa , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Tom Fitzhenry , Martijn Braam , Krzysztof Kozlowski , Rob Herring , Ondrej Jirman , Peter Robinson , Krzysztof Kozlowski , =?UTF-8?Q?Kamil_Trzci=C5=84ski?= , Thierry Reding , Sam Ravnborg , Maya Matuszczyk Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, Dec 28, 2022 at 3:46 AM Javier Martinez Canillas wrote: > > On Tue, Dec 27, 2022 at 8:37 PM Jagan Teki wrote: > > > > On Wed, Dec 28, 2022 at 12:58 AM Javier Martinez Canillas > > wrote: > > > > > > Hello Jagan, > > > > > > On Tue, Dec 27, 2022 at 7:16 PM Jagan Teki wrote: > > > > > > [...] > > > > > > > > +allOf: > > > > > + - $ref: panel-common.yaml# > > > > > + > > > > > +properties: > > > > > + compatible: > > > > > + enum: > > > > > + # HannStar HSD060BHW4 5.99" 720x1440 TFT LCD panel > > > > > + - hannstar,hsd060bhw4 > > > > > > > > Parent controller can have a compatible where the associated panels > > > > will be enum list. > > > > > > > > > > I'm not sure to follow what you meant. Could you please elaborate? > > > > compatible: > > items: > > - enum: > > - hannstar,hsd060bhw4 > > - const: himax,hx8394 > > > > himax,hx8394 is the actual controller and is denoted as fallback compatible. > > > > I see. Do you have an example of a panel controller that does this? I > don't see that much value in doing this since you want the DTS to > describe the actual HW and so want the panel I believe. Yes, but the Panel needs to be built on top of the display IC so the actual parent here is the display IC and the panel is sub-HW. This is what usually follows, here are some reference bindings. https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/Documentation/devicetree/bindings/display/panel/jadard,jd9365da-h3.yaml https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/Documentation/devicetree/bindings/display/panel/sitronix,st7701.yaml https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/Documentation/devicetree/bindings/display/panel/ilitek,ili9163.yaml https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/Documentation/devicetree/bindings/display/panel/ilitek,ili9322.yaml Jagan.