From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jagan Teki Subject: Re: [PATCH v4 1/4] clk: sunxi-ng: Enable DE2_CCU for SUN8I and SUN50I Date: Wed, 5 Sep 2018 13:25:30 +0530 Message-ID: References: <20180904163609.10171-1-jagan@amarulasolutions.com> <20180905070335.dclhpxjld4vdkdu4@flea> Reply-To: jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org In-Reply-To: <20180905070335.dclhpxjld4vdkdu4@flea> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Maxime Ripard Cc: Chen-Yu Tsai , Icenowy Zheng , Jernej Skrabec , Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , David Airlie , dri-devel , Michael Turquette , Stephen Boyd , linux-clk , Michael Trimarchi , linux-arm-kernel , devicetree , linux-kernel , linux-sunxi List-Id: devicetree@vger.kernel.org On Wed, Sep 5, 2018 at 12:33 PM, Maxime Ripard wrote: > On Tue, Sep 04, 2018 at 10:06:06PM +0530, Jagan Teki wrote: >> Allwinner SoC like SUN8I and SUN50I has DE2 CCU so enable them >> as default. >> >> Signed-off-by: Jagan Teki >> --- >> Changes for v4, v3: >> - none >> Changes for v2: >> - Enable for MACH_SUN8I >> >> drivers/clk/sunxi-ng/Kconfig | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/clk/sunxi-ng/Kconfig b/drivers/clk/sunxi-ng/Kconfig >> index 826674d090fd..e20182aa9748 100644 >> --- a/drivers/clk/sunxi-ng/Kconfig >> +++ b/drivers/clk/sunxi-ng/Kconfig >> @@ -63,6 +63,8 @@ config SUN8I_V3S_CCU >> >> config SUN8I_DE2_CCU >> bool "Support for the Allwinner SoCs DE2 CCU" >> + default MACH_SUN8I || (ARM64 && ARCH_SUNXI) >> + depends on DRM_SUN4I && (MACH_SUN8I || (ARM64 && ARCH_SUNXI)) > > I don't see why there's a dependency on the DRM driver. I'm pretty > sure this would even break simplefb. Ok, got it. I will drop the depends on just add default.