From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 960A5C433E0 for ; Tue, 16 Mar 2021 15:35:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5392A650F0 for ; Tue, 16 Mar 2021 15:35:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230508AbhCPPf0 (ORCPT ); Tue, 16 Mar 2021 11:35:26 -0400 Received: from mail-vs1-f44.google.com ([209.85.217.44]:46711 "EHLO mail-vs1-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238125AbhCPPfC (ORCPT ); Tue, 16 Mar 2021 11:35:02 -0400 Received: by mail-vs1-f44.google.com with SMTP id p24so18401674vsj.13; Tue, 16 Mar 2021 08:35:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bQXFQUK1Smo7zLwGGBtKvcaQNYzdWt9/qzFR9xYxQFU=; b=rj/oSvQfMzDVW6Vrz5CKUkcNd86omR2EAPLRVX9fV+PNZOj9ZFvmZ6xQAZZ3kyBbtX G3B26Z7xRUVsc8c6J+i0/2pvu+5A6Ls/VEAI80nG3S3kYAOFffOr8uSmFv1jDEh3E+lz ZH+GcmWcuAv0cQtOeRoBU9DA0ugaxKCBwnJqrDKGovpAOCsZxv7vShMYTwhoA7RGocAs YqwHo914Tl3yeRj8Aj4rPvO61iIPSKSjtrXE6W4Aaq+uaK2opSMp+XFOAkQuQ4/trEVQ f7gngwRvaoa5md5Aal/FlQKfztPwo6CyXrvAwPFyFG0Eu2CXH7RP1cvVGRFy0i83VcVa rgcw== X-Gm-Message-State: AOAM533DlDyFaAst/HZLv7h8zSM/E1+SMhY3cUV+Jy6paCH6UbysuhID i3mIrf+Jwo7qQZuOXOFXJnls4CVpYO1+/TJiiZw= X-Google-Smtp-Source: ABdhPJyiREAov3bNX/VpoD0WiQljCXe/K/wAaktLKqeyeqzULAafFKKBHsJA0VsqBFIKp1TItrvPZJ2crVn4Y+MyLis= X-Received: by 2002:a67:8883:: with SMTP id k125mr9392973vsd.18.1615908901334; Tue, 16 Mar 2021 08:35:01 -0700 (PDT) MIME-Version: 1.0 References: <20210316150033.15987-1-cnsztl@gmail.com> In-Reply-To: <20210316150033.15987-1-cnsztl@gmail.com> From: Geert Uytterhoeven Date: Tue, 16 Mar 2021 16:34:50 +0100 Message-ID: Subject: Re: [PATCH v3 2/2] rockchip: rk3399: Add support for FriendlyARM NanoPi R4S To: Tianling Shen Cc: Rob Herring , Heiko Stuebner , Jagan Teki , Chen-Yu Tsai , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , Johan Jonker , David Bauer , Jensen Huang , Marty Jones , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux ARM , "open list:ARM/Rockchip SoC..." , Linux Kernel Mailing List , Jacek Anaszewski , Pavel Machek Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Tianling, CC Jacek, Pavel On Tue, Mar 16, 2021 at 4:00 PM Tianling Shen wrote: > On 2021-03-16 02:23 Geert Uytterhoeven wrote: > > Personally, I'm not so fond of the -%u node names, and prefer > > -. With the former, it's way too easy to have a silent > > override in your .dts(i) stack. > > Cfr. commit 45f5d5a9e34d3fe4 ("arm64: dts: renesas: r8a77995: draak: > > Fix backlight regulator name") > > How about using `lan-led`, `sys-led` and `wan-led` here? Documentation/devicetree/bindings/leds/leds-gpio.yaml says "led-%u" is the preferred form, but that anything containing "led" as a substring is accepted. So I'd go for "led-lan" etc. BTW, you can validate your DTB against the leds-gpio DT bindings by running: make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/leds/leds-gpio.yaml Background info for CCed parties: https://lore.kernel.org/linux-arm-kernel/20210316150033.15987-1-cnsztl@gmail.com/ Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds